[PATCH] drm/i915/dp: promote clock recovery failures to DRM_ERROR

[PATCH] drm/i915/dp: promote clock recovery failures to DRM_ERROR

[Jani Nikula]

If channel equalization succeeds, there's no indication something went
wrong in clock recovery (unless debug is enabled). We should shout about
the failures and fix them instead of hiding them under the carpet.

This has allowed bugs like [1] stay dormant for a long time.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=70117

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 0ed7717..f349931 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -2517,7 +2517,7 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
 		if (i == intel_dp->lane_count) {
 			++loop_tries;
 			if (loop_tries == 5) {
-				DRM_DEBUG_KMS("too many full retries, give up\n");
+				DRM_ERROR("too many full retries, give up\n");
 				break;
 			}
 			intel_dp_reset_link_train(intel_dp, &DP,
@@ -2531,7 +2531,7 @@ intel_dp_start_link_train(struct intel_dp *intel_dp)
 		if ((intel_dp->train_set[0] & DP_TRAIN_VOLTAGE_SWING_MASK) == voltage) {
 			++voltage_tries;
 			if (voltage_tries == 5) {
-				DRM_DEBUG_KMS("too many voltage retries, give up\n");
+				DRM_ERROR("too many voltage retries, give up\n");
 				break;
 			}
 		} else
-- 
1.7.10.4

Re: [PATCH] drm/i915/dp: promote clock recovery failures to DRM_ERROR

[Daniel Vetter]

On Sat, Oct 05, 2013 at 04:13:56PM +0300, Jani Nikula wrote:
> If channel equalization succeeds, there's no indication something went
> wrong in clock recovery (unless debug is enabled). We should shout about
> the failures and fix them instead of hiding them under the carpet.
> 
> This has allowed bugs like [1] stay dormant for a long time.
> 
> [1] https://bugs.freedesktop.org/show_bug.cgi?id=70117
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Yeah, makes tons of sense. Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch