From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Add breadcrumbs for why the backlight is being set
Date: Mon, 14 Oct 2013 10:03:17 +0200 [thread overview]
Message-ID: <20131014080317.GP8303@phenom.ffwll.local> (raw)
In-Reply-To: <1381665391-20083-1-git-send-email-chris@chris-wilson.co.uk>
On Sun, Oct 13, 2013 at 12:56:31PM +0100, Chris Wilson wrote:
> At the moment we have 3 paths that lead to actually_set_backlight(),
> from modesetting, ACPI/OpRegion requests and our very own
> intel_backlight interface, and we have no way of distinguishing them in
> the debug log. So add a debug breadcrumb to explain the source of the
> backlight changes.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Yeah, we seem to have a bunch of bugs where the backlight somehow gets
smashed to 0 and we don't know why. Queued for -next, thanks for the
patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-10-14 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 11:56 [PATCH] drm/i915: Add breadcrumbs for why the backlight is being set Chris Wilson
2013-10-14 7:42 ` Jani Nikula
2013-10-14 7:54 ` Chris Wilson
2013-10-14 8:06 ` Jani Nikula
2013-10-14 8:20 ` Daniel Vetter
2013-10-14 8:03 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131014080317.GP8303@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox