From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Add breadcrumbs for why the backlight is being set
Date: Mon, 14 Oct 2013 11:06:13 +0300 [thread overview]
Message-ID: <87r4bo6zuy.fsf@intel.com> (raw)
In-Reply-To: <20131014075424.GA29679@nuc-i3427.alporthouse.com>
On Mon, 14 Oct 2013, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Mon, Oct 14, 2013 at 10:42:37AM +0300, Jani Nikula wrote:
>> On Sun, 13 Oct 2013, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
>> > index 2acf5cae20e4..564da613b278 100644
>> > --- a/drivers/gpu/drm/i915/intel_opregion.c
>> > +++ b/drivers/gpu/drm/i915/intel_opregion.c
>> > @@ -405,6 +405,7 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
>> > if (bclp > 255)
>> > return ASLC_BACKLIGHT_FAILED;
>> >
>> > + DRM_DEBUG_KMS("updating opregion backlight %d/255\n", bclp);
>>
>> Just a few lines earliner we have:
>>
>> DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp);
>
> Right, I wasn't sure about changing that to suite my purposes - I
> guessed that it was intentionally a different debug level pre-validation
> for a reason and so added a new message at the debug level as the
> messages within the modesetting and backlight operation.
Please just change that to suit your needs instead of adding a new one.
Jani.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2013-10-14 8:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 11:56 [PATCH] drm/i915: Add breadcrumbs for why the backlight is being set Chris Wilson
2013-10-14 7:42 ` Jani Nikula
2013-10-14 7:54 ` Chris Wilson
2013-10-14 8:06 ` Jani Nikula [this message]
2013-10-14 8:20 ` Daniel Vetter
2013-10-14 8:03 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4bo6zuy.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox