From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: MI_PREDICATE_RESULT_2 is HSW only
Date: Fri, 29 Nov 2013 15:51:58 +0100 [thread overview]
Message-ID: <20131129145158.GB27344@phenom.ffwll.local> (raw)
In-Reply-To: <20131129134844.GG27806@nuc-i3427.alporthouse.com>
On Fri, Nov 29, 2013 at 01:48:44PM +0000, Chris Wilson wrote:
> On Fri, Nov 29, 2013 at 02:56:12PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The MI_PREDICATE_RESULT_2 register exits only on HSW. On other
> > platforms the same offset is either reserved, or contains some
> > other register. So write the register only on HSW.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Couldn't find a conflict, but we all agree that writing to registers
> that do not exist is just a recipe for disaster.
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Oops, actually merged this one but then accidentally replied to the vmap
fix. Both are now in -fixes.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-11-29 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 12:56 [PATCH] drm/i915: MI_PREDICATE_RESULT_2 is HSW only ville.syrjala
2013-11-29 13:48 ` Chris Wilson
2013-11-29 14:51 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131129145158.GB27344@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox