From: Daniel Vetter <daniel@ffwll.ch>
To: Kristen Carlson Accardi <kristen@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] i915: send D1 opregion notification
Date: Tue, 14 Jan 2014 10:26:02 +0100 [thread overview]
Message-ID: <20140114092602.GR4770@phenom.ffwll.local> (raw)
In-Reply-To: <1389648765-10904-1-git-send-email-kristen@linux.intel.com>
On Mon, Jan 13, 2014 at 01:32:45PM -0800, Kristen Carlson Accardi wrote:
> The opregion notification for runtime suspend should be D1, not D3.
> This is to maintain compatibility with firmware.
>
> Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 61fb9fc..a6c370a 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -925,7 +925,7 @@ static int i915_runtime_suspend(struct device *device)
>
> del_timer_sync(&dev_priv->gpu_error.hangcheck_timer);
> dev_priv->pm.suspended = true;
> - intel_opregion_notify_adapter(dev, PCI_D3cold);
> + intel_opregion_notify_adapter(dev, PCI_D1);
This needs a bigger comment and some mention on which platforms we exactly
need this ... Or do the bios people plan to stick to this for bdw/vlv and
all the further stuff?
-Daniel
>
> return 0;
> }
> --
> 1.8.3.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-01-14 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 21:32 [PATCH] i915: send D1 opregion notification Kristen Carlson Accardi
2014-01-14 9:26 ` Daniel Vetter [this message]
2014-01-14 19:19 ` Jesse Barnes
2014-01-14 23:06 ` Kristen Carlson Accardi
2014-01-14 23:08 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114092602.GR4770@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kristen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox