Re: [PATCH] i915: send D1 opregion notification

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Tue, 14 Jan 2014 10:26:02 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Mon, Jan 13, 2014 at 01:32:45PM -0800, Kristen Carlson Accardi wrote:
> > The opregion notification for runtime suspend should be D1, not D3.
> > This is to maintain compatibility with firmware.
> > 
> > Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_drv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > index 61fb9fc..a6c370a 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.c
> > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > @@ -925,7 +925,7 @@ static int i915_runtime_suspend(struct device *device)
> >  
> >  	del_timer_sync(&dev_priv->gpu_error.hangcheck_timer);
> >  	dev_priv->pm.suspended = true;
> > -	intel_opregion_notify_adapter(dev, PCI_D3cold);
> > +	intel_opregion_notify_adapter(dev, PCI_D1);
> 
> This needs a bigger comment and some mention on which platforms we exactly
> need this ... Or do the bios people plan to stick to this for bdw/vlv and
> all the further stuff?

Doc # would help too, even if it's CDI or internal only... I don't know
where to find this info, or if I did I've forgotten.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center