From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/2] drm/i915: drop the i915.fbpercrtc module parameter
Date: Tue, 21 Jan 2014 10:28:22 +0100 [thread overview]
Message-ID: <20140121092822.GL15089@phenom.ffwll.local> (raw)
In-Reply-To: <1390296265-23565-1-git-send-email-jani.nikula@intel.com>
On Tue, Jan 21, 2014 at 11:24:24AM +0200, Jani Nikula wrote:
> It's unused, and nowadays specifying unknown parameters no longer
> prevents modules from being loaded.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/i915_drv.c | 3 ---
> drivers/gpu/drm/i915/i915_drv.h | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 62c0f16b869d..a543667140fa 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -44,9 +44,6 @@ MODULE_PARM_DESC(modeset,
> "Use kernel modesetting [KMS] (0=DRM_I915_KMS from .config, "
> "1=on, -1=force vga console preference [default])");
>
> -unsigned int i915_fbpercrtc __always_unused = 0;
> -module_param_named(fbpercrtc, i915_fbpercrtc, int, 0400);
> -
> int i915_panel_ignore_lid __read_mostly = 1;
> module_param_named(panel_ignore_lid, i915_panel_ignore_lid, int, 0600);
> MODULE_PARM_DESC(panel_ignore_lid,
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index f888fea9cb5d..56c720b789bc 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1896,7 +1896,6 @@ struct drm_i915_file_private {
>
> extern const struct drm_ioctl_desc i915_ioctls[];
> extern int i915_max_ioctl;
> -extern unsigned int i915_fbpercrtc __always_unused;
> extern int i915_panel_ignore_lid __read_mostly;
> extern unsigned int i915_powersave __read_mostly;
> extern int i915_semaphores __read_mostly;
> --
> 1.7.9.5
>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-01-21 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 11:26 [RFC PATCH] drm/i915: move module parameters into a struct Jani Nikula
2014-01-03 16:19 ` Paulo Zanoni
2014-01-07 7:55 ` Daniel Vetter
2014-01-21 9:24 ` [PATCH v2 1/2] drm/i915: drop the i915.fbpercrtc module parameter Jani Nikula
2014-01-21 9:24 ` [PATCH v2 2/2] drm/i915: move module parameters into a struct, in a new file Jani Nikula
2014-01-26 14:38 ` Daniel Vetter
2014-01-21 9:28 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140121092822.GL15089@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox