From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Ben Widawsky <ben@bwidawsk.net>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] Revert "drm/i915: fix infinite loop at gen6_update_ring_freq"
Date: Wed, 23 Apr 2014 09:05:06 +0200 [thread overview]
Message-ID: <20140423070506.GQ10722@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGRgjyL4RHXuxs4vqr6fucPyQi9ushfR0-n_J7xTtAqSkQ@mail.gmail.com>
On Tue, Apr 22, 2014 at 06:25:12PM -0300, Paulo Zanoni wrote:
> 2014-04-11 6:02 GMT-03:00 Daniel Vetter <daniel@ffwll.ch>:
> > On Thu, Apr 10, 2014 at 10:52:26AM -0700, Ben Widawsky wrote:
> >> On Thu, Apr 10, 2014 at 10:50:43AM -0700, Ben Widawsky wrote:
> >> > On Thu, Apr 10, 2014 at 09:04:47AM +0200, Daniel Vetter wrote:
> >> > > This reverts commit 4b28a1f3ef55a3b0b68dbab1fe6dbaf18e186710.
> >> > >
> >> > > This patch duct-tapes over some issue in the current bdw rps patches
> >> > > which must wait with enabling rc6/rps until the very first batch has
> >> > > been submitted by userspace.
> >> > >
> >> > > But those patches aren't merged yet, and for upstream we need to have
> >> > > an in-kernel emission of the very first batch. I shouldn't have
> >> > > merged this patch so let's revert it again.
> >> >
> >> > I said this on the mailing last before you merged the patch.
> >>
> >> 20140402050338.GB13824@bwidawsk.net
> >
> > 20140402145813.GV7225@phenom.ffwll.local will explain things.
>
> There's now a regression report pointing to the revert:
> https://bugs.freedesktop.org/show_bug.cgi?id=77565 .
>
> What is the proposed solution now? Just WARN and still avoid the
> infinite loop? Or keep the infinite loop and leave the bug open?
> Disable BDW runtime PM?
I've thought that we can only hit this with the as-yet unmerged rc6
patches on bdw, so I'm really confused why this blows up now?
In any case I've thought Imre has stumbled over a similar issue on byt and
he has a fix to prevent runtime pm until the delayed rps init has run.
I've assigned the bug to him.
Still confused why this suddenly blew up ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-04-23 7:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 7:04 [PATCH] Revert "drm/i915: fix infinite loop at gen6_update_ring_freq" Daniel Vetter
2014-04-10 17:50 ` Ben Widawsky
2014-04-10 17:52 ` Ben Widawsky
2014-04-11 9:02 ` Daniel Vetter
2014-04-22 21:25 ` Paulo Zanoni
2014-04-23 7:05 ` Daniel Vetter [this message]
2014-04-28 18:14 ` Paulo Zanoni
2014-04-28 19:23 ` Daniel Vetter
2014-04-28 19:54 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423070506.GQ10722@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox