From: Imre Deak <imre.deak@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <ben@bwidawsk.net>,
Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] Revert "drm/i915: fix infinite loop at gen6_update_ring_freq"
Date: Mon, 28 Apr 2014 22:54:21 +0300 [thread overview]
Message-ID: <1398714861.3074.30.camel@ideak-mobl> (raw)
In-Reply-To: <CAKMK7uHBPGZkaXnHrBhcu8TRp__NkhiLzULiXVyStyFJw-P7vA@mail.gmail.com>
On Mon, 2014-04-28 at 21:23 +0200, Daniel Vetter wrote:
> On Mon, Apr 28, 2014 at 8:14 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> > This can probably be reproduced on non-BDW machines too, with RC6 disabled.
>
> If I understand Imre's patch correctly the bug is that we didn't have
> rc6 on bdw, but the sanitize function didn't make this clear leading
> to bugs.
Yes, that's correct. For runtime PM we require RC6 to be enabled, and we
use intel_enable_rc6() to check for this. Before patch [1]
intel_enable_rc6() reported incorrectly on BDW that RC6 is enabled.
--Imre
[1]
http://lists.freedesktop.org/archives/intel-gfx/2014-April/044354.html
>If my understanding is wrong the I need to drop Imre's patch again.
> -Daniel
prev parent reply other threads:[~2014-04-28 19:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 7:04 [PATCH] Revert "drm/i915: fix infinite loop at gen6_update_ring_freq" Daniel Vetter
2014-04-10 17:50 ` Ben Widawsky
2014-04-10 17:52 ` Ben Widawsky
2014-04-11 9:02 ` Daniel Vetter
2014-04-22 21:25 ` Paulo Zanoni
2014-04-23 7:05 ` Daniel Vetter
2014-04-28 18:14 ` Paulo Zanoni
2014-04-28 19:23 ` Daniel Vetter
2014-04-28 19:54 ` Imre Deak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398714861.3074.30.camel@ideak-mobl \
--to=imre.deak@intel.com \
--cc=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox