[PATCH] drm/i915: Drop unused lut tables from intel_plane

[PATCH] drm/i915: Drop unused lut tables from intel_plane

[Matt Roper]

Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/intel_drv.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 76de420..fea8e05 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -428,7 +428,6 @@ struct intel_plane {
 	struct drm_i915_gem_object *obj;
 	bool can_scale;
 	int max_downscale;
-	u32 lut_r[1024], lut_g[1024], lut_b[1024];
 	int crtc_x, crtc_y;
 	unsigned int crtc_w, crtc_h;
 	uint32_t src_x, src_y;
-- 
1.8.5.1

Re: [PATCH] drm/i915: Drop unused lut tables from intel_plane

[Damien Lespiau]

On Mon, Jun 02, 2014 at 10:12:06AM -0700, Matt Roper wrote:
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>

The commit message is a bit terse and could do with some digging.
Something like:

Those LUT where defined in the original sprite patch introducing intel_plane,
but were never used.

  commit b840d907fcf6d5d5ef91af4518b3dab3a5da0f75
  Author: Jesse Barnes <jbarnes@virtuousgeek.org>
  Date:   Tue Dec 13 13:19:38 2011 -0800

    drm/i915: add SNB and IVB video sprite support v6
    
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_drv.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index 76de420..fea8e05 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -428,7 +428,6 @@ struct intel_plane {
>  	struct drm_i915_gem_object *obj;
>  	bool can_scale;
>  	int max_downscale;
> -	u32 lut_r[1024], lut_g[1024], lut_b[1024];
>  	int crtc_x, crtc_y;
>  	unsigned int crtc_w, crtc_h;
>  	uint32_t src_x, src_y;
> -- 
> 1.8.5.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Drop unused lut tables from intel_plane

[Daniel Vetter]

On Mon, Jun 02, 2014 at 07:06:52PM +0100, Damien Lespiau wrote:
> On Mon, Jun 02, 2014 at 10:12:06AM -0700, Matt Roper wrote:
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> 
> The commit message is a bit terse and could do with some digging.
> Something like:
> 
> Those LUT where defined in the original sprite patch introducing intel_plane,
> but were never used.
> 
>   commit b840d907fcf6d5d5ef91af4518b3dab3a5da0f75
>   Author: Jesse Barnes <jbarnes@virtuousgeek.org>
>   Date:   Tue Dec 13 13:19:38 2011 -0800
> 
>     drm/i915: add SNB and IVB video sprite support v6

Added.

> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

Queued for -next, thanks for the patch.
-Daniel

> 
> > ---
> >  drivers/gpu/drm/i915/intel_drv.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> > index 76de420..fea8e05 100644
> > --- a/drivers/gpu/drm/i915/intel_drv.h
> > +++ b/drivers/gpu/drm/i915/intel_drv.h
> > @@ -428,7 +428,6 @@ struct intel_plane {
> >  	struct drm_i915_gem_object *obj;
> >  	bool can_scale;
> >  	int max_downscale;
> > -	u32 lut_r[1024], lut_g[1024], lut_b[1024];
> >  	int crtc_x, crtc_y;
> >  	unsigned int crtc_w, crtc_h;
> >  	uint32_t src_x, src_y;
> > -- 
> > 1.8.5.1
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch