Re: [PATCH] drm/i915: Track frontbuffer invalidation/flushing

[Daniel Vetter <daniel@ffwll.ch>]

On Thu, Jun 19, 2014 at 04:12:08PM +0100, Chris Wilson wrote:
> On Thu, Jun 19, 2014 at 04:01:59PM +0200, Daniel Vetter wrote:
> > diff --git a/drivers/gpu/drm/i915/intel_overlay.c b/drivers/gpu/drm/i915/intel_overlay.c
> > index 99b6c142a095..1c002196ed47 100644
> > --- a/drivers/gpu/drm/i915/intel_overlay.c
> > +++ b/drivers/gpu/drm/i915/intel_overlay.c
> > @@ -787,6 +787,9 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay,
> >  	overlay->old_vid_bo = overlay->vid_bo;
> >  	overlay->vid_bo = new_bo;
> >  
> > +	intel_frontbuffer_flush(dev,
> > +				INTEL_FRONTBUFFER_OVERLAY(pipe));
> > +
> 
> If we want to be strict, we could do the flip_prepare, flip_complete
> here as well. Basically, I'm arguing that this is actually a
> semi-disguised flip.

Fixed.

> With this changed to _flip,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Thanks, I've merged the core patches + the psr patches that Rodrigo
already reviewed to dinq. The remaining parts are in my psr-stuff branch
so that Rodrigo finish the byt rebasing on top of it while I'm
vacationing.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch