From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Daniel <thomas.daniel@intel.com>
Cc: intel-gfx@lists.freedesktop.org, shuang.he@linux.intel.com
Subject: Re: [PATCH 2/2] drm/i915/bdw: Setup global hardware status page in execlists mode
Date: Fri, 24 Oct 2014 10:14:51 +0200 [thread overview]
Message-ID: <20141024081451.GT26941@phenom.ffwll.local> (raw)
In-Reply-To: <1414077886-19017-1-git-send-email-thomas.daniel@intel.com>
On Thu, Oct 23, 2014 at 04:24:46PM +0100, Thomas Daniel wrote:
> Write HWS_PGA address even in execlists mode as the global hardware status
> page is still required. This address was previously uninitialized and
> HWSP writes would clobber whatever buffer happened to reside at GGTT
> address 0.
>
> Issue: VIZ-2020
> Signed-off-by: Thomas Daniel <thomas.daniel@intel.com>
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 666cb28..ad36d66 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -1678,6 +1678,7 @@ int intel_lr_context_deferred_create(struct intel_context *ctx,
> uint32_t context_size;
> struct intel_ringbuffer *ringbuf;
> int ret;
> + struct drm_i915_private *dev_priv = dev->dev_private;
>
> WARN_ON(ctx->legacy_hw_ctx.rcs_state != NULL);
> if (ctx->engine[ring->id].state)
> @@ -1750,6 +1751,10 @@ int intel_lr_context_deferred_create(struct intel_context *ctx,
> if (ring->status_page.page_addr == NULL)
> return -ENOMEM;
> ring->status_page.obj = ctx_obj;
> +
> + I915_WRITE(RING_HWS_PGA(ring->mmio_base),
> + (u32)ring->status_page.gfx_addr);
> + POSTING_READ(RING_HWS_PGA(ring->mmio_base));
So every time a random new contexts gets created we write a new value into
the HWS_PGA register? Shouldn't this only be done when we set up the
default/system context?
-Daniel
> }
>
> if (ring->id == RCS && !ctx->rcs_initialized) {
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-10-24 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 15:24 [PATCH 2/2] drm/i915/bdw: Setup global hardware status page in execlists mode Thomas Daniel
2014-10-23 15:41 ` Chris Wilson
2014-10-24 8:14 ` Daniel Vetter [this message]
2014-10-24 8:30 ` Daniel, Thomas
2014-10-24 8:48 ` Daniel Vetter
2014-10-24 9:36 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141024081451.GT26941@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=shuang.he@linux.intel.com \
--cc=thomas.daniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox