From: Damien Lespiau <damien.lespiau@intel.com>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 0/4] SKL eDP clocks
Date: Mon, 17 Nov 2014 17:08:26 +0000 [thread overview]
Message-ID: <20141117170826.GD2244@strange.icx.intel.com> (raw)
In-Reply-To: <CA+gsUGQYb_ftChsk=X6-FYf3i8Uc0+AbEA4_UpUH7r6YiSR2yg@mail.gmail.com>
On Mon, Nov 17, 2014 at 03:04:19PM -0200, Paulo Zanoni wrote:
> 2014-11-14 15:24 GMT-02:00 Damien Lespiau <damien.lespiau@intel.com>:
> > The previous clock series didn't include the eDP side of it. This should
> > address most of it, for now.
> >
> > Note that I have some issues with HBR2 and link training here and I'm trying to
> > find more information about this. So depending on the configuration (number of
> > lanes wired, panel bw) this series may not be enough to light up an eDP panel.
>
> I couldn't spot anything obvious here...
>
> For all patches: Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Thanks!
> My bikeshedding would be to replace the magic "(id * 6)" - from
> patches 2 and 4 - and "0x3f" - from patch 4 - with some nice macro
> definitions.
Yes, that's also the case for the rest of the SKL DPLL code, the plan is
to fix that on top.
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2014-11-17 17:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 17:24 [PATCH 0/4] SKL eDP clocks Damien Lespiau
2014-11-14 17:24 ` [PATCH 1/4] drm/i915/skl: Remove spurious warn in get_ddi_pll() Damien Lespiau
2014-11-17 12:40 ` Paulo Zanoni
2014-11-14 17:24 ` [PATCH 2/4] drm/i915/skl: Set the eDP link rate on DPLL0 Damien Lespiau
2014-11-17 18:24 ` Daniel Vetter
2014-11-14 17:24 ` [PATCH 3/4] drm/i915/skl: Use the pipe config DPLL tracking to query the link clock Damien Lespiau
2014-11-14 17:24 ` [PATCH 4/4] drm/i915/skl: Read out crtl1 for eDP/DPLL0 Damien Lespiau
2014-11-15 5:28 ` shuang.he
2014-11-15 10:54 ` Damien Lespiau
2014-11-17 15:03 ` Daniel Vetter
2014-11-18 8:14 ` He, Shuang
2014-11-18 8:11 ` He, Shuang
2014-11-17 18:28 ` Daniel Vetter
2014-11-18 8:18 ` Daniel Vetter
2014-11-21 16:00 ` [PATCH v2] " Damien Lespiau
2014-11-21 16:14 ` [PATCH v3] " Damien Lespiau
2014-11-21 17:46 ` Daniel Vetter
2014-11-17 17:04 ` [PATCH 0/4] SKL eDP clocks Paulo Zanoni
2014-11-17 17:08 ` Damien Lespiau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117170826.GD2244@strange.icx.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox