From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/i915/skl: Read out crtl1 for eDP/DPLL0
Date: Fri, 21 Nov 2014 18:46:40 +0100 [thread overview]
Message-ID: <20141121174640.GU25711@phenom.ffwll.local> (raw)
In-Reply-To: <1416586496-14341-1-git-send-email-damien.lespiau@intel.com>
On Fri, Nov 21, 2014 at 04:14:56PM +0000, Damien Lespiau wrote:
> v2: Put the DPLL0 state readout in skylake_get_ddi_pll(), closer to
> where the PLL assignement read out is done rather than the frequency
> readout function. (Daniel)
>
> v3: Remove stray new line (Damien)
> Add Paulo's r-b tag for v1
>
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> (v1)
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
I still think it might be safer to put DPLL0 into the shared
infrastructure too just because. But this looks good as-is.
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-11-21 17:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-14 17:24 [PATCH 0/4] SKL eDP clocks Damien Lespiau
2014-11-14 17:24 ` [PATCH 1/4] drm/i915/skl: Remove spurious warn in get_ddi_pll() Damien Lespiau
2014-11-17 12:40 ` Paulo Zanoni
2014-11-14 17:24 ` [PATCH 2/4] drm/i915/skl: Set the eDP link rate on DPLL0 Damien Lespiau
2014-11-17 18:24 ` Daniel Vetter
2014-11-14 17:24 ` [PATCH 3/4] drm/i915/skl: Use the pipe config DPLL tracking to query the link clock Damien Lespiau
2014-11-14 17:24 ` [PATCH 4/4] drm/i915/skl: Read out crtl1 for eDP/DPLL0 Damien Lespiau
2014-11-15 5:28 ` shuang.he
2014-11-15 10:54 ` Damien Lespiau
2014-11-17 15:03 ` Daniel Vetter
2014-11-18 8:14 ` He, Shuang
2014-11-18 8:11 ` He, Shuang
2014-11-17 18:28 ` Daniel Vetter
2014-11-18 8:18 ` Daniel Vetter
2014-11-21 16:00 ` [PATCH v2] " Damien Lespiau
2014-11-21 16:14 ` [PATCH v3] " Damien Lespiau
2014-11-21 17:46 ` Daniel Vetter [this message]
2014-11-17 17:04 ` [PATCH 0/4] SKL eDP clocks Paulo Zanoni
2014-11-17 17:08 ` Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121174640.GU25711@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox