From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Do not return unknown status when load detection is tested.
Date: Tue, 1 Mar 2016 19:27:21 +0200 [thread overview]
Message-ID: <20160301172721.GM15993@intel.com> (raw)
In-Reply-To: <1456848241-6431-1-git-send-email-maarten.lankhorst@linux.intel.com>
On Tue, Mar 01, 2016 at 05:04:01PM +0100, Maarten Lankhorst wrote:
> This fixes the IGT test, which interprets unknown status as failed to
> acquire load detect pipe.
Change the expectation of the test?
But more importantly, how can it fail to find a pipe when there's
kmstest_unset_all_crtcs() in the test?
>
> Cc: Gabriel Feceoru <gabriel.feceoru@intel.com>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_crt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
> index 505fc5cf26f8..4b2dfa1bb00e 100644
> --- a/drivers/gpu/drm/i915/intel_crt.c
> +++ b/drivers/gpu/drm/i915/intel_crt.c
> @@ -652,6 +652,8 @@ intel_crt_detect(struct drm_connector *connector, bool force)
> else if (INTEL_INFO(dev)->gen < 4)
> status = intel_crt_load_detect(crt,
> to_intel_crtc(connector->state->crtc)->pipe);
> + else if (i915.load_detect_test)
> + status = connector_status_disconnected;
> else
> status = connector_status_unknown;
> intel_release_load_detect_pipe(connector, &tmp, &ctx);
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-01 17:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 16:04 [PATCH] drm/i915: Do not return unknown status when load detection is tested Maarten Lankhorst
2016-03-01 16:32 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-03-01 17:27 ` Ville Syrjälä [this message]
2016-03-01 17:46 ` [PATCH] " Maarten Lankhorst
2016-03-01 18:01 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301172721.GM15993@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox