From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Do not return unknown status when load detection is tested.
Date: Tue, 1 Mar 2016 20:01:23 +0200 [thread overview]
Message-ID: <20160301180123.GO15993@intel.com> (raw)
In-Reply-To: <56D5D58B.4070207@linux.intel.com>
On Tue, Mar 01, 2016 at 06:46:51PM +0100, Maarten Lankhorst wrote:
> Op 01-03-16 om 18:27 schreef Ville Syrjälä:
> > On Tue, Mar 01, 2016 at 05:04:01PM +0100, Maarten Lankhorst wrote:
> >> This fixes the IGT test, which interprets unknown status as failed to
> >> acquire load detect pipe.
> > Change the expectation of the test?
> >
> > But more importantly, how can it fail to find a pipe when there's
> > kmstest_unset_all_crtcs() in the test?
> >
> It finds a pipe, but because status is connector_status_unknown without this patch it still treats it as failed.
Ah, seems I misunderstand everything today. Yeah that makes sense. We
need to distinguish between the failed to get a pipe vs. failed to
detect anything even when we found a pipe.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-03-01 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 16:04 [PATCH] drm/i915: Do not return unknown status when load detection is tested Maarten Lankhorst
2016-03-01 16:32 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-03-01 17:27 ` [PATCH] " Ville Syrjälä
2016-03-01 17:46 ` Maarten Lankhorst
2016-03-01 18:01 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301180123.GO15993@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox