* [PATCH] drm/i915: Do not return unknown status when load detection is tested.
@ 2016-03-01 16:04 Maarten Lankhorst
2016-03-01 16:32 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-03-01 17:27 ` [PATCH] " Ville Syrjälä
0 siblings, 2 replies; 5+ messages in thread
From: Maarten Lankhorst @ 2016-03-01 16:04 UTC (permalink / raw)
To: intel-gfx
This fixes the IGT test, which interprets unknown status as failed to
acquire load detect pipe.
Cc: Gabriel Feceoru <gabriel.feceoru@intel.com>
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
drivers/gpu/drm/i915/intel_crt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
index 505fc5cf26f8..4b2dfa1bb00e 100644
--- a/drivers/gpu/drm/i915/intel_crt.c
+++ b/drivers/gpu/drm/i915/intel_crt.c
@@ -652,6 +652,8 @@ intel_crt_detect(struct drm_connector *connector, bool force)
else if (INTEL_INFO(dev)->gen < 4)
status = intel_crt_load_detect(crt,
to_intel_crtc(connector->state->crtc)->pipe);
+ else if (i915.load_detect_test)
+ status = connector_status_disconnected;
else
status = connector_status_unknown;
intel_release_load_detect_pipe(connector, &tmp, &ctx);
--
2.1.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Do not return unknown status when load detection is tested.
2016-03-01 16:04 [PATCH] drm/i915: Do not return unknown status when load detection is tested Maarten Lankhorst
@ 2016-03-01 16:32 ` Patchwork
2016-03-01 17:27 ` [PATCH] " Ville Syrjälä
1 sibling, 0 replies; 5+ messages in thread
From: Patchwork @ 2016-03-01 16:32 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Do not return unknown status when load detection is tested.
URL : https://patchwork.freedesktop.org/series/3978/
State : failure
== Summary ==
Series 3978v1 drm/i915: Do not return unknown status when load detection is tested.
http://patchwork.freedesktop.org/api/1.0/series/3978/revisions/1/mbox/
Test kms_flip:
Subgroup basic-flip-vs-dpms:
pass -> DMESG-WARN (ilk-hp8440p) UNSTABLE
Subgroup basic-flip-vs-wf_vblank:
dmesg-warn -> PASS (hsw-gt2)
pass -> DMESG-WARN (hsw-brixbox)
Test kms_force_connector_basic:
Subgroup force-load-detect:
fail -> PASS (hsw-gt2)
fail -> PASS (snb-dellxps)
fail -> PASS (ilk-hp8440p)
skip -> PASS (ivb-t430s)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-c:
pass -> DMESG-WARN (bsw-nuc-2)
Test pm_rpm:
Subgroup basic-pci-d3-state:
pass -> DMESG-WARN (bsw-nuc-2)
bdw-nuci7 total:169 pass:158 dwarn:0 dfail:0 fail:0 skip:11
bdw-ultra total:169 pass:155 dwarn:0 dfail:0 fail:0 skip:14
bsw-nuc-2 total:169 pass:136 dwarn:2 dfail:0 fail:1 skip:30
byt-nuc total:169 pass:144 dwarn:0 dfail:0 fail:0 skip:25
hsw-brixbox total:169 pass:153 dwarn:1 dfail:0 fail:0 skip:15
hsw-gt2 total:169 pass:159 dwarn:0 dfail:0 fail:0 skip:10
ilk-hp8440p total:169 pass:117 dwarn:1 dfail:0 fail:1 skip:50
ivb-t430s total:169 pass:154 dwarn:0 dfail:0 fail:0 skip:15
skl-i5k-2 total:169 pass:153 dwarn:0 dfail:0 fail:0 skip:16
skl-i7k-2 total:169 pass:153 dwarn:0 dfail:0 fail:0 skip:16
snb-dellxps total:169 pass:144 dwarn:2 dfail:0 fail:0 skip:23
Results at /archive/results/CI_IGT_test/Patchwork_1505/
bb25273010c1ea81428ad36a53058ef286653283 drm-intel-nightly: 2016y-03m-01d-15h-09m-38s UTC integration manifest
54419dbfc2c03e8b5150ac1b76a5c20f540b9dfc drm/i915: Do not return unknown status when load detection is tested.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Do not return unknown status when load detection is tested.
2016-03-01 16:04 [PATCH] drm/i915: Do not return unknown status when load detection is tested Maarten Lankhorst
2016-03-01 16:32 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2016-03-01 17:27 ` Ville Syrjälä
2016-03-01 17:46 ` Maarten Lankhorst
1 sibling, 1 reply; 5+ messages in thread
From: Ville Syrjälä @ 2016-03-01 17:27 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
On Tue, Mar 01, 2016 at 05:04:01PM +0100, Maarten Lankhorst wrote:
> This fixes the IGT test, which interprets unknown status as failed to
> acquire load detect pipe.
Change the expectation of the test?
But more importantly, how can it fail to find a pipe when there's
kmstest_unset_all_crtcs() in the test?
>
> Cc: Gabriel Feceoru <gabriel.feceoru@intel.com>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_crt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
> index 505fc5cf26f8..4b2dfa1bb00e 100644
> --- a/drivers/gpu/drm/i915/intel_crt.c
> +++ b/drivers/gpu/drm/i915/intel_crt.c
> @@ -652,6 +652,8 @@ intel_crt_detect(struct drm_connector *connector, bool force)
> else if (INTEL_INFO(dev)->gen < 4)
> status = intel_crt_load_detect(crt,
> to_intel_crtc(connector->state->crtc)->pipe);
> + else if (i915.load_detect_test)
> + status = connector_status_disconnected;
> else
> status = connector_status_unknown;
> intel_release_load_detect_pipe(connector, &tmp, &ctx);
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Do not return unknown status when load detection is tested.
2016-03-01 17:27 ` [PATCH] " Ville Syrjälä
@ 2016-03-01 17:46 ` Maarten Lankhorst
2016-03-01 18:01 ` Ville Syrjälä
0 siblings, 1 reply; 5+ messages in thread
From: Maarten Lankhorst @ 2016-03-01 17:46 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
Op 01-03-16 om 18:27 schreef Ville Syrjälä:
> On Tue, Mar 01, 2016 at 05:04:01PM +0100, Maarten Lankhorst wrote:
>> This fixes the IGT test, which interprets unknown status as failed to
>> acquire load detect pipe.
> Change the expectation of the test?
>
> But more importantly, how can it fail to find a pipe when there's
> kmstest_unset_all_crtcs() in the test?
>
It finds a pipe, but because status is connector_status_unknown without this patch it still treats it as failed.
~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Do not return unknown status when load detection is tested.
2016-03-01 17:46 ` Maarten Lankhorst
@ 2016-03-01 18:01 ` Ville Syrjälä
0 siblings, 0 replies; 5+ messages in thread
From: Ville Syrjälä @ 2016-03-01 18:01 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
On Tue, Mar 01, 2016 at 06:46:51PM +0100, Maarten Lankhorst wrote:
> Op 01-03-16 om 18:27 schreef Ville Syrjälä:
> > On Tue, Mar 01, 2016 at 05:04:01PM +0100, Maarten Lankhorst wrote:
> >> This fixes the IGT test, which interprets unknown status as failed to
> >> acquire load detect pipe.
> > Change the expectation of the test?
> >
> > But more importantly, how can it fail to find a pipe when there's
> > kmstest_unset_all_crtcs() in the test?
> >
> It finds a pipe, but because status is connector_status_unknown without this patch it still treats it as failed.
Ah, seems I misunderstand everything today. Yeah that makes sense. We
need to distinguish between the failed to get a pipe vs. failed to
detect anything even when we found a pipe.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-01 18:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-01 16:04 [PATCH] drm/i915: Do not return unknown status when load detection is tested Maarten Lankhorst
2016-03-01 16:32 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-03-01 17:27 ` [PATCH] " Ville Syrjälä
2016-03-01 17:46 ` Maarten Lankhorst
2016-03-01 18:01 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox