From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH RESEND 5/7] drm/i915/panel: setup pwm backlight based on connector type
Date: Wed, 16 Mar 2016 16:48:13 +0100 [thread overview]
Message-ID: <20160316154813.GY14170@phenom.ffwll.local> (raw)
In-Reply-To: <1458125015-7931-5-git-send-email-jani.nikula@intel.com>
On Wed, Mar 16, 2016 at 12:43:33PM +0200, Jani Nikula wrote:
> Use the connector type instead of VBT directly to decide which backlight
> mechanism to use on VLV/CHV. (Indirectly, this is the same thing, but
> hides the VBT use.)
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/intel_panel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c
> index 0fe059bc7d80..8c8996fcbaf5 100644
> --- a/drivers/gpu/drm/i915/intel_panel.c
> +++ b/drivers/gpu/drm/i915/intel_panel.c
> @@ -1743,7 +1743,7 @@ intel_panel_init_backlight_funcs(struct intel_panel *panel)
> panel->backlight.get = pch_get_backlight;
> panel->backlight.hz_to_pwm = pch_hz_to_pwm;
> } else if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) {
> - if (dev_priv->vbt.has_mipi) {
> + if (connector->base.connector_type == DRM_MODE_CONNECTOR_DSI) {
> panel->backlight.setup = pwm_setup_backlight;
> panel->backlight.enable = pwm_enable_backlight;
> panel->backlight.disable = pwm_disable_backlight;
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-03-16 15:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 10:43 [PATCH RESEND 1/7] drm/i915: move VBT based TV presence check to intel_bios.c Jani Nikula
2016-03-16 10:43 ` [PATCH RESEND 2/7] drm/i915: move VBT based LVDS " Jani Nikula
2016-03-16 10:43 ` [PATCH RESEND 3/7] drm/i915: move VBT based eDP port " Jani Nikula
2016-03-16 15:43 ` Daniel Vetter
2016-03-16 10:43 ` [PATCH RESEND 4/7] drm/i915: move VBT based DSI presence " Jani Nikula
2016-03-16 15:47 ` Daniel Vetter
2016-03-16 10:43 ` [PATCH RESEND 5/7] drm/i915/panel: setup pwm backlight based on connector type Jani Nikula
2016-03-16 15:48 ` Daniel Vetter [this message]
2016-03-16 10:43 ` [PATCH RESEND 6/7] drm/i915/bios: drop has_mipi in favor of intel_bios_is_dsi_present Jani Nikula
2016-03-16 15:50 ` Daniel Vetter
2016-03-16 16:32 ` Jani Nikula
2016-03-16 10:43 ` [PATCH RESEND 7/7] drm/i915: hide away VBT private data in a separate header Jani Nikula
2016-03-16 15:51 ` Daniel Vetter
2016-03-17 10:04 ` Jani Nikula
2016-03-16 13:09 ` ✗ Fi.CI.BAT: failure for series starting with [RESEND,1/7] drm/i915: move VBT based TV presence check to intel_bios.c Patchwork
2016-03-16 15:42 ` [PATCH RESEND 1/7] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316154813.GY14170@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox