Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH RESEND 6/7] drm/i915/bios: drop has_mipi in favor of intel_bios_is_dsi_present
Date: Wed, 16 Mar 2016 16:50:54 +0100	[thread overview]
Message-ID: <20160316155054.GZ14170@phenom.ffwll.local> (raw)
In-Reply-To: <1458125015-7931-6-git-send-email-jani.nikula@intel.com>

On Wed, Mar 16, 2016 at 12:43:34PM +0200, Jani Nikula wrote:
> Favor a single point of truth instead of duplicating the information.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.h   |  1 -
>  drivers/gpu/drm/i915/intel_bios.c | 12 +++---------
>  2 files changed, 3 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 9c7402c062b9..cff4b6ec79d8 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1415,7 +1415,6 @@ struct intel_vbt_data {
>  	unsigned int lvds_use_ssc:1;
>  	unsigned int display_clock_mode:1;
>  	unsigned int fdi_rx_polarity_inverted:1;
> -	unsigned int has_mipi:1;
>  	int lvds_ssc_freq;
>  	unsigned int bios_lvds_val; /* initial [PCH_]LVDS reg val in VBIOS */
>  
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 4b6bd6f2e193..aa90dc662e7f 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -706,7 +706,7 @@ parse_mipi_config(struct drm_i915_private *dev_priv,
>  	const struct mipi_pps_data *pps;
>  
>  	/* parse MIPI blocks only if LFP type is MIPI */
> -	if (!dev_priv->vbt.has_mipi)
> +	if (!intel_bios_is_dsi_present(dev_priv, NULL))
>  		return;
>  
>  	/* Initialize this to undefined indicating no generic MIPI support */
> @@ -1232,13 +1232,6 @@ parse_device_mapping(struct drm_i915_private *dev_priv,
>  			continue;
>  		}
>  
> -		if (p_child->common.dvo_port >= DVO_PORT_MIPIA
> -		    && p_child->common.dvo_port <= DVO_PORT_MIPID
> -		    &&p_child->common.device_type & DEVICE_TYPE_MIPI_OUTPUT) {

New code also rejects DVO_PORT_MIPIC, you should mention that robustness
fix in the commit message. With this added:

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> -			DRM_DEBUG_KMS("Found MIPI as LFP\n");
> -			dev_priv->vbt.has_mipi = 1;
> -		}
> -
>  		child_dev_ptr = dev_priv->vbt.child_dev + count;
>  		count++;
>  
> @@ -1580,7 +1573,8 @@ bool intel_bios_is_dsi_present(struct drm_i915_private *dev_priv,
>  		switch (dvo_port) {
>  		case DVO_PORT_MIPIA:
>  		case DVO_PORT_MIPIC:
> -			*port = dvo_port - DVO_PORT_MIPIA;
> +			if (port)
> +				*port = dvo_port - DVO_PORT_MIPIA;
>  			return true;
>  		case DVO_PORT_MIPIB:
>  		case DVO_PORT_MIPID:
> -- 
> 2.1.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-03-16 15:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 10:43 [PATCH RESEND 1/7] drm/i915: move VBT based TV presence check to intel_bios.c Jani Nikula
2016-03-16 10:43 ` [PATCH RESEND 2/7] drm/i915: move VBT based LVDS " Jani Nikula
2016-03-16 10:43 ` [PATCH RESEND 3/7] drm/i915: move VBT based eDP port " Jani Nikula
2016-03-16 15:43   ` Daniel Vetter
2016-03-16 10:43 ` [PATCH RESEND 4/7] drm/i915: move VBT based DSI presence " Jani Nikula
2016-03-16 15:47   ` Daniel Vetter
2016-03-16 10:43 ` [PATCH RESEND 5/7] drm/i915/panel: setup pwm backlight based on connector type Jani Nikula
2016-03-16 15:48   ` Daniel Vetter
2016-03-16 10:43 ` [PATCH RESEND 6/7] drm/i915/bios: drop has_mipi in favor of intel_bios_is_dsi_present Jani Nikula
2016-03-16 15:50   ` Daniel Vetter [this message]
2016-03-16 16:32     ` Jani Nikula
2016-03-16 10:43 ` [PATCH RESEND 7/7] drm/i915: hide away VBT private data in a separate header Jani Nikula
2016-03-16 15:51   ` Daniel Vetter
2016-03-17 10:04     ` Jani Nikula
2016-03-16 13:09 ` ✗ Fi.CI.BAT: failure for series starting with [RESEND,1/7] drm/i915: move VBT based TV presence check to intel_bios.c Patchwork
2016-03-16 15:42 ` [PATCH RESEND 1/7] " Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160316155054.GZ14170@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox