* [PATCH] drm/i915/lpe: Remove double-encapsulation of info string
@ 2017-12-13 18:28 Chris Wilson
2017-12-13 18:49 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2017-12-13 18:28 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Takashi Iwai
Just printk the string, or at least do not double up on the newlines!
Fixes: eef57324d926 ("drm/i915: setup bridge for HDMI LPE audio driver")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Jerome Anand <jerome.anand@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Takashi Iwai <tiwai@suse.de>
---
drivers/gpu/drm/i915/intel_lpe_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_lpe_audio.c b/drivers/gpu/drm/i915/intel_lpe_audio.c
index 3bf65288ffff..5809b29044fc 100644
--- a/drivers/gpu/drm/i915/intel_lpe_audio.c
+++ b/drivers/gpu/drm/i915/intel_lpe_audio.c
@@ -193,7 +193,7 @@ static bool lpe_audio_detect(struct drm_i915_private *dev_priv)
};
if (!pci_dev_present(atom_hdaudio_ids)) {
- DRM_INFO("%s\n", "HDaudio controller not detected, using LPE audio instead\n");
+ DRM_INFO("HDaudio controller not detected, using LPE audio instead\n");
lpe_present = true;
}
}
--
2.15.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/lpe: Remove double-encapsulation of info string
2017-12-13 18:28 [PATCH] drm/i915/lpe: Remove double-encapsulation of info string Chris Wilson
@ 2017-12-13 18:49 ` Patchwork
2017-12-13 20:15 ` ✓ Fi.CI.IGT: " Patchwork
2017-12-14 22:03 ` [PATCH] " Pandiyan, Dhinakaran
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-12-13 18:49 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/lpe: Remove double-encapsulation of info string
URL : https://patchwork.freedesktop.org/series/35303/
State : success
== Summary ==
Series 35303v1 drm/i915/lpe: Remove double-encapsulation of info string
https://patchwork.freedesktop.org/api/1.0/series/35303/revisions/1/mbox/
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:437s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:444s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:383s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:512s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:278s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:504s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:507s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:482s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:471s
fi-elk-e7500 total:224 pass:163 dwarn:15 dfail:0 fail:0 skip:45
fi-gdg-551 total:288 pass:178 dwarn:1 dfail:0 fail:1 skip:108 time:263s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:541s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:406s
fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:418s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:390s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:479s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:431s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:479s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:528s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:465s
fi-kbl-r total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:530s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:586s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:450s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:539s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:563s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:497s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:447s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:553s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:417s
Blacklisted hosts:
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:602s
fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:490s
1a717c76c96c2883866e4041926285b0f576fb54 drm-tip: 2017y-12m-13d-14h-48m-36s UTC integration manifest
582ab4461ae7 drm/i915/lpe: Remove double-encapsulation of info string
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7489/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915/lpe: Remove double-encapsulation of info string
2017-12-13 18:28 [PATCH] drm/i915/lpe: Remove double-encapsulation of info string Chris Wilson
2017-12-13 18:49 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-12-13 20:15 ` Patchwork
2017-12-14 22:03 ` [PATCH] " Pandiyan, Dhinakaran
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-12-13 20:15 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/lpe: Remove double-encapsulation of info string
URL : https://patchwork.freedesktop.org/series/35303/
State : success
== Summary ==
Test gem_eio:
Subgroup in-flight:
pass -> DMESG-WARN (shard-snb) fdo#104058
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-blt:
fail -> PASS (shard-snb) fdo#101623
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> SKIP (shard-hsw) fdo#103375
fdo#104058 https://bugs.freedesktop.org/show_bug.cgi?id=104058
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
shard-hsw total:2712 pass:1537 dwarn:1 dfail:0 fail:9 skip:1165 time:9485s
shard-snb total:2712 pass:1308 dwarn:2 dfail:0 fail:11 skip:1391 time:8018s
Blacklisted hosts:
shard-apl total:2712 pass:1689 dwarn:1 dfail:0 fail:21 skip:1001 time:14008s
shard-kbl total:2712 pass:1807 dwarn:1 dfail:0 fail:24 skip:880 time:11105s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7489/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/lpe: Remove double-encapsulation of info string
2017-12-13 18:28 [PATCH] drm/i915/lpe: Remove double-encapsulation of info string Chris Wilson
2017-12-13 18:49 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-13 20:15 ` ✓ Fi.CI.IGT: " Patchwork
@ 2017-12-14 22:03 ` Pandiyan, Dhinakaran
2017-12-15 14:03 ` Chris Wilson
2 siblings, 1 reply; 5+ messages in thread
From: Pandiyan, Dhinakaran @ 2017-12-14 22:03 UTC (permalink / raw)
To: chris@chris-wilson.co.uk
Cc: Nikula, Jani, tiwai@suse.de, intel-gfx@lists.freedesktop.org
On Wed, 2017-12-13 at 18:28 +0000, Chris Wilson wrote:
> Just printk the string, or at least do not double up on the newlines!
>
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Fixes: eef57324d926 ("drm/i915: setup bridge for HDMI LPE audio driver")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Cc: Jerome Anand <jerome.anand@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> ---
> drivers/gpu/drm/i915/intel_lpe_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lpe_audio.c b/drivers/gpu/drm/i915/intel_lpe_audio.c
> index 3bf65288ffff..5809b29044fc 100644
> --- a/drivers/gpu/drm/i915/intel_lpe_audio.c
> +++ b/drivers/gpu/drm/i915/intel_lpe_audio.c
> @@ -193,7 +193,7 @@ static bool lpe_audio_detect(struct drm_i915_private *dev_priv)
> };
>
> if (!pci_dev_present(atom_hdaudio_ids)) {
> - DRM_INFO("%s\n", "HDaudio controller not detected, using LPE audio instead\n");
> + DRM_INFO("HDaudio controller not detected, using LPE audio instead\n");
> lpe_present = true;
> }
> }
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915/lpe: Remove double-encapsulation of info string
2017-12-14 22:03 ` [PATCH] " Pandiyan, Dhinakaran
@ 2017-12-15 14:03 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2017-12-15 14:03 UTC (permalink / raw)
To: Pandiyan, Dhinakaran
Cc: Nikula, Jani, tiwai@suse.de, intel-gfx@lists.freedesktop.org
Quoting Pandiyan, Dhinakaran (2017-12-14 22:03:49)
> On Wed, 2017-12-13 at 18:28 +0000, Chris Wilson wrote:
> > Just printk the string, or at least do not double up on the newlines!
> >
>
> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
And pushed, thanks for the review.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-15 14:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-13 18:28 [PATCH] drm/i915/lpe: Remove double-encapsulation of info string Chris Wilson
2017-12-13 18:49 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-13 20:15 ` ✓ Fi.CI.IGT: " Patchwork
2017-12-14 22:03 ` [PATCH] " Pandiyan, Dhinakaran
2017-12-15 14:03 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox