From: Patchwork <patchwork@emeril.freedesktop.org>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Implement HDCP2.2
Date: Wed, 14 Feb 2018 15:07:32 -0000 [thread overview]
Message-ID: <20180214150732.21135.95923@emeril.freedesktop.org> (raw)
In-Reply-To: <1518617638-21684-1-git-send-email-ramalingam.c@intel.com>
== Series Details ==
Series: drm/i915: Implement HDCP2.2
URL : https://patchwork.freedesktop.org/series/38254/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f736f4ccc6d7 drm: hdcp2.2 authentication msg definitions
-:27: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#27: FILE: include/drm/drm_hdcp.h:49:
+ uint8_t reserved_lo;
-:29: CHECK: Prefer kernel type 'u16' over 'uint16_t'
#29: FILE: include/drm/drm_hdcp.h:51:
+ uint16_t srm_version;
-:30: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#30: FILE: include/drm/drm_hdcp.h:52:
+ uint8_t srm_gen_no;
-:93: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#93: FILE: include/drm/drm_hdcp.h:115:
+ uint8_t receiver_id[RECEIVER_ID_SIZE];
-:94: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#94: FILE: include/drm/drm_hdcp.h:116:
+ uint8_t kpub_rx[K_PUB_RX_SIZE];
-:101: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#101: FILE: include/drm/drm_hdcp.h:123:
+ uint8_t reserved2;
-:102: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#102: FILE: include/drm/drm_hdcp.h:124:
+ uint8_t dcp_signature[DCP_LLC_SIGNATURE_SIZE];
-:111: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#111: FILE: include/drm/drm_hdcp.h:133:
+ uint8_t version;
-:112: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#112: FILE: include/drm/drm_hdcp.h:134:
+ uint8_t receiver_capability_mask_hi;
-:119: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#119: FILE: include/drm/drm_hdcp.h:141:
+ uint8_t rx_caps_value[3];
-:144: CHECK: Prefer kernel type 'u16' over 'uint16_t'
#144: FILE: include/drm/drm_hdcp.h:166:
+ uint16_t rx_info_value;
-:148: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#148: FILE: include/drm/drm_hdcp.h:170:
+ uint8_t stream_id;
-:149: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#149: FILE: include/drm/drm_hdcp.h:171:
+ uint8_t stream_type;
-:157: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#157: FILE: include/drm/drm_hdcp.h:179:
+ uint8_t version;
-:160: CHECK: Prefer kernel type 'u16' over 'uint16_t'
#160: FILE: include/drm/drm_hdcp.h:182:
+ uint16_t transmitter_capability_mask;
-:167: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#167: FILE: include/drm/drm_hdcp.h:189:
+ uint8_t msg_id;
-:168: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#168: FILE: include/drm/drm_hdcp.h:190:
+ uint8_t r_tx[HDCP_RTX_LEN];
-:173: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#173: FILE: include/drm/drm_hdcp.h:195:
+ uint8_t msg_id;
-:175: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#175: FILE: include/drm/drm_hdcp.h:197:
+ uint8_t r_rx[HDCP_RRX_LEN];
-:180: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#180: FILE: include/drm/drm_hdcp.h:202:
+ uint8_t msg_id;
-:181: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#181: FILE: include/drm/drm_hdcp.h:203:
+ uint8_t e_kpub_km[HDCP_E_KPUB_KM_LEN];
-:185: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#185: FILE: include/drm/drm_hdcp.h:207:
+ uint8_t msg_id;
-:186: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#186: FILE: include/drm/drm_hdcp.h:208:
+ uint8_t e_kh_km_m[HDCP_E_KH_KM_M_LEN];
-:190: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#190: FILE: include/drm/drm_hdcp.h:212:
+ uint8_t msg_id;
-:191: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#191: FILE: include/drm/drm_hdcp.h:213:
+ uint8_t h_prime[HDCP_H_PRIME_LEN];
-:195: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#195: FILE: include/drm/drm_hdcp.h:217:
+ uint8_t msg_id;
-:196: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#196: FILE: include/drm/drm_hdcp.h:218:
+ uint8_t e_kh_km[HDCP_E_KH_KM_LEN];
-:200: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#200: FILE: include/drm/drm_hdcp.h:222:
+ uint8_t msg_id;
-:201: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#201: FILE: include/drm/drm_hdcp.h:223:
+ uint8_t r_n[HDCP_RN_LEN];
-:205: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#205: FILE: include/drm/drm_hdcp.h:227:
+ uint8_t msg_id;
-:206: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#206: FILE: include/drm/drm_hdcp.h:228:
+ uint8_t l_prime[HDCP_L_PRIME_LEN];
-:210: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#210: FILE: include/drm/drm_hdcp.h:232:
+ uint8_t msg_id;
-:211: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#211: FILE: include/drm/drm_hdcp.h:233:
+ uint8_t e_dkey_ks[HDCP_E_DKEY_KS_LEN];
-:212: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#212: FILE: include/drm/drm_hdcp.h:234:
+ uint8_t riv[HDCP_RIV_LEN];
-:216: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#216: FILE: include/drm/drm_hdcp.h:238:
+ uint8_t msg_id;
-:218: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#218: FILE: include/drm/drm_hdcp.h:240:
+ uint8_t seq_num_v[HDCP_SEQ_NUM_LEN];
-:219: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#219: FILE: include/drm/drm_hdcp.h:241:
+ uint8_t v_prime[HDCP_LPRIME_HALF_SIZE];
-:220: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#220: FILE: include/drm/drm_hdcp.h:242:
+ uint8_t receiver_ids[HDCP_RECEIVER_IDS_MAX_LEN];
-:224: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#224: FILE: include/drm/drm_hdcp.h:246:
+ uint8_t msg_id;
-:225: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#225: FILE: include/drm/drm_hdcp.h:247:
+ uint8_t v[HDCP_LPRIME_HALF_SIZE];
-:229: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#229: FILE: include/drm/drm_hdcp.h:251:
+ uint8_t msg_id;
-:230: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#230: FILE: include/drm/drm_hdcp.h:252:
+ uint8_t seq_num_m[HDCP_SEQ_NUM_LEN];
-:231: CHECK: Prefer kernel type 'u16' over 'uint16_t'
#231: FILE: include/drm/drm_hdcp.h:253:
+ uint16_t k;
-:236: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#236: FILE: include/drm/drm_hdcp.h:258:
+ uint8_t msg_id;
-:237: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#237: FILE: include/drm/drm_hdcp.h:259:
+ uint8_t m_prime[HDCP_MPRIME_LEN];
-:241: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#241: FILE: include/drm/drm_hdcp.h:263:
+ uint8_t msg_id;
-:242: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#242: FILE: include/drm/drm_hdcp.h:264:
+ uint8_t stream_type;
total: 0 errors, 0 warnings, 47 checks, 230 lines checked
3b68aa846b62 drm: HDMI and DP specific HDCP2.2 defines
-:76: CHECK: Avoid CamelCase: <Link_integrity_failure>
#76: FILE: include/drm/drm_dp_helper.h:913:
+ uint8_t Link_integrity_failure:1;
-:79: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#79: FILE: include/drm/drm_dp_helper.h:916:
+ uint8_t val;
-:110: CHECK: spaces preferred around that '<<' (ctx:VxV)
#110: FILE: include/drm/drm_hdcp.h:284:
+#define HDMI_HDCP_2_2_SUPPORT_MASK (1<<2)
^
-:110: CHECK: Prefer using the BIT macro
#110: FILE: include/drm/drm_hdcp.h:284:
+#define HDMI_HDCP_2_2_SUPPORT_MASK (1<<2)
-:125: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#125: FILE: include/drm/drm_hdcp.h:299:
+ uint8_t msg_sz_lo;
-:127: CHECK: Prefer kernel type 'u16' over 'uint16_t'
#127: FILE: include/drm/drm_hdcp.h:301:
+ uint16_t val;
total: 0 errors, 0 warnings, 6 checks, 106 lines checked
a5578ed4a012 mei: bus: whitelist hdcp client
d357ae57a883 mei: me: add gemini lake devices ids
720b23af0b72 misc/mei/hdcp: Client driver for HDCP application
-:32: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 112 lines checked
40a7bcdc33f5 misc/mei/hdcp: Add KBuild for mei hdcp driver
53619c62c9a4 misc/mei/hdcp: Verify mei client device status
83915af0e87e misc/mei/hdcp: Get & Put for mei cl_device
-:110: CHECK: Alignment should match open parenthesis
#110: FILE: drivers/misc/mei/mei_hdcp.h:36:
+ void (*notify_on_cldev_change)(void *client,
+ struct mei_cl_device *cldev);
-:117: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#117:
new file mode 100644
-:164: CHECK: Please use a blank line after function/struct/union/enum declarations
#164: FILE: include/linux/mei_hdcp.h:43:
+}
+static inline
total: 0 errors, 1 warnings, 2 checks, 134 lines checked
ef20982b92c8 misc/mei/hdcp: Define ME FW interface for HDCP2.2
-:158: CHECK: Please don't use multiple blank lines
#158: FILE: drivers/misc/mei/mei_hdcp.h:170:
+
+
-:186: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#186: FILE: drivers/misc/mei/mei_hdcp.h:198:
+ uint8_t e_kpub_km[HDCP_E_KPUB_KM_LEN];
-:187: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#187: FILE: drivers/misc/mei/mei_hdcp.h:199:
+ uint8_t e_kh_km_m[HDCP_E_KH_KM_M_LEN];
-:189: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#189: FILE: drivers/misc/mei/mei_hdcp.h:201:
+ uint8_t e_kh_km[HDCP_KH_LEN];
-:190: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#190: FILE: drivers/misc/mei/mei_hdcp.h:202:
+ uint8_t m[HDCP_M_LEN];
-:199: CHECK: Prefer kernel type 'u32' over 'uint32_t'
#199: FILE: drivers/misc/mei/mei_hdcp.h:211:
+ uint32_t api_version;
-:200: CHECK: Prefer kernel type 'u32' over 'uint32_t'
#200: FILE: drivers/misc/mei/mei_hdcp.h:212:
+ uint32_t command_id;
-:203: CHECK: Prefer kernel type 'u32' over 'uint32_t'
#203: FILE: drivers/misc/mei/mei_hdcp.h:215:
+ uint32_t buffer_len;
-:216: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#216: FILE: drivers/misc/mei/mei_hdcp.h:228:
+ uint8_t integrated_port_type;
-:217: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#217: FILE: drivers/misc/mei/mei_hdcp.h:229:
+ uint8_t physical_port;
-:218: CHECK: Prefer kernel type 'u16' over 'uint16_t'
#218: FILE: drivers/misc/mei/mei_hdcp.h:230:
+ uint16_t reserved;
-:221: CHECK: Please don't use multiple blank lines
#221: FILE: drivers/misc/mei/mei_hdcp.h:233:
+
+
-:250: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#250: FILE: drivers/misc/mei/mei_hdcp.h:262:
+ uint8_t protocol; /* for HDMI vs DP */
-:256: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#256: FILE: drivers/misc/mei/mei_hdcp.h:268:
+ uint8_t r_tx[HDCP_RTX_LEN];
-:303: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#303: FILE: drivers/misc/mei/mei_hdcp.h:315:
+ uint8_t r_rx[HDCP_RRX_LEN];
-:310: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#310: FILE: drivers/misc/mei/mei_hdcp.h:322:
+ uint8_t km_stored;
-:311: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#311: FILE: drivers/misc/mei/mei_hdcp.h:323:
+ uint8_t reserved[3];
-:334: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#334: FILE: drivers/misc/mei/mei_hdcp.h:346:
+ uint8_t h_prime[HDCP_H_PRIME_LEN];
-:362: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#362: FILE: drivers/misc/mei/mei_hdcp.h:374:
+ uint8_t e_kh_km[HDCP_E_KH_KM_LEN];
-:370: CHECK: Please don't use multiple blank lines
#370: FILE: drivers/misc/mei/mei_hdcp.h:382:
+
+
-:399: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#399: FILE: drivers/misc/mei/mei_hdcp.h:411:
+ uint8_t r_n[HDCP_RN_LEN];
-:421: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#421: FILE: drivers/misc/mei/mei_hdcp.h:433:
+ uint8_t l_prime[HDCP_L_PRIME_LEN];
-:456: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#456: FILE: drivers/misc/mei/mei_hdcp.h:468:
+ uint8_t e_dkey_ks[HDCP_E_DKEY_KS_LEN];
-:457: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#457: FILE: drivers/misc/mei/mei_hdcp.h:469:
+ uint8_t r_iv[HDCP_RIV_LEN];
-:477: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#477: FILE: drivers/misc/mei/mei_hdcp.h:489:
+ uint8_t stream_type;
-:511: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#511: FILE: drivers/misc/mei/mei_hdcp.h:523:
+ uint8_t seq_num_v[HDCP_SEQ_NUM_LEN];
-:512: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#512: FILE: drivers/misc/mei/mei_hdcp.h:524:
+ uint8_t v_prime[HDCP_LPRIME_HALF_SIZE];
-:513: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#513: FILE: drivers/misc/mei/mei_hdcp.h:525:
+ uint8_t receiver_ids[HDCP_RECEIVER_IDS_MAX_LEN];
-:519: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#519: FILE: drivers/misc/mei/mei_hdcp.h:531:
+ uint8_t content_type_supported;
-:520: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#520: FILE: drivers/misc/mei/mei_hdcp.h:532:
+ uint8_t v[HDCP_LPRIME_HALF_SIZE];
-:543: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#543: FILE: drivers/misc/mei/mei_hdcp.h:555:
+ uint8_t seq_num_m[HDCP_SEQ_NUM_LEN];
-:544: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#544: FILE: drivers/misc/mei/mei_hdcp.h:556:
+ uint8_t m_prime[HDCP_MPRIME_LEN];
-:545: CHECK: Prefer kernel type 'u16' over 'uint16_t'
#545: FILE: drivers/misc/mei/mei_hdcp.h:557:
+ uint16_t k;
total: 0 errors, 0 warnings, 33 checks, 535 lines checked
721f27c37de4 linux/mei: Header for mei_hdcp driver interface
-:76: CHECK: Prefer kernel type 'u16' over 'uint16_t'
#76: FILE: include/linux/mei_hdcp.h:83:
+ uint16_t k;
-:84: CHECK: Prefer kernel type 'u32' over 'uint32_t'
#84: FILE: include/linux/mei_hdcp.h:91:
+ uint32_t seq_num_m;
total: 0 errors, 0 warnings, 2 checks, 77 lines checked
e4285cab5df4 misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session
dcf38a21f754 misc/mei/hdcp: Verify Receiver Cert and prepare km
-:138: CHECK: Please use a blank line after function/struct/union/enum declarations
#138: FILE: include/linux/mei_hdcp.h:134:
}
+static inline int
total: 0 errors, 0 warnings, 1 checks, 121 lines checked
baa2ef6c2ae8 misc/mei/hdcp: Verify H_prime
-:106: CHECK: Please use a blank line after function/struct/union/enum declarations
#106: FILE: include/linux/mei_hdcp.h:145:
}
+static inline
total: 0 errors, 0 warnings, 1 checks, 90 lines checked
95ee2b2ff838 misc/mei/hdcp: Store the HDCP Pairing info
-:110: CHECK: Please use a blank line after function/struct/union/enum declarations
#110: FILE: include/linux/mei_hdcp.h:153:
}
+static inline
total: 0 errors, 0 warnings, 1 checks, 91 lines checked
8ec87cbd6a8e misc/mei/hdcp: Initiate Locality check
-:105: CHECK: Please use a blank line after function/struct/union/enum declarations
#105: FILE: include/linux/mei_hdcp.h:161:
}
+static inline
total: 0 errors, 0 warnings, 1 checks, 89 lines checked
5be0d5e5532e misc/mei/hdcp: Verify L_prime
-:108: CHECK: Please use a blank line after function/struct/union/enum declarations
#108: FILE: include/linux/mei_hdcp.h:169:
}
+static inline
total: 0 errors, 0 warnings, 1 checks, 90 lines checked
c8237dc86040 misc/mei/hdcp: Prepare Session Key
-:109: CHECK: Please use a blank line after function/struct/union/enum declarations
#109: FILE: include/linux/mei_hdcp.h:177:
}
+static inline
total: 0 errors, 0 warnings, 1 checks, 93 lines checked
241758068d42 misc/mei/hdcp: Repeater topology verifcation and ack
-:137: CHECK: Please use a blank line after function/struct/union/enum declarations
#137: FILE: include/linux/mei_hdcp.h:188:
}
+static inline int
total: 0 errors, 0 warnings, 1 checks, 120 lines checked
5d658c67aff6 misc/mei/hdcp: Verify M_prime
-:28: CHECK: Comparison to NULL could be written "dest"
#28: FILE: drivers/misc/mei/mei_hdcp.c:633:
+ if (dest != NULL && dst_sz != 0) {
-:78: CHECK: Alignment should match open parenthesis
#78: FILE: drivers/misc/mei/mei_hdcp.c:683:
+ reverse_endianness((u8 *)&verify_mprime_in.seq_num_m, HDCP_SEQ_NUM_LEN,
+ (u8 *)&data->seq_num_m);
-:130: CHECK: Please use a blank line after function/struct/union/enum declarations
#130: FILE: include/linux/mei_hdcp.h:198:
}
+static inline
total: 0 errors, 0 warnings, 3 checks, 111 lines checked
71bdfa1c451c misc/mei/hdcp: Enabling the HDCP authentication
-:108: CHECK: Please use a blank line after function/struct/union/enum declarations
#108: FILE: include/linux/mei_hdcp.h:205:
}
+static inline int mei_enable_hdcp_authentication(struct mei_hdcp_data *data)
total: 0 errors, 0 warnings, 1 checks, 83 lines checked
14071a5ac502 misc/mei/hdcp: Closing wired HDCP2.2 Tx Session
-:59: CHECK: Please don't use multiple blank lines
#59: FILE: drivers/misc/mei/mei_hdcp.c:813:
+
+
-:104: CHECK: Please use a blank line after function/struct/union/enum declarations
#104: FILE: include/linux/mei_hdcp.h:210:
}
+static inline int mei_close_hdcp_session(struct mei_hdcp_data *data)
total: 0 errors, 0 warnings, 2 checks, 85 lines checked
5b37fb6fbbd5 drm/i915: Async execution of hdcp authentication
545ca59b5352 drm/i915: wrapping all hdcp var into intel_hdcp
-:26: CHECK: Lines should not end with a '('
#26: FILE: drivers/gpu/drm/i915/intel_display.c:15318:
+ cancel_delayed_work_sync(
-:43: CHECK: Lines should not end with a '('
#43: FILE: drivers/gpu/drm/i915/intel_dp.c:5449:
+ intel_hdcp_check_link(
-:60: CHECK: struct mutex definition without comment
#60: FILE: drivers/gpu/drm/i915/intel_drv.h:382:
+ struct mutex hdcp_mutex;
-:61: CHECK: Prefer kernel type 'u64' over 'uint64_t'
#61: FILE: drivers/gpu/drm/i915/intel_drv.h:383:
+ uint64_t hdcp_value; /* protected by hdcp_mutex */
-:226: CHECK: Prefer kzalloc(sizeof(*hdcp)...) over kzalloc(sizeof(struct intel_hdcp)...)
#226: FILE: drivers/gpu/drm/i915/intel_hdcp.c:681:
+ hdcp = kzalloc(sizeof(struct intel_hdcp), GFP_KERNEL);
total: 0 errors, 0 warnings, 5 checks, 338 lines checked
50ed77735dca drm/i915: wait for cp_irq
-:56: CHECK: Lines should not end with a '('
#56: FILE: drivers/gpu/drm/i915/intel_dp.c:5066:
+ msecs_to_jiffies(
total: 0 errors, 0 warnings, 1 checks, 62 lines checked
cc0288bf486c drm/i915: Define HDCP2.2 related variables
-:70: CHECK: Blank lines aren't necessary after an open brace '{'
#70: FILE: drivers/gpu/drm/i915/intel_drv.h:329:
+struct intel_hdcp2_shim {
+
-:77: CHECK: Prefer kernel type 'u8' over 'uint8_t'
#77: FILE: drivers/gpu/drm/i915/intel_drv.h:336:
+ uint8_t msg_id, void *buf, size_t size);
-:133: CHECK: Prefer kernel type 'u32' over 'uint32_t'
#133: FILE: drivers/gpu/drm/i915/intel_drv.h:464:
+ uint32_t seq_num_v;
-:141: CHECK: Prefer kernel type 'u32' over 'uint32_t'
#141: FILE: drivers/gpu/drm/i915/intel_drv.h:472:
+ uint32_t seq_num_m;
total: 0 errors, 0 warnings, 4 checks, 126 lines checked
84cb7e6697af drm/i915: Define Intel HDCP2.2 registers
-:30: CHECK: Macro argument reuse 'p' - possible side-effects?
#30: FILE: drivers/gpu/drm/i915/i915_reg.h:2280:
+#define HDCP_PORT_INDEX_ADJUST(p) (((p) == PORT_A ? PORT_E : \
+ (p) == PORT_E ? (0x6) : \
+ (p)) - 1)
-:36: CHECK: Please don't use multiple blank lines
#36: FILE: drivers/gpu/drm/i915/i915_reg.h:2286:
+
+
-:44: CHECK: Prefer using the BIT macro
#44: FILE: drivers/gpu/drm/i915/i915_reg.h:2294:
+#define AUTH_LINK_AUTHENTICATED (1 << 31)
-:45: CHECK: Prefer using the BIT macro
#45: FILE: drivers/gpu/drm/i915/i915_reg.h:2295:
+#define AUTH_LINK_TYPE (1 << 30)
-:46: CHECK: Prefer using the BIT macro
#46: FILE: drivers/gpu/drm/i915/i915_reg.h:2296:
+#define AUTH_FORCE_CLR_INPUTCTR (1 << 19)
-:47: CHECK: Prefer using the BIT macro
#47: FILE: drivers/gpu/drm/i915/i915_reg.h:2297:
+#define AUTH_CLR_KEYS (1 << 18)
-:53: CHECK: Please don't use multiple blank lines
#53: FILE: drivers/gpu/drm/i915/i915_reg.h:2303:
+
+
-:60: CHECK: Prefer using the BIT macro
#60: FILE: drivers/gpu/drm/i915/i915_reg.h:2310:
+#define AUTH_STREAM_TYPE (1 << 31)
-:73: CHECK: Prefer using the BIT macro
#73: FILE: drivers/gpu/drm/i915/i915_reg.h:2323:
+#define CTL_LINK_ENCRYPTION_REQ (1 << 31)
-:118: CHECK: Prefer using the BIT macro
#118: FILE: drivers/gpu/drm/i915/i915_reg.h:2368:
+#define STREAM_ENCRYPTION_STATUS_A (1 << 31)
-:119: CHECK: Prefer using the BIT macro
#119: FILE: drivers/gpu/drm/i915/i915_reg.h:2369:
+#define STREAM_ENCRYPTION_STATUS_B (1 << 30)
-:120: CHECK: Prefer using the BIT macro
#120: FILE: drivers/gpu/drm/i915/i915_reg.h:2370:
+#define STREAM_ENCRYPTION_STATUS_C (1 << 29)
-:121: CHECK: Prefer using the BIT macro
#121: FILE: drivers/gpu/drm/i915/i915_reg.h:2371:
+#define LINK_TYPE_STATUS (1 << 22)
-:122: CHECK: Prefer using the BIT macro
#122: FILE: drivers/gpu/drm/i915/i915_reg.h:2372:
+#define LINK_AUTH_STATUS (1 << 21)
-:123: CHECK: Prefer using the BIT macro
#123: FILE: drivers/gpu/drm/i915/i915_reg.h:2373:
+#define LINK_ENCRYPTION_STATUS (1 << 20)
-:134: CHECK: Prefer using the BIT macro
#134: FILE: drivers/gpu/drm/i915/i915_reg.h:2384:
+#define STREAM_ENCRYPTION_STATUS (1 << 31)
-:135: CHECK: Prefer using the BIT macro
#135: FILE: drivers/gpu/drm/i915/i915_reg.h:2385:
+#define STREAM_TYPE_STATUS (1 << 30)
total: 0 errors, 0 warnings, 17 checks, 126 lines checked
13fc3345b736 dr
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-14 15:07 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 14:13 [PATCH 00/43] drm/i915: Implement HDCP2.2 Ramalingam C
2018-02-14 14:13 ` [PATCH 01/43] drm: hdcp2.2 authentication msg definitions Ramalingam C
2018-02-14 15:15 ` Winkler, Tomas
2018-02-14 19:40 ` Jani Nikula
2018-02-22 5:24 ` Ramalingam C
2018-02-22 5:29 ` Ramalingam C
2018-02-14 14:13 ` [PATCH 02/43] drm: HDMI and DP specific HDCP2.2 defines Ramalingam C
2018-02-14 14:13 ` [PATCH 03/43] mei: bus: whitelist hdcp client Ramalingam C
2018-02-14 14:13 ` [PATCH 04/43] mei: me: add gemini lake devices ids Ramalingam C
2018-02-14 14:45 ` Winkler, Tomas
2018-02-22 5:22 ` Ramalingam C
2018-02-14 14:13 ` [PATCH 05/43] misc/mei/hdcp: Client driver for HDCP application Ramalingam C
2018-02-14 14:54 ` Winkler, Tomas
2018-02-14 14:57 ` Ramalingam C
2018-02-14 14:13 ` [PATCH 06/43] misc/mei/hdcp: Add KBuild for mei hdcp driver Ramalingam C
2018-02-14 14:54 ` Winkler, Tomas
2018-02-14 14:58 ` Ramalingam C
2018-02-28 15:43 ` Ramalingam C
2018-02-28 16:11 ` Winkler, Tomas
2018-02-14 14:13 ` [PATCH 07/43] misc/mei/hdcp: Verify mei client device status Ramalingam C
2018-02-14 14:13 ` [PATCH 08/43] misc/mei/hdcp: Get & Put for mei cl_device Ramalingam C
2018-02-14 14:13 ` [PATCH 09/43] misc/mei/hdcp: Define ME FW interface for HDCP2.2 Ramalingam C
2018-02-14 14:13 ` [PATCH 10/43] linux/mei: Header for mei_hdcp driver interface Ramalingam C
2018-02-14 14:13 ` [PATCH 11/43] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session Ramalingam C
2018-02-14 14:13 ` [PATCH 12/43] misc/mei/hdcp: Verify Receiver Cert and prepare km Ramalingam C
2018-02-14 14:13 ` [PATCH 13/43] misc/mei/hdcp: Verify H_prime Ramalingam C
2018-02-14 14:13 ` [PATCH 14/43] misc/mei/hdcp: Store the HDCP Pairing info Ramalingam C
2018-02-14 14:13 ` [PATCH 15/43] misc/mei/hdcp: Initiate Locality check Ramalingam C
2018-02-14 14:13 ` [PATCH 16/43] misc/mei/hdcp: Verify L_prime Ramalingam C
2018-02-14 14:13 ` [PATCH 17/43] misc/mei/hdcp: Prepare Session Key Ramalingam C
2018-02-14 14:13 ` [PATCH 18/43] misc/mei/hdcp: Repeater topology verifcation and ack Ramalingam C
2018-02-14 14:13 ` [PATCH 19/43] misc/mei/hdcp: Verify M_prime Ramalingam C
2018-02-14 14:13 ` [PATCH 20/43] misc/mei/hdcp: Enabling the HDCP authentication Ramalingam C
2018-02-14 14:13 ` [PATCH 21/43] misc/mei/hdcp: Closing wired HDCP2.2 Tx Session Ramalingam C
2018-02-14 14:13 ` [PATCH 22/43] drm/i915: Async execution of hdcp authentication Ramalingam C
2018-02-22 14:39 ` Sean Paul
2018-02-26 6:32 ` Ramalingam C
2018-02-14 14:13 ` [PATCH 23/43] drm/i915: wrapping all hdcp var into intel_hdcp Ramalingam C
2018-02-22 14:47 ` Sean Paul
2018-02-26 6:05 ` Ramalingam C
2018-02-14 14:13 ` [PATCH 24/43] drm/i915: wait for cp_irq Ramalingam C
2018-02-22 15:46 ` Sean Paul
2018-02-26 5:49 ` Ramalingam C
2018-02-14 14:13 ` [PATCH 25/43] drm/i915: Define HDCP2.2 related variables Ramalingam C
2018-02-14 14:36 ` Chris Wilson
2018-02-14 14:56 ` Ramalingam C
2018-02-22 14:59 ` Sean Paul
2018-02-26 5:46 ` Ramalingam C
2018-02-14 14:13 ` [PATCH 26/43] drm/i915: Define Intel HDCP2.2 registers Ramalingam C
2018-02-22 15:43 ` Sean Paul
2018-02-26 5:33 ` Ramalingam C
2018-02-14 14:13 ` [PATCH 27/43] drm/i915: Wrappers for mei HDCP2.2 services Ramalingam C
2018-02-14 14:13 ` [PATCH 28/43] drm/i915: Implement HDCP2.2 receiver authentication Ramalingam C
2018-02-14 14:13 ` [PATCH 29/43] drm/i915: Implement HDCP2.2 repeater authentication Ramalingam C
2018-02-14 14:13 ` [PATCH 30/43] drm/i915: Enable and Disable HDCP2.2 port encryption Ramalingam C
2018-02-14 14:38 ` Chris Wilson
2018-02-14 14:52 ` Ramalingam C
2018-02-14 14:13 ` [PATCH 31/43] drm/i915: Implement HDCP2.2 En/Dis-able Ramalingam C
2018-02-14 14:13 ` [PATCH 32/43] drm/i915: Implement HDCP2.2 link integrity check Ramalingam C
2018-02-14 14:13 ` [PATCH 33/43] drm/i915: Handle HDCP2.2 downstream topology change Ramalingam C
2018-02-14 14:13 ` [PATCH 34/43] drm/i915: Pullout the bksv read and validation Ramalingam C
2018-02-14 14:13 ` [PATCH 35/43] drm/i915: Enable HDCP version that is best capable Ramalingam C
2018-02-14 14:42 ` Chris Wilson
2018-02-14 14:51 ` Ramalingam C
2018-02-14 15:00 ` Chris Wilson
2018-02-14 15:00 ` Ramalingam C
2018-02-14 14:13 ` [PATCH 36/43] drm/i915: Enable HDCP1.4 incase of HDCP2.2 failure Ramalingam C
2018-02-14 14:13 ` [PATCH 37/43] drm/i915: Initialize HDCP2.2 and its MEI interface Ramalingam C
2018-02-14 14:45 ` Chris Wilson
2018-02-14 14:45 ` Ramalingam C
2018-02-14 14:13 ` [PATCH 38/43] drm/i915: Implement gmbus burst read Ramalingam C
2018-02-14 14:13 ` [PATCH 39/43] drm/i915: Implement the HDCP2.2 support for DP Ramalingam C
2018-02-14 14:13 ` [PATCH 40/43] drm/i915: Implement the HDCP2.2 support for HDMI Ramalingam C
2018-02-14 14:13 ` [PATCH 41/43] drm/i915: Add HDCP2.2 support for DP connectors Ramalingam C
2018-02-14 14:13 ` [PATCH 42/43] drm/i915: Add HDCP2.2 support for HDMI connectors Ramalingam C
2018-02-14 14:13 ` [PATCH 43/43] drm/i915: Invoke check link on CP_IRQ of DP Ramalingam C
2018-02-14 15:07 ` Patchwork [this message]
2018-02-14 15:13 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Implement HDCP2.2 Patchwork
2018-02-14 15:20 ` ✗ Fi.CI.BAT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-02-09 7:12 [PATCH v12 00/38] " Ramalingam C
2019-02-09 7:36 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-02-15 8:34 [PATCH v14 00/35] " Ramalingam C
2019-02-16 20:46 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-02-16 17:36 [PATCH v14 00/33] " Ramalingam C
2019-02-16 18:18 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-02-21 18:11 [PATCH v15 00/16] " Ramalingam C
2019-02-21 18:26 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214150732.21135.95923@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ramalingam.c@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox