[PATCH igt] igt/kms_frontbuffer_tracking: Disable FBC testing for -ENODEV

[PATCH igt] igt/kms_frontbuffer_tracking: Disable FBC testing for -ENODEV

[Chris Wilson]

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/kms_frontbuffer_tracking.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 602707f98..6d3fe8d02 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -1588,6 +1588,9 @@ static bool fbc_supported_on_chipset(void)
 	char buf[128];
 
 	debugfs_read("i915_fbc_status", buf);
+	if (*buf == '\0')
+		return false;
+
 	return !strstr(buf, "FBC unsupported on this chipset\n");
 }
 
-- 
2.16.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt] igt/kms_frontbuffer_tracking: Disable FBC testing for -ENODEV

[Chris Wilson]

Quoting Chris Wilson (2018-02-11 18:54:33)
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Poke, CI is still tripping over this...

> ---
>  tests/kms_frontbuffer_tracking.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index 602707f98..6d3fe8d02 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -1588,6 +1588,9 @@ static bool fbc_supported_on_chipset(void)
>         char buf[128];
>  
>         debugfs_read("i915_fbc_status", buf);
> +       if (*buf == '\0')
> +               return false;
> +
>         return !strstr(buf, "FBC unsupported on this chipset\n");
>  }
>  
> -- 
> 2.16.1
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH igt] igt/kms_frontbuffer_tracking: Disable FBC testing for -ENODEV

[Daniel Vetter]

On Thu, Feb 15, 2018 at 09:21:47AM +0000, Chris Wilson wrote:
> Quoting Chris Wilson (2018-02-11 18:54:33)
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Poke, CI is still tripping over this...

Can you give a bit more context about what's going on and how this
happens? Bugzilla or whatever ... I'm confused.
-Daniel

> 
> > ---
> >  tests/kms_frontbuffer_tracking.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> > index 602707f98..6d3fe8d02 100644
> > --- a/tests/kms_frontbuffer_tracking.c
> > +++ b/tests/kms_frontbuffer_tracking.c
> > @@ -1588,6 +1588,9 @@ static bool fbc_supported_on_chipset(void)
> >         char buf[128];
> >  
> >         debugfs_read("i915_fbc_status", buf);
> > +       if (*buf == '\0')
> > +               return false;
> > +
> >         return !strstr(buf, "FBC unsupported on this chipset\n");
> >  }
> >  
> > -- 
> > 2.16.1
> > 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH igt] igt/kms_frontbuffer_tracking: Disable FBC testing for -ENODEV

[Chris Wilson]

Quoting Daniel Vetter (2018-02-20 12:17:18)
> On Thu, Feb 15, 2018 at 09:21:47AM +0000, Chris Wilson wrote:
> > Quoting Chris Wilson (2018-02-11 18:54:33)
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > 
> > Poke, CI is still tripping over this...
> 
> Can you give a bit more context about what's going on and how this
> happens? Bugzilla or whatever ... I'm confused.

i915_fbc_status():
	if (!HAS_FBC(dev_priv))
		return -ENODEV;

So whenever CI is run on machines without FBC (all of its gen3-gen5
machine, as the only ilk appears to be a desktop unless I missed one)
buf is empty.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH igt] igt/kms_frontbuffer_tracking: Disable FBC testing for -ENODEV

[Daniel Vetter]

On Tue, Feb 20, 2018 at 12:22:19PM +0000, Chris Wilson wrote:
> Quoting Daniel Vetter (2018-02-20 12:17:18)
> > On Thu, Feb 15, 2018 at 09:21:47AM +0000, Chris Wilson wrote:
> > > Quoting Chris Wilson (2018-02-11 18:54:33)
> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > 
> > > Poke, CI is still tripping over this...
> > 
> > Can you give a bit more context about what's going on and how this
> > happens? Bugzilla or whatever ... I'm confused.
> 
> i915_fbc_status():
> 	if (!HAS_FBC(dev_priv))
> 		return -ENODEV;
> 
> So whenever CI is run on machines without FBC (all of its gen3-gen5
> machine, as the only ilk appears to be a desktop unless I missed one)
> buf is empty.

Oh, I entirely missed that we errno out the read right away in that case.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx