From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: dhinakaran.pandiyan@intel.com
Subject: [PATCH 5/6] drm/i915/psr: Handle PSR RFB storage error
Date: Fri, 23 Feb 2018 18:03:10 -0800 [thread overview]
Message-ID: <20180224020311.14813-5-jose.souza@intel.com> (raw)
In-Reply-To: <20180224020311.14813-1-jose.souza@intel.com>
Sink will interrupt source when it have any problem saving or reading
the remote frame buffer.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/intel_psr.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index ab3713c2582b..4e73edf1ea5b 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -1010,6 +1010,16 @@ void intel_psr_hpd_short_pulse_handle(struct intel_dp *intel_dp)
if ((val & DP_PSR_SINK_STATE_MASK) == DP_PSR_SINK_INTERNAL_ERROR)
psr->exit(intel_dp, false);
+ if (drm_dp_dpcd_readb(&intel_dp->aux, DP_PSR_ERROR_STATUS, &val) != 1) {
+ DRM_DEBUG_KMS("PSR_ERROR_STATUS read failed\n");
+ goto dpcd_read_error;
+ }
+
+ if (val & DP_PSR_RFB_STORAGE_ERROR)
+ dev_priv->psr.exit(intel_dp, false);
+ /* clear status register */
+ drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_ERROR_STATUS, val);
+
/* TODO: handle other PSR/PSR2 errors */
dpcd_read_error:
intel_psr_active_schedule(psr, PSR_ACTIVE_DELAY_MSEC);
--
2.16.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-02-24 2:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 2:03 [PATCH 1/6] drm/i915/skl+: Add and enable DP AUX CH mutex José Roberto de Souza
2018-02-24 2:03 ` [PATCH 2/6] drm/i915/psr: Share the common code between PSR exit and disable José Roberto de Souza
2018-02-24 2:03 ` [PATCH 3/6] drm/i915: Exit PSR before do a aux transaction in gen < 9 José Roberto de Souza
2018-02-27 20:35 ` Pandiyan, Dhinakaran
2018-02-24 2:03 ` [PATCH 4/6] drm/i915/psr: Begin to handle PSR/PSR2 errors set by sink José Roberto de Souza
2018-02-24 2:03 ` José Roberto de Souza [this message]
2018-02-24 2:03 ` [PATCH 6/6] drm/i915/psr/hsw+: Enable CRC check in the static frame on the sink side José Roberto de Souza
2018-02-24 2:42 ` ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/i915/skl+: Add and enable DP AUX CH mutex Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180224020311.14813-5-jose.souza@intel.com \
--to=jose.souza@intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).