* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
2018-09-28 6:11 [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Dhinakaran Pandiyan
@ 2018-09-28 6:31 ` Patchwork
2018-09-28 6:50 ` ✗ Fi.CI.BAT: failure " Patchwork
` (9 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-09-28 6:31 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
URL : https://patchwork.freedesktop.org/series/49312/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
9a7813153aa9 drm/i915/psr: Enable PSR1 on gen-9+ HW
-:19: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#19:
References: commit 2ee7dc497e34 ("drm/i915: disable PSR by default on HSW/BDW")
-:20: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit dcb2e993f3c0 ("Revert "drm/i915: Enable PSR by default on Valleyview and Cherryview."")'
#20:
References: commit dcb2e993f3c0 ("Revert "drm/i915: Enable PSR by default on Valleyview and Cherryview."")
total: 1 errors, 1 warnings, 0 checks, 25 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread* ✗ Fi.CI.BAT: failure for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
2018-09-28 6:11 [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Dhinakaran Pandiyan
2018-09-28 6:31 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2) Patchwork
@ 2018-09-28 6:50 ` Patchwork
2018-09-28 13:25 ` ✓ Fi.CI.IGT: success " Patchwork
` (8 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-09-28 6:50 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
URL : https://patchwork.freedesktop.org/series/49312/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4903 -> Patchwork_10300 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10300 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10300, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49312/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10300:
=== IGT changes ===
==== Possible regressions ====
igt@amdgpu/amd_basic@cs-compute:
fi-kbl-8809g: NOTRUN -> FAIL
== Known issues ==
Here are the changes found in Patchwork_10300 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@amdgpu/amd_prime@amd-to-i915:
fi-kbl-8809g: NOTRUN -> FAIL (fdo#107341)
igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362)
==== Possible fixes ====
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
== Participating hosts (42 -> 36) ==
Missing (6): fi-ilk-m540 fi-bsw-cyan fi-icl-u2 fi-ctg-p8600 fi-pnv-d510 fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4903 -> Patchwork_10300
CI_DRM_4903: bf08ca6f9a90b72221f20feadba40a8f7a2dd129 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4656: 6f5d6b06a90526b4a8de93398f3c2dd537b3b7ba @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10300: 9a7813153aa915cb425d766712241af8c04fbae0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9a7813153aa9 drm/i915/psr: Enable PSR1 on gen-9+ HW
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10300/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
2018-09-28 6:11 [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Dhinakaran Pandiyan
2018-09-28 6:31 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2) Patchwork
2018-09-28 6:50 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2018-09-28 13:25 ` Patchwork
2018-10-01 19:04 ` ✓ Fi.CI.BAT: " Patchwork
` (7 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-09-28 13:25 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
URL : https://patchwork.freedesktop.org/series/49312/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4903_full -> Patchwork_10300_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10300_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10300_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10300_full:
=== IGT changes ===
==== Warnings ====
igt@perf_pmu@rc6:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_10300_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_nop@basic-series:
shard-glk: PASS -> DMESG-WARN (fdo#105763, fdo#106538)
igt@gem_fenced_exec_thrash@no-spare-fences:
shard-snb: NOTRUN -> INCOMPLETE (fdo#105411)
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-kbl: PASS -> INCOMPLETE (fdo#106023, fdo#103665)
igt@gem_pwrite@big-gtt-backwards:
shard-glk: PASS -> INCOMPLETE (fdo#103359, k.org#198133)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
shard-snb: NOTRUN -> DMESG-WARN (fdo#107956) +2
igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt:
shard-apl: SKIP -> INCOMPLETE (fdo#103927)
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
shard-snb: NOTRUN -> FAIL (fdo#99912)
==== Possible fixes ====
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render:
shard-glk: FAIL (fdo#103167) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 5) ==
Missing (1): shard-skl
== Build changes ==
* Linux: CI_DRM_4903 -> Patchwork_10300
CI_DRM_4903: bf08ca6f9a90b72221f20feadba40a8f7a2dd129 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4656: 6f5d6b06a90526b4a8de93398f3c2dd537b3b7ba @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10300: 9a7813153aa915cb425d766712241af8c04fbae0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10300/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
2018-09-28 6:11 [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Dhinakaran Pandiyan
` (2 preceding siblings ...)
2018-09-28 13:25 ` ✓ Fi.CI.IGT: success " Patchwork
@ 2018-10-01 19:04 ` Patchwork
2018-10-01 22:17 ` [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Rodrigo Vivi
` (6 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-10-01 19:04 UTC (permalink / raw)
To: Pandiyan, Dhinakaran; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
URL : https://patchwork.freedesktop.org/series/49312/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4909 -> Patchwork_10312 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49312/revisions/2/mbox/
== Known issues ==
Here are the changes found in Patchwork_10312 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@amdgpu/amd_cs_nop@fork-gfx0:
fi-kbl-8809g: PASS -> DMESG-WARN (fdo#107762)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-bdw-samus: NOTRUN -> INCOMPLETE (fdo#107773)
==== Possible fixes ====
igt@gem_exec_suspend@basic-s4-devices:
fi-bdw-samus: INCOMPLETE (fdo#107773) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107762 https://bugs.freedesktop.org/show_bug.cgi?id=107762
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
== Participating hosts (52 -> 47) ==
Additional (1): fi-skl-guc
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-u2 fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_4909 -> Patchwork_10312
CI_DRM_4909: f045c20e31b216e68d869c9215239224b048a240 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4658: cab89ce2c5da684d01deff402d4e8e11441beadb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10312: b593302a41ec9a0f0e5826888907d3f8e2edf56f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b593302a41ec drm/i915/psr: Enable PSR1 on gen-9+ HW
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10312/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW
2018-09-28 6:11 [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Dhinakaran Pandiyan
` (3 preceding siblings ...)
2018-10-01 19:04 ` ✓ Fi.CI.BAT: " Patchwork
@ 2018-10-01 22:17 ` Rodrigo Vivi
2018-10-02 17:40 ` Dhinakaran Pandiyan
2018-10-01 22:23 ` ✓ Fi.CI.IGT: success for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2) Patchwork
` (5 subsequent siblings)
10 siblings, 1 reply; 14+ messages in thread
From: Rodrigo Vivi @ 2018-10-01 22:17 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: Jani Nikula, intel-gfx, Paulo Zanoni
On Thu, Sep 27, 2018 at 11:11:17PM -0700, Dhinakaran Pandiyan wrote:
> We have new tests and fixes in place since the feature was last
> disabled. Try again for gen-9+ hardware and enable only PSR1 by default as
> a first step.
> v2: Remove typo fix and comment improvements (Rodrigo)
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Jose Roberto de Souza <jose.souza@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> References: commit 2ee7dc497e34 ("drm/i915: disable PSR by default on HSW/BDW")
> References: commit dcb2e993f3c0 ("Revert "drm/i915: Enable PSR by default on Valleyview and Cherryview."")
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
It seems that we still need to wait and check why shard-skl wasn't up on this CI,
but patch itself is right, so
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_psr.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
> index b6838b525502..5a2660ad8203 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -71,6 +71,10 @@ static bool psr_global_enabled(u32 debug)
> static bool intel_psr2_enabled(struct drm_i915_private *dev_priv,
> const struct intel_crtc_state *crtc_state)
> {
> + /* Disable PSR2 by default for all platforms */
> + if (i915_modparams.enable_psr == -1)
> + return false;
> +
> switch (dev_priv->psr.debug & I915_PSR_DEBUG_MODE_MASK) {
> case I915_PSR_DEBUG_FORCE_PSR1:
> return false;
> @@ -1065,12 +1069,9 @@ void intel_psr_init(struct drm_i915_private *dev_priv)
> if (!dev_priv->psr.sink_support)
> return;
>
> - if (i915_modparams.enable_psr == -1) {
> - i915_modparams.enable_psr = dev_priv->vbt.psr.enable;
> -
> - /* Per platform default: all disabled. */
> - i915_modparams.enable_psr = 0;
> - }
> + if (i915_modparams.enable_psr == -1)
> + if (INTEL_GEN(dev_priv) < 9 || !dev_priv->vbt.psr.enable)
> + i915_modparams.enable_psr = 0;
>
> /* Set link_standby x link_off defaults */
> if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
> --
> 2.17.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW
2018-10-01 22:17 ` [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Rodrigo Vivi
@ 2018-10-02 17:40 ` Dhinakaran Pandiyan
0 siblings, 0 replies; 14+ messages in thread
From: Dhinakaran Pandiyan @ 2018-10-02 17:40 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: Jani Nikula, intel-gfx, Paulo Zanoni
On Mon, 2018-10-01 at 15:17 -0700, Rodrigo Vivi wrote:
> On Thu, Sep 27, 2018 at 11:11:17PM -0700, Dhinakaran Pandiyan wrote:
> > We have new tests and fixes in place since the feature was last
> > disabled. Try again for gen-9+ hardware and enable only PSR1 by
> > default as
> > a first step.
> > v2: Remove typo fix and comment improvements (Rodrigo)
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Jose Roberto de Souza <jose.souza@intel.com>
> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > References: commit 2ee7dc497e34 ("drm/i915: disable PSR by default
> > on HSW/BDW")
> > References: commit dcb2e993f3c0 ("Revert "drm/i915: Enable PSR by
> > default on Valleyview and Cherryview."")
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>
> It seems that we still need to wait and check why shard-skl wasn't up
> on this CI,
The results from shard-skl look okay, time to merge this?
-DK
> but patch itself is right, so
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> > ---
> > drivers/gpu/drm/i915/intel_psr.c | 13 +++++++------
> > 1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_psr.c
> > b/drivers/gpu/drm/i915/intel_psr.c
> > index b6838b525502..5a2660ad8203 100644
> > --- a/drivers/gpu/drm/i915/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/intel_psr.c
> > @@ -71,6 +71,10 @@ static bool psr_global_enabled(u32 debug)
> > static bool intel_psr2_enabled(struct drm_i915_private *dev_priv,
> > const struct intel_crtc_state
> > *crtc_state)
> > {
> > + /* Disable PSR2 by default for all platforms */
> > + if (i915_modparams.enable_psr == -1)
> > + return false;
> > +
> > switch (dev_priv->psr.debug & I915_PSR_DEBUG_MODE_MASK) {
> > case I915_PSR_DEBUG_FORCE_PSR1:
> > return false;
> > @@ -1065,12 +1069,9 @@ void intel_psr_init(struct drm_i915_private
> > *dev_priv)
> > if (!dev_priv->psr.sink_support)
> > return;
> >
> > - if (i915_modparams.enable_psr == -1) {
> > - i915_modparams.enable_psr = dev_priv->vbt.psr.enable;
> > -
> > - /* Per platform default: all disabled. */
> > - i915_modparams.enable_psr = 0;
> > - }
> > + if (i915_modparams.enable_psr == -1)
> > + if (INTEL_GEN(dev_priv) < 9 || !dev_priv-
> > >vbt.psr.enable)
> > + i915_modparams.enable_psr = 0;
> >
> > /* Set link_standby x link_off defaults */
> > if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
> > --
> > 2.17.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
2018-09-28 6:11 [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Dhinakaran Pandiyan
` (4 preceding siblings ...)
2018-10-01 22:17 ` [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Rodrigo Vivi
@ 2018-10-01 22:23 ` Patchwork
2018-10-02 7:41 ` ✓ Fi.CI.BAT: " Patchwork
` (4 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-10-01 22:23 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
URL : https://patchwork.freedesktop.org/series/49312/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4909_full -> Patchwork_10312_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10312_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_cpu_reloc@full:
shard-apl: PASS -> INCOMPLETE (fdo#103927)
igt@gem_exec_big:
shard-hsw: PASS -> TIMEOUT (fdo#107937)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
igt@perf@buffer-fill:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@perf@polling:
shard-hsw: PASS -> FAIL (fdo#102252)
==== Possible fixes ====
igt@kms_busy@extended-modeset-hang-newfb-render-b:
shard-hsw: DMESG-WARN (fdo#107956) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363) -> PASS
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#107937 https://bugs.freedesktop.org/show_bug.cgi?id=107937
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 5) ==
Missing (1): shard-skl
== Build changes ==
* Linux: CI_DRM_4909 -> Patchwork_10312
CI_DRM_4909: f045c20e31b216e68d869c9215239224b048a240 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4658: cab89ce2c5da684d01deff402d4e8e11441beadb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10312: b593302a41ec9a0f0e5826888907d3f8e2edf56f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10312/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
2018-09-28 6:11 [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Dhinakaran Pandiyan
` (5 preceding siblings ...)
2018-10-01 22:23 ` ✓ Fi.CI.IGT: success for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2) Patchwork
@ 2018-10-02 7:41 ` Patchwork
2018-10-02 8:04 ` Patchwork
` (3 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-10-02 7:41 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
URL : https://patchwork.freedesktop.org/series/49312/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4911 -> Patchwork_10318 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49312/revisions/2/mbox/
== Known issues ==
Here are the changes found in Patchwork_10318 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_getparams_basic@basic-subslice-total:
fi-snb-2520m: NOTRUN -> DMESG-WARN (fdo#103713) +10
igt@drv_module_reload@basic-reload:
fi-blb-e6850: NOTRUN -> INCOMPLETE (fdo#107718)
==== Possible fixes ====
igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
== Participating hosts (49 -> 46) ==
Additional (3): fi-gdg-551 fi-snb-2520m fi-pnv-d510
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-u2 fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_4911 -> Patchwork_10318
CI_DRM_4911: e46b4809753a2e3d3d73c5a9e028cd030bea60e5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4659: 7f41adfbfd17027b71c332d6ae997f1364f73731 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10318: de9730ce7022d52d50bfacbd7b8c5b0e987d6696 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
de9730ce7022 drm/i915/psr: Enable PSR1 on gen-9+ HW
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10318/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
2018-09-28 6:11 [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Dhinakaran Pandiyan
` (6 preceding siblings ...)
2018-10-02 7:41 ` ✓ Fi.CI.BAT: " Patchwork
@ 2018-10-02 8:04 ` Patchwork
2018-10-02 8:33 ` ✓ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
10 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-10-02 8:04 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
URL : https://patchwork.freedesktop.org/series/49312/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4911 -> Patchwork_10319 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49312/revisions/2/mbox/
== Known issues ==
Here are the changes found in Patchwork_10319 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
fi-skl-guc: PASS -> DMESG-FAIL (fdo#106685)
igt@kms_flip@basic-flip-vs-dpms:
fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927)
==== Possible fixes ====
igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#106685 https://bugs.freedesktop.org/show_bug.cgi?id=106685
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
== Participating hosts (49 -> 45) ==
Additional (3): fi-gdg-551 fi-snb-2520m fi-pnv-d510
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-u2 fi-ctg-p8600 fi-skl-caroline
== Build changes ==
* Linux: CI_DRM_4911 -> Patchwork_10319
CI_DRM_4911: e46b4809753a2e3d3d73c5a9e028cd030bea60e5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4659: 7f41adfbfd17027b71c332d6ae997f1364f73731 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10319: 41f6dc186ad213760337d0dfd736e51832072974 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
41f6dc186ad2 drm/i915/psr: Enable PSR1 on gen-9+ HW
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10319/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
2018-09-28 6:11 [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Dhinakaran Pandiyan
` (7 preceding siblings ...)
2018-10-02 8:04 ` Patchwork
@ 2018-10-02 8:33 ` Patchwork
2018-10-02 9:19 ` Patchwork
2018-10-02 19:37 ` [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Souza, Jose
10 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-10-02 8:33 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
URL : https://patchwork.freedesktop.org/series/49312/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4911_full -> Patchwork_10318_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10318_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10318_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10318_full:
=== IGT changes ===
==== Warnings ====
igt@perf_pmu@rc6:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_10318_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_cpu_reloc@full:
{shard-skl}: NOTRUN -> INCOMPLETE (fdo#108073)
igt@gem_exec_await@wide-contexts:
shard-apl: PASS -> FAIL (fdo#106680)
igt@gem_exec_big:
shard-hsw: PASS -> TIMEOUT (fdo#107937)
igt@gem_exec_schedule@pi-ringfull-blt:
{shard-skl}: NOTRUN -> FAIL (fdo#103158) +1
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
shard-hsw: PASS -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
shard-kbl: PASS -> DMESG-WARN (fdo#107956) +1
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
{shard-skl}: NOTRUN -> DMESG-WARN (fdo#107956) +1
igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
{shard-skl}: NOTRUN -> FAIL (fdo#105458)
igt@kms_fbcon_fbt@psr:
{shard-skl}: NOTRUN -> FAIL (fdo#107882)
igt@kms_frontbuffer_tracking@fbc-stridechange:
{shard-skl}: NOTRUN -> FAIL (fdo#105683)
igt@kms_panel_fitting@legacy:
{shard-skl}: NOTRUN -> FAIL (fdo#105456)
igt@kms_plane@pixel-format-pipe-b-planes:
{shard-skl}: NOTRUN -> DMESG-WARN (fdo#106885) +1
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
igt@kms_sysfs_edid_timing:
{shard-skl}: NOTRUN -> FAIL (fdo#100047)
igt@kms_vblank@pipe-b-wait-forked-busy:
shard-kbl: PASS -> DMESG-WARN (fdo#105602, fdo#103558) +3
==== Possible fixes ====
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363) -> PASS +1
igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
shard-apl: DMESG-WARN (fdo#105602, fdo#103558) -> PASS +4
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105456 https://bugs.freedesktop.org/show_bug.cgi?id=105456
fdo#105458 https://bugs.freedesktop.org/show_bug.cgi?id=105458
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105683 https://bugs.freedesktop.org/show_bug.cgi?id=105683
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#106885 https://bugs.freedesktop.org/show_bug.cgi?id=106885
fdo#107882 https://bugs.freedesktop.org/show_bug.cgi?id=107882
fdo#107937 https://bugs.freedesktop.org/show_bug.cgi?id=107937
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108073 https://bugs.freedesktop.org/show_bug.cgi?id=108073
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4911 -> Patchwork_10318
CI_DRM_4911: e46b4809753a2e3d3d73c5a9e028cd030bea60e5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4659: 7f41adfbfd17027b71c332d6ae997f1364f73731 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10318: de9730ce7022d52d50bfacbd7b8c5b0e987d6696 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10318/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
2018-09-28 6:11 [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Dhinakaran Pandiyan
` (8 preceding siblings ...)
2018-10-02 8:33 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-10-02 9:19 ` Patchwork
2018-10-02 19:37 ` [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Souza, Jose
10 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2018-10-02 9:19 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)
URL : https://patchwork.freedesktop.org/series/49312/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4911_full -> Patchwork_10319_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10319_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10319_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10319_full:
=== IGT changes ===
==== Warnings ====
igt@perf_pmu@rc6:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_10319_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_big:
shard-hsw: PASS -> TIMEOUT (fdo#107937)
igt@gem_exec_schedule@pi-ringfull-blt:
{shard-skl}: NOTRUN -> FAIL (fdo#103158) +1
igt@gem_ppgtt@blt-vs-render-ctxn:
{shard-skl}: NOTRUN -> TIMEOUT (fdo#108039)
igt@gem_softpin@noreloc-s3:
{shard-skl}: PASS -> INCOMPLETE (fdo#107773, fdo#104108)
igt@kms_busy@extended-modeset-hang-newfb-render-c:
{shard-skl}: NOTRUN -> DMESG-WARN (fdo#107956) +2
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
shard-hsw: PASS -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
shard-kbl: PASS -> DMESG-WARN (fdo#107956) +1
igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
{shard-skl}: NOTRUN -> FAIL (fdo#105458)
igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
shard-glk: PASS -> DMESG-WARN (fdo#106538, fdo#105763)
igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled:
shard-glk: PASS -> FAIL (fdo#103184)
igt@kms_panel_fitting@legacy:
{shard-skl}: NOTRUN -> FAIL (fdo#105456)
igt@kms_plane@pixel-format-pipe-c-planes:
{shard-skl}: NOTRUN -> DMESG-WARN (fdo#106885)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@kms_busy@extended-modeset-hang-newfb-render-a:
shard-kbl: DMESG-WARN (fdo#107956) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363) -> PASS +1
igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
{shard-skl}: INCOMPLETE (fdo#107773, fdo#104108) -> PASS
igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
shard-apl: DMESG-WARN (fdo#103558, fdo#105602) -> PASS +4
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105456 https://bugs.freedesktop.org/show_bug.cgi?id=105456
fdo#105458 https://bugs.freedesktop.org/show_bug.cgi?id=105458
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106885 https://bugs.freedesktop.org/show_bug.cgi?id=106885
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107937 https://bugs.freedesktop.org/show_bug.cgi?id=107937
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108039 https://bugs.freedesktop.org/show_bug.cgi?id=108039
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4911 -> Patchwork_10319
CI_DRM_4911: e46b4809753a2e3d3d73c5a9e028cd030bea60e5 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4659: 7f41adfbfd17027b71c332d6ae997f1364f73731 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10319: 41f6dc186ad213760337d0dfd736e51832072974 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10319/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW
2018-09-28 6:11 [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Dhinakaran Pandiyan
` (9 preceding siblings ...)
2018-10-02 9:19 ` Patchwork
@ 2018-10-02 19:37 ` Souza, Jose
2018-10-02 23:09 ` Dhinakaran Pandiyan
10 siblings, 1 reply; 14+ messages in thread
From: Souza, Jose @ 2018-10-02 19:37 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org, Pandiyan, Dhinakaran
Cc: Nikula, Jani, Zanoni, Paulo R, Vivi, Rodrigo
On Thu, 2018-09-27 at 23:11 -0700, Dhinakaran Pandiyan wrote:
> We have new tests and fixes in place since the feature was last
> disabled. Try again for gen-9+ hardware and enable only PSR1 by
> default as
> a first step.
> v2: Remove typo fix and comment improvements (Rodrigo)
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Tested-by: José Roberto de Souza <jose.souza@intel.com>
It works without any glitches in all the 3 gen9+ machines that I
tested.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Jose Roberto de Souza <jose.souza@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> References: commit 2ee7dc497e34 ("drm/i915: disable PSR by default on
> HSW/BDW")
> References: commit dcb2e993f3c0 ("Revert "drm/i915: Enable PSR by
> default on Valleyview and Cherryview."")
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> drivers/gpu/drm/i915/intel_psr.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_psr.c
> b/drivers/gpu/drm/i915/intel_psr.c
> index b6838b525502..5a2660ad8203 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -71,6 +71,10 @@ static bool psr_global_enabled(u32 debug)
> static bool intel_psr2_enabled(struct drm_i915_private *dev_priv,
> const struct intel_crtc_state
> *crtc_state)
> {
> + /* Disable PSR2 by default for all platforms */
> + if (i915_modparams.enable_psr == -1)
> + return false;
> +
> switch (dev_priv->psr.debug & I915_PSR_DEBUG_MODE_MASK) {
> case I915_PSR_DEBUG_FORCE_PSR1:
> return false;
> @@ -1065,12 +1069,9 @@ void intel_psr_init(struct drm_i915_private
> *dev_priv)
> if (!dev_priv->psr.sink_support)
> return;
>
> - if (i915_modparams.enable_psr == -1) {
> - i915_modparams.enable_psr = dev_priv->vbt.psr.enable;
> -
> - /* Per platform default: all disabled. */
> - i915_modparams.enable_psr = 0;
> - }
> + if (i915_modparams.enable_psr == -1)
> + if (INTEL_GEN(dev_priv) < 9 || !dev_priv-
> >vbt.psr.enable)
> + i915_modparams.enable_psr = 0;
>
> /* Set link_standby x link_off defaults */
> if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW
2018-10-02 19:37 ` [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW Souza, Jose
@ 2018-10-02 23:09 ` Dhinakaran Pandiyan
0 siblings, 0 replies; 14+ messages in thread
From: Dhinakaran Pandiyan @ 2018-10-02 23:09 UTC (permalink / raw)
To: Souza, Jose, intel-gfx@lists.freedesktop.org
Cc: Nikula, Jani, Zanoni, Paulo R, Vivi, Rodrigo
On Tue, 2018-10-02 at 12:37 -0700, Souza, Jose wrote:
> On Thu, 2018-09-27 at 23:11 -0700, Dhinakaran Pandiyan wrote:
> > We have new tests and fixes in place since the feature was last
> > disabled. Try again for gen-9+ hardware and enable only PSR1 by
> > default as
> > a first step.
> > v2: Remove typo fix and comment improvements (Rodrigo)
>
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> Tested-by: José Roberto de Souza <jose.souza@intel.com>
>
> It works without any glitches in all the 3 gen9+ machines that I
> tested.
>
Pushed, thanks for the reviews and testing.
-DK
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread