Re: [PATCH 3/4] drm/i915: Move intel_init_ipc() call to i915_load_modeset_init()

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Nov 07, 2018 at 04:16:46PM -0800, José Roberto de Souza wrote:
> IPC is a display feature, so i915_load_modeset_init() is the right
> place to initialize it.
> 
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 09208c73ca04..44903ce1b82d 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -706,6 +706,8 @@ static int i915_load_modeset_init(struct drm_device *dev)
>  	/* Only enable hotplug handling once the fbdev is fully set up. */
>  	intel_hpd_init(dev_priv);
>  
> +	intel_init_ipc(dev_priv);
> +

Hrm. So we won't actually use ipc for whatever initial commits we do
during the setup. That seems a bit odd. Oh well, one more thing to
put on the skl wm TODO list.

Patch is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>  	return 0;
>  
>  cleanup_gem:
> @@ -1725,8 +1727,6 @@ int i915_driver_load(struct pci_dev *pdev, const struct pci_device_id *ent)
>  
>  	i915_driver_register(dev_priv);
>  
> -	intel_init_ipc(dev_priv);
> -
>  	enable_rpm_wakeref_asserts(dev_priv);
>  
>  	i915_welcome_messages(dev_priv);
> -- 
> 2.19.1

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx