Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Lyude Paul <lyude@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for MST refcounting/atomic helpers cleanup (rev5)
Date: Wed, 09 Jan 2019 00:54:51 -0000	[thread overview]
Message-ID: <20190109005451.28505.16406@emeril.freedesktop.org> (raw)
In-Reply-To: <20190109003516.14752-1-lyude@redhat.com>

== Series Details ==

Series: MST refcounting/atomic helpers cleanup (rev5)
URL   : https://patchwork.freedesktop.org/series/54030/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5778d100cac7 drm/dp_mst: Fix some formatting in drm_dp_add_port()
2fd355b3a9aa drm/dp_mst: Fix some formatting in drm_dp_payload_send_msg()
f7a476bd0e0f drm/dp_mst: Fix some formatting in drm_dp_mst_allocate_vcpi()
0b7daea7eab8 drm/dp_mst: Fix some formatting in drm_dp_mst_deallocate_vcpi()
bc368b90cb12 drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends
-:84: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#84: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:990:
+			rmstb = drm_dp_mst_topology_get_mstb_validated_locked(

-:102: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#102: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1006:
+		rmstb = drm_dp_mst_topology_get_mstb_validated_locked(

-:150: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#150: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1379:
+			mstb_child = drm_dp_mst_topology_get_mstb_validated(

total: 0 errors, 0 warnings, 3 checks, 401 lines checked
f212460470bf drm/dp_mst: Introduce new refcounting scheme for mstbs and ports
-:27: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#27: 
commit 263efde31f97 ("drm/dp/mst: Get validated port ref in drm_dp_update_payload_part1()")

-:51: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9765635b3075 ("Revert "drm/dp_mst: Skip validating ports during destruction, just ref"")'
#51: 
commit 9765635b3075 ("Revert "drm/dp_mst: Skip validating ports during destruction, just ref"")

-:137: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#137: 
new file mode 100644

-:842: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#842: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1329:
+			mport = drm_dp_mst_topology_get_port_validated_locked(

-:856: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#856: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1346:
+		rport = drm_dp_mst_topology_get_port_validated_locked(

total: 1 errors, 2 warnings, 2 checks, 915 lines checked
a1f9438797bb drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails
11a9df239381 drm/dp_mst: Stop releasing VCPI when removing ports from topology
33e82d971527 drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs
-:97: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#97: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2278:
+				port = drm_dp_mst_topology_get_port_validated(

total: 0 errors, 0 warnings, 1 checks, 124 lines checked
89d20c7c627b drm/i915: Keep malloc references to MST ports
f0300e01a8cf drm/amdgpu/display: Keep malloc ref to MST port
523545b36c93 drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector()
171456c757e5 drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup()
a7f4c8e68b5d drm/nouveau: Keep malloc references to MST ports
916a684cd19b drm/nouveau: Stop unsetting mstc->port, use malloc refs
01a9632ebf65 drm/nouveau: Grab payload lock in nv50_msto_payload()
d1f83b76bee9 drm/dp_mst: Add some atomic state iterator macros
-:110: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#110: FILE: include/drm/drm_dp_mst_helper.h:711:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:110: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#110: FILE: include/drm/drm_dp_mst_helper.h:711:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:112: WARNING:LONG_LINE: line over 100 characters
#112: FILE: include/drm/drm_dp_mst_helper.h:713:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), &(new_state), (__i)))

-:127: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#127: FILE: include/drm/drm_dp_mst_helper.h:728:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:127: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#127: FILE: include/drm/drm_dp_mst_helper.h:728:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:129: WARNING:LONG_LINE: line over 100 characters
#129: FILE: include/drm/drm_dp_mst_helper.h:730:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), &(old_state), NULL, (__i)))

-:145: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible side-effects?
#145: FILE: include/drm/drm_dp_mst_helper.h:746:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

-:145: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible side-effects?
#145: FILE: include/drm/drm_dp_mst_helper.h:746:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+	for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

-:147: WARNING:LONG_LINE: line over 100 characters
#147: FILE: include/drm/drm_dp_mst_helper.h:748:
+		for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr), NULL, &(new_state), (__i)))

total: 0 errors, 3 warnings, 6 checks, 120 lines checked
9077cacf44e8 drm/dp_mst: Start tracking per-port VCPI allocations
-:45: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#45: 
  * Cleanup atomic check logic for VCPI allocations - all we need to check in

total: 0 errors, 1 warnings, 0 checks, 444 lines checked
1acb8253f5b7 drm/dp_mst: Check payload count in drm_dp_mst_atomic_check()
d6b0067e30e5 drm/nouveau: Use atomic VCPI helpers for MST

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-01-09  0:54 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09  0:34 [PATCH v5 00/20] MST refcounting/atomic helpers cleanup Lyude Paul
     [not found] ` <20190109003516.14752-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-09  0:34   ` [PATCH v5 01/20] drm/dp_mst: Fix some formatting in drm_dp_add_port() Lyude Paul
2019-01-09  0:34   ` [PATCH v5 02/20] drm/dp_mst: Fix some formatting in drm_dp_payload_send_msg() Lyude Paul
2019-01-09  0:35   ` [PATCH v5 03/20] drm/dp_mst: Fix some formatting in drm_dp_mst_allocate_vcpi() Lyude Paul
2019-01-09  0:35   ` [PATCH v5 04/20] drm/dp_mst: Fix some formatting in drm_dp_mst_deallocate_vcpi() Lyude Paul
     [not found]     ` <20190109003516.14752-5-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10  9:16       ` Daniel Vetter
2019-01-09  0:35   ` [PATCH v5 05/20] drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends Lyude Paul
2019-01-09  0:35   ` [PATCH v5 06/20] drm/dp_mst: Introduce new refcounting scheme for mstbs and ports Lyude Paul
     [not found]     ` <20190109003516.14752-7-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10  9:12       ` Daniel Vetter
2019-01-09  0:35   ` [PATCH v5 07/20] drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails Lyude Paul
     [not found]     ` <20190109003516.14752-8-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10  9:16       ` Daniel Vetter
2019-01-09  0:35   ` [PATCH v5 08/20] drm/dp_mst: Stop releasing VCPI when removing ports from topology Lyude Paul
2019-01-10  9:17     ` Daniel Vetter
2019-01-09  0:35   ` [PATCH v5 09/20] drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs Lyude Paul
2019-01-09  0:35   ` [PATCH v5 10/20] drm/i915: Keep malloc references to MST ports Lyude Paul
2019-01-09  0:35   ` [PATCH v5 12/20] drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector() Lyude Paul
2019-01-09  0:35   ` [PATCH v5 13/20] drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup() Lyude Paul
2019-01-09  0:35   ` [PATCH v5 14/20] drm/nouveau: Keep malloc references to MST ports Lyude Paul
2019-01-09  0:35   ` [PATCH v5 15/20] drm/nouveau: Stop unsetting mstc->port, use malloc refs Lyude Paul
2019-01-09  0:35   ` [PATCH v5 16/20] drm/nouveau: Grab payload lock in nv50_msto_payload() Lyude Paul
2019-01-09  0:35   ` [PATCH v5 17/20] drm/dp_mst: Add some atomic state iterator macros Lyude Paul
2019-01-10  9:28     ` Daniel Vetter
2019-01-09  0:35   ` [PATCH v5 18/20] drm/dp_mst: Start tracking per-port VCPI allocations Lyude Paul
     [not found]     ` <20190109003516.14752-19-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10  9:35       ` Daniel Vetter
2019-01-09  0:35   ` [PATCH v5 19/20] drm/dp_mst: Check payload count in drm_dp_mst_atomic_check() Lyude Paul
     [not found]     ` <20190109003516.14752-20-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10  9:35       ` Daniel Vetter
2019-01-09  0:35   ` [PATCH v5 20/20] drm/nouveau: Use atomic VCPI helpers for MST Lyude Paul
2019-01-09  0:35 ` [PATCH v5 11/20] drm/amdgpu/display: Keep malloc ref to MST port Lyude Paul
2019-01-09  0:54 ` Patchwork [this message]
2019-01-09  1:15 ` ✓ Fi.CI.BAT: success for MST refcounting/atomic helpers cleanup (rev5) Patchwork
2019-01-09 10:45 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190109005451.28505.16406@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lyude@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox