From: Daniel Vetter <daniel@ffwll.ch>
To: Lyude Paul <lyude@redhat.com>
Cc: nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org, Jerry Zuo <Jerry.Zuo@amd.com>,
dri-devel@lists.freedesktop.org,
David Airlie <airlied@redhat.com>,
Harry Wentland <harry.wentland@amd.com>
Subject: Re: [PATCH v5 08/20] drm/dp_mst: Stop releasing VCPI when removing ports from topology
Date: Thu, 10 Jan 2019 10:17:20 +0100 [thread overview]
Message-ID: <20190110091719.GF21184@phenom.ffwll.local> (raw)
In-Reply-To: <20190109003516.14752-9-lyude@redhat.com>
On Tue, Jan 08, 2019 at 07:35:05PM -0500, Lyude Paul wrote:
> This has never actually worked, and isn't needed anyway: the driver's
> always going to try to deallocate VCPI when it tears down the display
> that the VCPI belongs to.
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@redhat.com>
> Cc: Jerry Zuo <Jerry.Zuo@amd.com>
> Cc: Juston Li <juston.li@intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/drm_dp_mst_topology.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> index bafc85f08606..8088527a7aea 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -1176,8 +1176,6 @@ static void drm_dp_destroy_port(struct kref *kref)
> struct drm_dp_mst_topology_mgr *mgr = port->mgr;
>
> if (!port->input) {
> - port->vcpi.num_slots = 0;
> -
> kfree(port->cached_edid);
>
> /*
> @@ -3496,12 +3494,6 @@ static void drm_dp_destroy_connector_work(struct work_struct *work)
> drm_dp_port_teardown_pdt(port, port->pdt);
> port->pdt = DP_PEER_DEVICE_NONE;
>
> - if (!port->input && port->vcpi.vcpi > 0) {
> - drm_dp_mst_reset_vcpi_slots(mgr, port);
> - drm_dp_update_payload_part1(mgr);
> - drm_dp_mst_put_payload_id(mgr, port->vcpi.vcpi);
> - }
> -
> drm_dp_mst_put_port_malloc(port);
> send_hotplug = true;
> }
> --
> 2.20.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-01-10 9:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 0:34 [PATCH v5 00/20] MST refcounting/atomic helpers cleanup Lyude Paul
2019-01-09 0:35 ` [PATCH v5 11/20] drm/amdgpu/display: Keep malloc ref to MST port Lyude Paul
[not found] ` <20190109003516.14752-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-09 0:34 ` [PATCH v5 01/20] drm/dp_mst: Fix some formatting in drm_dp_add_port() Lyude Paul
2019-01-09 0:34 ` [PATCH v5 02/20] drm/dp_mst: Fix some formatting in drm_dp_payload_send_msg() Lyude Paul
2019-01-09 0:35 ` [PATCH v5 03/20] drm/dp_mst: Fix some formatting in drm_dp_mst_allocate_vcpi() Lyude Paul
2019-01-09 0:35 ` [PATCH v5 04/20] drm/dp_mst: Fix some formatting in drm_dp_mst_deallocate_vcpi() Lyude Paul
[not found] ` <20190109003516.14752-5-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10 9:16 ` Daniel Vetter
2019-01-09 0:35 ` [PATCH v5 05/20] drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends Lyude Paul
2019-01-09 0:35 ` [PATCH v5 06/20] drm/dp_mst: Introduce new refcounting scheme for mstbs and ports Lyude Paul
[not found] ` <20190109003516.14752-7-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10 9:12 ` Daniel Vetter
2019-01-09 0:35 ` [PATCH v5 07/20] drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails Lyude Paul
[not found] ` <20190109003516.14752-8-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10 9:16 ` Daniel Vetter
2019-01-09 0:35 ` [PATCH v5 08/20] drm/dp_mst: Stop releasing VCPI when removing ports from topology Lyude Paul
2019-01-10 9:17 ` Daniel Vetter [this message]
2019-01-09 0:35 ` [PATCH v5 09/20] drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs Lyude Paul
2019-01-09 0:35 ` [PATCH v5 10/20] drm/i915: Keep malloc references to MST ports Lyude Paul
2019-01-09 0:35 ` [PATCH v5 12/20] drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector() Lyude Paul
2019-01-09 0:35 ` [PATCH v5 13/20] drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup() Lyude Paul
2019-01-09 0:35 ` [PATCH v5 14/20] drm/nouveau: Keep malloc references to MST ports Lyude Paul
2019-01-09 0:35 ` [PATCH v5 15/20] drm/nouveau: Stop unsetting mstc->port, use malloc refs Lyude Paul
2019-01-09 0:35 ` [PATCH v5 16/20] drm/nouveau: Grab payload lock in nv50_msto_payload() Lyude Paul
2019-01-09 0:35 ` [PATCH v5 17/20] drm/dp_mst: Add some atomic state iterator macros Lyude Paul
2019-01-10 9:28 ` Daniel Vetter
2019-01-09 0:35 ` [PATCH v5 18/20] drm/dp_mst: Start tracking per-port VCPI allocations Lyude Paul
[not found] ` <20190109003516.14752-19-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10 9:35 ` Daniel Vetter
2019-01-09 0:35 ` [PATCH v5 19/20] drm/dp_mst: Check payload count in drm_dp_mst_atomic_check() Lyude Paul
[not found] ` <20190109003516.14752-20-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-01-10 9:35 ` Daniel Vetter
2019-01-09 0:35 ` [PATCH v5 20/20] drm/nouveau: Use atomic VCPI helpers for MST Lyude Paul
2019-01-09 0:54 ` ✗ Fi.CI.CHECKPATCH: warning for MST refcounting/atomic helpers cleanup (rev5) Patchwork
2019-01-09 1:15 ` ✓ Fi.CI.BAT: success " Patchwork
2019-01-09 10:45 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110091719.GF21184@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Jerry.Zuo@amd.com \
--cc=airlied@redhat.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox