* [PATCH] drm/i915: Pick the first unused PLL once again
@ 2019-01-30 18:13 Ville Syrjala
2019-01-30 19:29 ` ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Ville Syrjala @ 2019-01-30 18:13 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi, Paulo Zanoni
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
commit 5b0bd14dcc6b ("drm/i915/icl: keep track of unused pll while
looping") inadvertently (I presume) changed the code to pick the
last unused dpll rather than the first unused one like we did before.
While there should most likely be no harm in changing the order
let's change back just to avoid a change in the behaviour. At
least it might reduce the confusion when staring at logs (took
me a while to figure out why DPLL1 being picked over DPLL0
when the latter was most definitely available).
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_dpll_mgr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
index 8f70838ac7d8..0a42d11c4c33 100644
--- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
@@ -258,7 +258,8 @@ intel_find_shared_dpll(struct intel_crtc *crtc,
/* Only want to check enabled timings first */
if (shared_dpll[i].crtc_mask == 0) {
- unused_pll = pll;
+ if (!unused_pll)
+ unused_pll = pll;
continue;
}
--
2.19.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Pick the first unused PLL once again
2019-01-30 18:13 [PATCH] drm/i915: Pick the first unused PLL once again Ville Syrjala
@ 2019-01-30 19:29 ` Patchwork
2019-01-30 23:03 ` [PATCH] " Paulo Zanoni
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-01-30 19:29 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Pick the first unused PLL once again
URL : https://patchwork.freedesktop.org/series/56002/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5512 -> Patchwork_12095
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56002/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_12095 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#109485]
* igt@kms_flip@basic-flip-vs-modeset:
- fi-skl-6700hq: PASS -> DMESG-WARN [fdo#105998]
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: NOTRUN -> DMESG-FAIL [fdo#102614]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
#### Possible fixes ####
* igt@kms_frontbuffer_tracking@basic:
- {fi-icl-u2}: FAIL [fdo#103167] -> PASS
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
Participating hosts (42 -> 40)
------------------------------
Additional (3): fi-hsw-peppy fi-gdg-551 fi-pnv-d510
Missing (5): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-kbl-r
Build changes
-------------
* Linux: CI_DRM_5512 -> Patchwork_12095
CI_DRM_5512: bf1da2552de642ebce4ea3f91a3259ef819b13ce @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12095: 742faca433618b16035fcdac38854467fd662862 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
742faca43361 drm/i915: Pick the first unused PLL once again
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12095/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Pick the first unused PLL once again
2019-01-30 18:13 [PATCH] drm/i915: Pick the first unused PLL once again Ville Syrjala
2019-01-30 19:29 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-01-30 23:03 ` Paulo Zanoni
2019-01-31 1:24 ` Lucas De Marchi
2019-01-31 1:56 ` ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Paulo Zanoni @ 2019-01-30 23:03 UTC (permalink / raw)
To: Ville Syrjala, intel-gfx; +Cc: Lucas De Marchi
Em qua, 2019-01-30 às 20:13 +0200, Ville Syrjala escreveu:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> commit 5b0bd14dcc6b ("drm/i915/icl: keep track of unused pll while
> looping") inadvertently (I presume) changed the code to pick the
> last unused dpll rather than the first unused one like we did before.
>
> While there should most likely be no harm in changing the order
> let's change back just to avoid a change in the behaviour. At
> least it might reduce the confusion when staring at logs (took
> me a while to figure out why DPLL1 being picked over DPLL0
> when the latter was most definitely available).
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dpll_mgr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> index 8f70838ac7d8..0a42d11c4c33 100644
> --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> @@ -258,7 +258,8 @@ intel_find_shared_dpll(struct intel_crtc *crtc,
>
> /* Only want to check enabled timings first */
> if (shared_dpll[i].crtc_mask == 0) {
> - unused_pll = pll;
> + if (!unused_pll)
> + unused_pll = pll;
> continue;
> }
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Pick the first unused PLL once again
2019-01-30 18:13 [PATCH] drm/i915: Pick the first unused PLL once again Ville Syrjala
2019-01-30 19:29 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-01-30 23:03 ` [PATCH] " Paulo Zanoni
@ 2019-01-31 1:24 ` Lucas De Marchi
2019-01-31 7:49 ` Ville Syrjälä
2019-01-31 1:56 ` ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 1 reply; 6+ messages in thread
From: Lucas De Marchi @ 2019-01-31 1:24 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx, Paulo Zanoni
On Wed, Jan 30, 2019 at 08:13:59PM +0200, Ville Syrjälä wrote:
>From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>commit 5b0bd14dcc6b ("drm/i915/icl: keep track of unused pll while
>looping") inadvertently (I presume) changed the code to pick the
>last unused dpll rather than the first unused one like we did before.
>
>While there should most likely be no harm in changing the order
>let's change back just to avoid a change in the behaviour. At
>least it might reduce the confusion when staring at logs (took
>me a while to figure out why DPLL1 being picked over DPLL0
>when the latter was most definitely available).
I assumed the no harm and simplest approach so I didn't bother
checking if the it was already set. So I'd not say it was
"inadvertently", it was on purpose.
But if it makes life easier to read the logs:
Acked-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
>Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>---
> drivers/gpu/drm/i915/intel_dpll_mgr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
>index 8f70838ac7d8..0a42d11c4c33 100644
>--- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
>+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
>@@ -258,7 +258,8 @@ intel_find_shared_dpll(struct intel_crtc *crtc,
>
> /* Only want to check enabled timings first */
> if (shared_dpll[i].crtc_mask == 0) {
>- unused_pll = pll;
>+ if (!unused_pll)
>+ unused_pll = pll;
> continue;
> }
>
>--
>2.19.2
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/i915: Pick the first unused PLL once again
2019-01-31 1:24 ` Lucas De Marchi
@ 2019-01-31 7:49 ` Ville Syrjälä
0 siblings, 0 replies; 6+ messages in thread
From: Ville Syrjälä @ 2019-01-31 7:49 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx, Paulo Zanoni
On Wed, Jan 30, 2019 at 05:24:07PM -0800, Lucas De Marchi wrote:
> On Wed, Jan 30, 2019 at 08:13:59PM +0200, Ville Syrjälä wrote:
> >From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> >commit 5b0bd14dcc6b ("drm/i915/icl: keep track of unused pll while
> >looping") inadvertently (I presume) changed the code to pick the
> >last unused dpll rather than the first unused one like we did before.
> >
> >While there should most likely be no harm in changing the order
> >let's change back just to avoid a change in the behaviour. At
> >least it might reduce the confusion when staring at logs (took
> >me a while to figure out why DPLL1 being picked over DPLL0
> >when the latter was most definitely available).
>
>
> I assumed the no harm and simplest approach so I didn't bother
> checking if the it was already set. So I'd not say it was
> "inadvertently", it was on purpose.
That would have been good to mention in the commit msg.
>
> But if it makes life easier to read the logs:
>
> Acked-by: Lucas De Marchi <lucas.demarchi@intel.com>
Ta. Pushed.
>
>
> Lucas De Marchi
>
> >
> >Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> >Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >---
> > drivers/gpu/drm/i915/intel_dpll_mgr.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> >diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> >index 8f70838ac7d8..0a42d11c4c33 100644
> >--- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> >+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> >@@ -258,7 +258,8 @@ intel_find_shared_dpll(struct intel_crtc *crtc,
> >
> > /* Only want to check enabled timings first */
> > if (shared_dpll[i].crtc_mask == 0) {
> >- unused_pll = pll;
> >+ if (!unused_pll)
> >+ unused_pll = pll;
> > continue;
> > }
> >
> >--
> >2.19.2
> >
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Pick the first unused PLL once again
2019-01-30 18:13 [PATCH] drm/i915: Pick the first unused PLL once again Ville Syrjala
` (2 preceding siblings ...)
2019-01-31 1:24 ` Lucas De Marchi
@ 2019-01-31 1:56 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-01-31 1:56 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Pick the first unused PLL once again
URL : https://patchwork.freedesktop.org/series/56002/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5512_full -> Patchwork_12095_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12095_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: PASS -> FAIL [fdo#106510] / [fdo#108145]
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-glk: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: PASS -> FAIL [fdo#105454]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-apl: PASS -> FAIL [fdo#102887] / [fdo#105363]
* igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
- shard-apl: PASS -> FAIL [fdo#103166]
#### Possible fixes ####
* igt@gem_eio@reset-stress:
- shard-hsw: INCOMPLETE [fdo#103540] / [fdo#109482] -> PASS
* igt@kms_cursor_crc@cursor-128x128-sliding:
- shard-glk: FAIL [fdo#103232] -> PASS
* igt@kms_flip@2x-flip-vs-modeset:
- shard-hsw: DMESG-WARN [fdo#102614] -> PASS
* igt@kms_flip@flip-vs-expired-vblank:
- shard-kbl: FAIL [fdo#102887] / [fdo#105363] -> PASS
* igt@kms_plane@pixel-format-pipe-a-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +1
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
- shard-kbl: FAIL [fdo#99912] -> PASS
* igt@pm_rc6_residency@rc6-accuracy:
- shard-kbl: {SKIP} [fdo#109271] -> PASS
- shard-snb: {SKIP} [fdo#109271] -> PASS
#### Warnings ####
* igt@i915_suspend@shrink:
- shard-apl: DMESG-WARN [fdo#107886] / [fdo#109244] -> INCOMPLETE [fdo#103927] / [fdo#106886]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107886]: https://bugs.freedesktop.org/show_bug.cgi?id=107886
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109482]: https://bugs.freedesktop.org/show_bug.cgi?id=109482
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* Linux: CI_DRM_5512 -> Patchwork_12095
CI_DRM_5512: bf1da2552de642ebce4ea3f91a3259ef819b13ce @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12095: 742faca433618b16035fcdac38854467fd662862 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12095/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-31 7:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-30 18:13 [PATCH] drm/i915: Pick the first unused PLL once again Ville Syrjala
2019-01-30 19:29 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-01-30 23:03 ` [PATCH] " Paulo Zanoni
2019-01-31 1:24 ` Lucas De Marchi
2019-01-31 7:49 ` Ville Syrjälä
2019-01-31 1:56 ` ✓ Fi.CI.IGT: success for " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox