* [PATCH] drm/i915: Set ->connectors_changed to force HDCP updates
@ 2019-02-01 14:55 Daniel Vetter
2019-02-01 15:07 ` Daniel Vetter
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Daniel Vetter @ 2019-02-01 14:55 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter, Daniel Vetter, Ramalingam C
->mode_changed will be eaten by fastset, which is now enabled by
default on at least some platforms. Once we have modeset-less hdcp, we
need to go back to ->mode_changed (or maybe directly setting
->update_pipe) to avoid the modeset.
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Ramalingam C <ramalingm.c@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
drivers/gpu/drm/i915/intel_hdcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
index ce7ba3a9c000..7da25a7bfccb 100644
--- a/drivers/gpu/drm/i915/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/intel_hdcp.c
@@ -864,7 +864,7 @@ void intel_hdcp_atomic_check(struct drm_connector *connector,
crtc_state = drm_atomic_get_new_crtc_state(new_state->state,
new_state->crtc);
- crtc_state->mode_changed = true;
+ crtc_state->connectors_changed = true;
}
/* Implements Part 3 of the HDCP authorization procedure */
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: Set ->connectors_changed to force HDCP updates
2019-02-01 14:55 [PATCH] drm/i915: Set ->connectors_changed to force HDCP updates Daniel Vetter
@ 2019-02-01 15:07 ` Daniel Vetter
2019-02-01 15:14 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2019-02-01 15:07 UTC (permalink / raw)
To: Intel Graphics Development; +Cc: Daniel Vetter, Daniel Vetter, Ramalingam C
On Fri, Feb 01, 2019 at 03:55:19PM +0100, Daniel Vetter wrote:
> ->mode_changed will be eaten by fastset, which is now enabled by
> default on at least some platforms. Once we have modeset-less hdcp, we
> need to go back to ->mode_changed (or maybe directly setting
> ->update_pipe) to avoid the modeset.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Ramalingam C <ramalingm.c@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
I think this was broken by the patch to enable fastset everywhere:
Fixes: d19f958db23c ("drm/i915: Enable fastset for non-boot modesets.")
But we also don't have any hdcp tests in CI, because the shard runs don't
have hdcp capable outputs :-/
-Daniel
> ---
> drivers/gpu/drm/i915/intel_hdcp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
> index ce7ba3a9c000..7da25a7bfccb 100644
> --- a/drivers/gpu/drm/i915/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/intel_hdcp.c
> @@ -864,7 +864,7 @@ void intel_hdcp_atomic_check(struct drm_connector *connector,
>
> crtc_state = drm_atomic_get_new_crtc_state(new_state->state,
> new_state->crtc);
> - crtc_state->mode_changed = true;
> + crtc_state->connectors_changed = true;
> }
>
> /* Implements Part 3 of the HDCP authorization procedure */
> --
> 2.20.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Set ->connectors_changed to force HDCP updates
2019-02-01 14:55 [PATCH] drm/i915: Set ->connectors_changed to force HDCP updates Daniel Vetter
2019-02-01 15:07 ` Daniel Vetter
@ 2019-02-01 15:14 ` Patchwork
2019-02-01 16:09 ` ✓ Fi.CI.BAT: success " Patchwork
2019-02-01 17:03 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-02-01 15:14 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Set ->connectors_changed to force HDCP updates
URL : https://patchwork.freedesktop.org/series/56089/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e2f23aecb4c1 drm/i915: Set ->connectors_changed to force HDCP updates
-:29: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Set ->connectors_changed to force HDCP updates
2019-02-01 14:55 [PATCH] drm/i915: Set ->connectors_changed to force HDCP updates Daniel Vetter
2019-02-01 15:07 ` Daniel Vetter
2019-02-01 15:14 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2019-02-01 16:09 ` Patchwork
2019-02-01 17:03 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-02-01 16:09 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Set ->connectors_changed to force HDCP updates
URL : https://patchwork.freedesktop.org/series/56089/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5525 -> Patchwork_12119
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56089/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_12119 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7567u: PASS -> WARN [fdo#109380]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#109485]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
Participating hosts (49 -> 43)
------------------------------
Additional (1): fi-cfl-8109u
Missing (7): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-gdg-551 fi-icl-u3 fi-ivb-3520m
Build changes
-------------
* Linux: CI_DRM_5525 -> Patchwork_12119
CI_DRM_5525: 6d10b00ff86e70c4590724262c30ec8388174d38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4803: 973367176b61e81b5ca811620adb0467f6570aec @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12119: e2f23aecb4c1880f1cf45025c6d68bc3513fcbfc @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e2f23aecb4c1 drm/i915: Set ->connectors_changed to force HDCP updates
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12119/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915: Set ->connectors_changed to force HDCP updates
2019-02-01 14:55 [PATCH] drm/i915: Set ->connectors_changed to force HDCP updates Daniel Vetter
` (2 preceding siblings ...)
2019-02-01 16:09 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-02-01 17:03 ` Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2019-02-01 17:03 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Set ->connectors_changed to force HDCP updates
URL : https://patchwork.freedesktop.org/series/56089/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5525_full -> Patchwork_12119_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_12119_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-contexts-10ms:
- shard-glk: PASS -> FAIL [fdo#107799]
* igt@kms_addfb_basic@invalid-set-prop:
- shard-glk: PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-apl: PASS -> FAIL [fdo#103232]
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: PASS -> FAIL [fdo#105363]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: PASS -> FAIL [fdo#103167] +2
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: PASS -> FAIL [fdo#103166] +1
* igt@pm_rpm@gem-execbuf-stress:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
#### Possible fixes ####
* igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
- shard-apl: DMESG-WARN [fdo#107956] -> PASS
* igt@kms_color@pipe-b-legacy-gamma:
- shard-apl: FAIL [fdo#104782] -> PASS
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-size-change:
- shard-apl: FAIL [fdo#103232] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-apl: FAIL [fdo#103167] -> PASS
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: FAIL [fdo#103166] -> PASS +3
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-apl: FAIL [fdo#103166] -> PASS +1
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
#### Warnings ####
* igt@i915_suspend@shrink:
- shard-snb: INCOMPLETE [fdo#105411] / [fdo#106886] -> DMESG-WARN [fdo#109244]
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-hsw: DMESG-WARN [fdo#107956] -> INCOMPLETE [fdo#103540]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
[fdo#107799]: https://bugs.freedesktop.org/show_bug.cgi?id=107799
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#109244]: https://bugs.freedesktop.org/show_bug.cgi?id=109244
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* Linux: CI_DRM_5525 -> Patchwork_12119
CI_DRM_5525: 6d10b00ff86e70c4590724262c30ec8388174d38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4803: 973367176b61e81b5ca811620adb0467f6570aec @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12119: e2f23aecb4c1880f1cf45025c6d68bc3513fcbfc @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12119/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-01 17:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-01 14:55 [PATCH] drm/i915: Set ->connectors_changed to force HDCP updates Daniel Vetter
2019-02-01 15:07 ` Daniel Vetter
2019-02-01 15:14 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-02-01 16:09 ` ✓ Fi.CI.BAT: success " Patchwork
2019-02-01 17:03 ` ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox