[PATCH 1/4] drm/i915: Enable transition watermarks for glk

[PATCH 1/4] drm/i915: Enable transition watermarks for glk

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We are mistakenly skipping transition watermarks on glk. Fix
up the condition for glk, and toss in the w/a name from
the database.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index ed9786241307..5ce60faef28c 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4848,8 +4848,11 @@ static void skl_compute_transition_wm(const struct intel_crtc_state *cstate,
 	const u16 trans_amount = 10; /* This is configurable amount */
 	u16 wm0_sel_res_b, trans_offset_b, res_blocks;
 
-	/* Transition WM are not recommended by HW team for GEN9 */
-	if (INTEL_GEN(dev_priv) <= 9)
+	/*
+	 * WaDisableTWM:skl,kbl,cfl,bxt
+	 * Transition WM are not recommended by HW team for GEN9
+	 */
+	if (IS_GEN9_BC(dev_priv) || IS_BROXTON(dev_priv))
 		return;
 
 	/* Transition WM don't make any sense if ipc is disabled */
-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 2/4] drm/i915: Implement display w/a 1140 for glk/cnl

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Display w/a #1140 tells us we have to program the transition
watermark to the minimum value on glk/cnl. Let's do that.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 5ce60faef28c..d91aec396a4c 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4844,8 +4844,7 @@ static void skl_compute_transition_wm(const struct intel_crtc_state *cstate,
 {
 	struct drm_device *dev = cstate->base.crtc->dev;
 	const struct drm_i915_private *dev_priv = to_i915(dev);
-	u16 trans_min, trans_y_tile_min;
-	const u16 trans_amount = 10; /* This is configurable amount */
+	u16 trans_min, trans_y_tile_min, trans_amount;
 	u16 wm0_sel_res_b, trans_offset_b, res_blocks;
 
 	/*
@@ -4859,9 +4858,16 @@ static void skl_compute_transition_wm(const struct intel_crtc_state *cstate,
 	if (!dev_priv->ipc_enabled)
 		return;
 
-	trans_min = 14;
 	if (INTEL_GEN(dev_priv) >= 11)
 		trans_min = 4;
+	else
+		trans_min = 14;
+
+	/* Display WA #1140: glk,cnl */
+	if (IS_CANNONLAKE(dev_priv) || IS_GEMINILAKE(dev_priv))
+		trans_amount = 0;
+	else
+		trans_amount = 10; /* This is configurable amount */
 
 	trans_offset_b = trans_min + trans_amount;
 
-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 2/4] drm/i915: Implement display w/a 1140 for glk/cnl

[Rodrigo Vivi]

On Thu, Jan 31, 2019 at 09:42:14AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Display w/a #1140 tells us we have to program the transition
> watermark to the minimum value on glk/cnl. Let's do that.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 5ce60faef28c..d91aec396a4c 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4844,8 +4844,7 @@ static void skl_compute_transition_wm(const struct intel_crtc_state *cstate,
>  {
>  	struct drm_device *dev = cstate->base.crtc->dev;
>  	const struct drm_i915_private *dev_priv = to_i915(dev);
> -	u16 trans_min, trans_y_tile_min;
> -	const u16 trans_amount = 10; /* This is configurable amount */
> +	u16 trans_min, trans_y_tile_min, trans_amount;
>  	u16 wm0_sel_res_b, trans_offset_b, res_blocks;
>  
>  	/*
> @@ -4859,9 +4858,16 @@ static void skl_compute_transition_wm(const struct intel_crtc_state *cstate,
>  	if (!dev_priv->ipc_enabled)
>  		return;
>  
> -	trans_min = 14;
>  	if (INTEL_GEN(dev_priv) >= 11)
>  		trans_min = 4;
> +	else
> +		trans_min = 14;
> +
> +	/* Display WA #1140: glk,cnl */
> +	if (IS_CANNONLAKE(dev_priv) || IS_GEMINILAKE(dev_priv))
> +		trans_amount = 0;
> +	else
> +		trans_amount = 10; /* This is configurable amount */
>  
>  	trans_offset_b = trans_min + trans_amount;
>  
> -- 
> 2.19.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 3/4] drm/i915: Document that we implement WaIncreaseLatencyIPCEnabled

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Display w/a #1141 is also known as WaIncreaseLatencyIPCEnabled.
Add that to the comment.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index d91aec396a4c..306e41ccc50e 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4697,7 +4697,10 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *cstate,
 	if (latency == 0)
 		return;
 
-	/* Display WA #1141: kbl,cfl */
+	/*
+	 * WaIncreaseLatencyIPCEnabled: kbl,cfl
+	 * Display WA #1141: kbl,cfl
+	 */
 	if ((IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv) ||
 	    IS_CNL_REVID(dev_priv, CNL_REVID_A0, CNL_REVID_B0)) &&
 	    dev_priv->ipc_enabled)
-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 3/4] drm/i915: Document that we implement WaIncreaseLatencyIPCEnabled

[Rodrigo Vivi]

On Thu, Jan 31, 2019 at 09:42:15AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Display w/a #1141 is also known as WaIncreaseLatencyIPCEnabled.
> Add that to the comment.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index d91aec396a4c..306e41ccc50e 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4697,7 +4697,10 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *cstate,
>  	if (latency == 0)
>  		return;
>  
> -	/* Display WA #1141: kbl,cfl */
> +	/*
> +	 * WaIncreaseLatencyIPCEnabled: kbl,cfl
> +	 * Display WA #1141: kbl,cfl
> +	 */
>  	if ((IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv) ||
>  	    IS_CNL_REVID(dev_priv, CNL_REVID_A0, CNL_REVID_B0)) &&
>  	    dev_priv->ipc_enabled)
> -- 
> 2.19.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 4/4] drm/i915: Drop WaIncreaseLatencyIPCEnabled/1140 for cnl

[Ville Syrjala]

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Drop WaIncreaseLatencyIPCEnabled/Display w/a #1140 for
early cnl steppings. Also switch the kbl/cfl case to check
for IS_GEN9_BC() for brevity. It ends up being the same thing
because IPC is disabled on SKL due to w/a #0477.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 306e41ccc50e..55491e2d5134 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4701,9 +4701,7 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *cstate,
 	 * WaIncreaseLatencyIPCEnabled: kbl,cfl
 	 * Display WA #1141: kbl,cfl
 	 */
-	if ((IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv) ||
-	    IS_CNL_REVID(dev_priv, CNL_REVID_A0, CNL_REVID_B0)) &&
-	    dev_priv->ipc_enabled)
+	if (IS_GEN9_BC(dev_priv) && dev_priv->ipc_enabled)
 		latency += 4;
 
 	if (skl_needs_memory_bw_wa(dev_priv) && wp->x_tiled)
-- 
2.19.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 4/4] drm/i915: Drop WaIncreaseLatencyIPCEnabled/1140 for cnl

[Rodrigo Vivi]

On Thu, Jan 31, 2019 at 09:42:16AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Drop WaIncreaseLatencyIPCEnabled/Display w/a #1140 for
> early cnl steppings. Also switch the kbl/cfl case to check
> for IS_GEN9_BC() for brevity. It ends up being the same thing
> because IPC is disabled on SKL due to w/a #0477.

I think this deserves a commend in the code, otherwise someone
in the future might not notice that and send a patch to replace
9_BC per KBL || CFL...

anyway:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>



> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 306e41ccc50e..55491e2d5134 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4701,9 +4701,7 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *cstate,
>  	 * WaIncreaseLatencyIPCEnabled: kbl,cfl
>  	 * Display WA #1141: kbl,cfl
>  	 */
> -	if ((IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv) ||
> -	    IS_CNL_REVID(dev_priv, CNL_REVID_A0, CNL_REVID_B0)) &&
> -	    dev_priv->ipc_enabled)
> +	if (IS_GEN9_BC(dev_priv) && dev_priv->ipc_enabled)
>  		latency += 4;
>  
>  	if (skl_needs_memory_bw_wa(dev_priv) && wp->x_tiled)
> -- 
> 2.19.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 4/4] drm/i915: Drop WaIncreaseLatencyIPCEnabled/1140 for cnl

[Ville Syrjälä]

On Thu, Jan 31, 2019 at 10:10:47AM -0800, Rodrigo Vivi wrote:
> On Thu, Jan 31, 2019 at 09:42:16AM +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Drop WaIncreaseLatencyIPCEnabled/Display w/a #1140 for
> > early cnl steppings. Also switch the kbl/cfl case to check
> > for IS_GEN9_BC() for brevity. It ends up being the same thing
> > because IPC is disabled on SKL due to w/a #0477.
> 
> I think this deserves a commend in the code, otherwise someone
> in the future might not notice that and send a patch to replace
> 9_BC per KBL || CFL...
> 
> anyway:
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Ta. I just noticed there were some other IS_KBL||IS_CFL cases in the
code as well. So maybe I'll just leave it as is here too.

One thing I don't like is that w/a #0477 is in the device info. I think
I'll want to move that into ipc code to make it less confusing what's
going on.

> 
> 
> 
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_pm.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 306e41ccc50e..55491e2d5134 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -4701,9 +4701,7 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *cstate,
> >  	 * WaIncreaseLatencyIPCEnabled: kbl,cfl
> >  	 * Display WA #1141: kbl,cfl
> >  	 */
> > -	if ((IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv) ||
> > -	    IS_CNL_REVID(dev_priv, CNL_REVID_A0, CNL_REVID_B0)) &&
> > -	    dev_priv->ipc_enabled)
> > +	if (IS_GEN9_BC(dev_priv) && dev_priv->ipc_enabled)
> >  		latency += 4;
> >  
> >  	if (skl_needs_memory_bw_wa(dev_priv) && wp->x_tiled)
> > -- 
> > 2.19.2
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 4/4] drm/i915: Drop WaIncreaseLatencyIPCEnabled/1140 for cnl

[Rodrigo Vivi]

On Mon, Feb 04, 2019 at 07:40:56PM +0200, Ville Syrjälä wrote:
> On Thu, Jan 31, 2019 at 10:10:47AM -0800, Rodrigo Vivi wrote:
> > On Thu, Jan 31, 2019 at 09:42:16AM +0200, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > 
> > > Drop WaIncreaseLatencyIPCEnabled/Display w/a #1140 for
> > > early cnl steppings. Also switch the kbl/cfl case to check
> > > for IS_GEN9_BC() for brevity. It ends up being the same thing
> > > because IPC is disabled on SKL due to w/a #0477.
> > 
> > I think this deserves a commend in the code, otherwise someone
> > in the future might not notice that and send a patch to replace
> > 9_BC per KBL || CFL...
> > 
> > anyway:
> > 
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> 
> Ta. I just noticed there were some other IS_KBL||IS_CFL cases in the
> code as well. So maybe I'll just leave it as is here too.
> 
> One thing I don't like is that w/a #0477 is in the device info. I think
> I'll want to move that into ipc code to make it less confusing what's
> going on.


yeap, I think it makes more sense to have the wa inside ipc code rather
than inside device info. But on the other hand it gets confuse if we
end up reading has_ipc=1 and then we have to go inside ipc to find
out that actually has_ipc is lying :/

> 
> > 
> > 
> > 
> > > 
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/intel_pm.c | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > > index 306e41ccc50e..55491e2d5134 100644
> > > --- a/drivers/gpu/drm/i915/intel_pm.c
> > > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > > @@ -4701,9 +4701,7 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *cstate,
> > >  	 * WaIncreaseLatencyIPCEnabled: kbl,cfl
> > >  	 * Display WA #1141: kbl,cfl
> > >  	 */
> > > -	if ((IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv) ||
> > > -	    IS_CNL_REVID(dev_priv, CNL_REVID_A0, CNL_REVID_B0)) &&
> > > -	    dev_priv->ipc_enabled)
> > > +	if (IS_GEN9_BC(dev_priv) && dev_priv->ipc_enabled)
> > >  		latency += 4;
> > >  
> > >  	if (skl_needs_memory_bw_wa(dev_priv) && wp->x_tiled)
> > > -- 
> > > 2.19.2
> > > 
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Ville Syrjälä
> Intel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 4/4] drm/i915: Drop WaIncreaseLatencyIPCEnabled/1140 for cnl

[Ville Syrjälä]

On Mon, Feb 04, 2019 at 09:49:42AM -0800, Rodrigo Vivi wrote:
> On Mon, Feb 04, 2019 at 07:40:56PM +0200, Ville Syrjälä wrote:
> > On Thu, Jan 31, 2019 at 10:10:47AM -0800, Rodrigo Vivi wrote:
> > > On Thu, Jan 31, 2019 at 09:42:16AM +0200, Ville Syrjala wrote:
> > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > 
> > > > Drop WaIncreaseLatencyIPCEnabled/Display w/a #1140 for
> > > > early cnl steppings. Also switch the kbl/cfl case to check
> > > > for IS_GEN9_BC() for brevity. It ends up being the same thing
> > > > because IPC is disabled on SKL due to w/a #0477.
> > > 
> > > I think this deserves a commend in the code, otherwise someone
> > > in the future might not notice that and send a patch to replace
> > > 9_BC per KBL || CFL...
> > > 
> > > anyway:
> > > 
> > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > 
> > Ta. I just noticed there were some other IS_KBL||IS_CFL cases in the
> > code as well. So maybe I'll just leave it as is here too.
> > 
> > One thing I don't like is that w/a #0477 is in the device info. I think
> > I'll want to move that into ipc code to make it less confusing what's
> > going on.
> 
> 
> yeap, I think it makes more sense to have the wa inside ipc code rather
> than inside device info. But on the other hand it gets confuse if we
> end up reading has_ipc=1 and then we have to go inside ipc to find
> out that actually has_ipc is lying :/

It's not really lying though. The hw has it, we're just not supposed
to use it.

> 
> > 
> > > 
> > > 
> > > 
> > > > 
> > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > ---
> > > >  drivers/gpu/drm/i915/intel_pm.c | 4 +---
> > > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > > > index 306e41ccc50e..55491e2d5134 100644
> > > > --- a/drivers/gpu/drm/i915/intel_pm.c
> > > > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > > > @@ -4701,9 +4701,7 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *cstate,
> > > >  	 * WaIncreaseLatencyIPCEnabled: kbl,cfl
> > > >  	 * Display WA #1141: kbl,cfl
> > > >  	 */
> > > > -	if ((IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv) ||
> > > > -	    IS_CNL_REVID(dev_priv, CNL_REVID_A0, CNL_REVID_B0)) &&
> > > > -	    dev_priv->ipc_enabled)
> > > > +	if (IS_GEN9_BC(dev_priv) && dev_priv->ipc_enabled)
> > > >  		latency += 4;
> > > >  
> > > >  	if (skl_needs_memory_bw_wa(dev_priv) && wp->x_tiled)
> > > > -- 
> > > > 2.19.2
> > > > 
> > > > _______________________________________________
> > > > Intel-gfx mailing list
> > > > Intel-gfx@lists.freedesktop.org
> > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > 
> > -- 
> > Ville Syrjälä
> > Intel
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Enable transition watermarks for glk

[Patchwork]

== Series Details ==

Series: series starting with [1/4] drm/i915: Enable transition watermarks for glk
URL   : https://patchwork.freedesktop.org/series/56025/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5518 -> Patchwork_12103
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/56025/revisions/1/mbox/

Known issues
------------

  Here are the changes found in Patchwork_12103 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       PASS -> INCOMPLETE [fdo#107718]

  
#### Possible fixes ####

  * igt@i915_selftest@live_hangcheck:
    - fi-skl-iommu:       INCOMPLETE [fdo#108602] / [fdo#108744] -> PASS

  * igt@kms_busy@basic-flip-a:
    - fi-kbl-7567u:       {SKIP} [fdo#109271] / [fdo#109278] -> PASS +2

  * igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
    - fi-byt-clapper:     FAIL [fdo#103191] / [fdo#107362] -> PASS

  * igt@pm_rpm@module-reload:
    - fi-skl-6770hq:      FAIL [fdo#108511] -> PASS

  * igt@prime_vgem@basic-fence-flip:
    - fi-gdg-551:         DMESG-FAIL [fdo#103182] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
  [fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
  [fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
  [fdo#108915]: https://bugs.freedesktop.org/show_bug.cgi?id=108915
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278


Participating hosts (43 -> 40)
------------------------------

  Additional (1): fi-icl-y 
  Missing    (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-pnv-d510 


Build changes
-------------

    * Linux: CI_DRM_5518 -> Patchwork_12103

  CI_DRM_5518: 2369fd28d3a46b865f6d4f1d309a4c6b7b4e6d93 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_12103: 70785cf59b0d35fc4508bdb6b2e98c71435fedaf @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

70785cf59b0d drm/i915: Drop WaIncreaseLatencyIPCEnabled/1140 for cnl
5af285080541 drm/i915: Document that we implement WaIncreaseLatencyIPCEnabled
3928cb3661eb drm/i915: Implement display w/a 1140 for glk/cnl
8bc59fd6333d drm/i915: Enable transition watermarks for glk

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12103/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 1/4] drm/i915: Enable transition watermarks for glk

[Rodrigo Vivi]

On Thu, Jan 31, 2019 at 09:42:13AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> We are mistakenly skipping transition watermarks on glk. Fix
> up the condition for glk, and toss in the w/a name from
> the database.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


> ---
>  drivers/gpu/drm/i915/intel_pm.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index ed9786241307..5ce60faef28c 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4848,8 +4848,11 @@ static void skl_compute_transition_wm(const struct intel_crtc_state *cstate,
>  	const u16 trans_amount = 10; /* This is configurable amount */
>  	u16 wm0_sel_res_b, trans_offset_b, res_blocks;
>  
> -	/* Transition WM are not recommended by HW team for GEN9 */
> -	if (INTEL_GEN(dev_priv) <= 9)
> +	/*
> +	 * WaDisableTWM:skl,kbl,cfl,bxt
> +	 * Transition WM are not recommended by HW team for GEN9
> +	 */
> +	if (IS_GEN9_BC(dev_priv) || IS_BROXTON(dev_priv))
>  		return;
>  
>  	/* Transition WM don't make any sense if ipc is disabled */
> -- 
> 2.19.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915: Enable transition watermarks for glk

[Patchwork]

== Series Details ==

Series: series starting with [1/4] drm/i915: Enable transition watermarks for glk
URL   : https://patchwork.freedesktop.org/series/56025/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5518_full -> Patchwork_12103_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_12103_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_12103_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_12103_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy:
    - shard-glk:          PASS -> FAIL +2

  
Known issues
------------

  Here are the changes found in Patchwork_12103_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_schedule@pi-ringfull-render:
    - shard-apl:          NOTRUN -> FAIL [fdo#103158]

  * igt@gem_ppgtt@blt-vs-render-ctx0:
    - shard-glk:          PASS -> DMESG-WARN [fdo#105763] / [fdo#106538]

  * igt@kms_cursor_crc@cursor-64x64-suspend:
    - shard-glk:          PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]

  * igt@kms_plane_multiple@atomic-pipe-a-tiling-none:
    - shard-apl:          NOTRUN -> FAIL [fdo#103166]

  * igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
    - shard-apl:          PASS -> FAIL [fdo#103166]
    - shard-glk:          PASS -> FAIL [fdo#103166]

  
#### Possible fixes ####

  * igt@gem_eio@reset-stress:
    - shard-hsw:          INCOMPLETE [fdo#103540] / [fdo#109482] -> PASS

  * igt@gem_workarounds@suspend-resume:
    - shard-kbl:          INCOMPLETE [fdo#103665] -> PASS

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
    - shard-apl:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_color@pipe-b-ctm-max:
    - shard-apl:          FAIL [fdo#108147] -> PASS

  * igt@kms_cursor_crc@cursor-256x256-suspend:
    - shard-hsw:          INCOMPLETE [fdo#103540] -> PASS

  * igt@kms_flip@flip-vs-blocking-wf-vblank:
    - shard-snb:          DMESG-WARN [fdo#107469] -> PASS

  * igt@kms_flip@flip-vs-panning-interruptible:
    - shard-hsw:          DMESG-WARN [fdo#102614] -> PASS

  * igt@kms_plane@plane-position-covered-pipe-c-planes:
    - shard-apl:          FAIL [fdo#103166] -> PASS +1

  * igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
    - shard-glk:          FAIL [fdo#103166] -> PASS

  * igt@kms_setmode@basic:
    - shard-apl:          FAIL [fdo#99912] -> PASS

  * igt@pm_rc6_residency@rc6-accuracy:
    - shard-snb:          {SKIP} [fdo#109271] -> PASS

  * igt@sw_sync@sync_busy_fork:
    - shard-snb:          INCOMPLETE [fdo#105411] -> PASS +1

  
#### Warnings ####

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
    - shard-snb:          {SKIP} [fdo#109271] / [fdo#109278] -> DMESG-WARN [fdo#107956]

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
  [fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109482]: https://bugs.freedesktop.org/show_bug.cgi?id=109482
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (7 -> 5)
------------------------------

  Missing    (2): shard-skl shard-iclb 


Build changes
-------------

    * Linux: CI_DRM_5518 -> Patchwork_12103

  CI_DRM_5518: 2369fd28d3a46b865f6d4f1d309a4c6b7b4e6d93 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_12103: 70785cf59b0d35fc4508bdb6b2e98c71435fedaf @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12103/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915: Enable transition watermarks for glk

[Ville Syrjälä]

On Thu, Jan 31, 2019 at 08:07:35PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [1/4] drm/i915: Enable transition watermarks for glk
> URL   : https://patchwork.freedesktop.org/series/56025/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_5518_full -> Patchwork_12103_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_12103_full absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_12103_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_12103_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy:
>     - shard-glk:          PASS -> FAIL +2

(kms_cursor_legacy:2984) CRITICAL: Test assertion failure function two_screens_cursor_vs_flip, file ../tests/kms_cursor_legacy.c:1207:
(kms_cursor_legacy:2984) CRITICAL: Failed assertion: shared[child] > vrefresh[child]*target[child] / 2
(kms_cursor_legacy:2984) CRITICAL: completed 382 cursor updated in a period of 30 flips, we expect to complete approximately 3840 updates, with the threshold set at 1920
Subtest 2x-cursor-vs-flip-legacy failed.

2x-cursor-vs-flip-atomic and 2x-long-cursor-vs-flip-atomic also flipped
to fail but that fact is not reflected here for some reason.

Anyways, this failure doesn't seem directly related to watermarks.

> 
>   
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_12103_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_exec_schedule@pi-ringfull-render:
>     - shard-apl:          NOTRUN -> FAIL [fdo#103158]
> 
>   * igt@gem_ppgtt@blt-vs-render-ctx0:
>     - shard-glk:          PASS -> DMESG-WARN [fdo#105763] / [fdo#106538]
> 
>   * igt@kms_cursor_crc@cursor-64x64-suspend:
>     - shard-glk:          PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]
> 
>   * igt@kms_plane_multiple@atomic-pipe-a-tiling-none:
>     - shard-apl:          NOTRUN -> FAIL [fdo#103166]
> 
>   * igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
>     - shard-apl:          PASS -> FAIL [fdo#103166]
>     - shard-glk:          PASS -> FAIL [fdo#103166]
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_eio@reset-stress:
>     - shard-hsw:          INCOMPLETE [fdo#103540] / [fdo#109482] -> PASS
> 
>   * igt@gem_workarounds@suspend-resume:
>     - shard-kbl:          INCOMPLETE [fdo#103665] -> PASS
> 
>   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
>     - shard-apl:          DMESG-WARN [fdo#107956] -> PASS
> 
>   * igt@kms_color@pipe-b-ctm-max:
>     - shard-apl:          FAIL [fdo#108147] -> PASS
> 
>   * igt@kms_cursor_crc@cursor-256x256-suspend:
>     - shard-hsw:          INCOMPLETE [fdo#103540] -> PASS
> 
>   * igt@kms_flip@flip-vs-blocking-wf-vblank:
>     - shard-snb:          DMESG-WARN [fdo#107469] -> PASS
> 
>   * igt@kms_flip@flip-vs-panning-interruptible:
>     - shard-hsw:          DMESG-WARN [fdo#102614] -> PASS
> 
>   * igt@kms_plane@plane-position-covered-pipe-c-planes:
>     - shard-apl:          FAIL [fdo#103166] -> PASS +1
> 
>   * igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
>     - shard-glk:          FAIL [fdo#103166] -> PASS
> 
>   * igt@kms_setmode@basic:
>     - shard-apl:          FAIL [fdo#99912] -> PASS
> 
>   * igt@pm_rc6_residency@rc6-accuracy:
>     - shard-snb:          {SKIP} [fdo#109271] -> PASS
> 
>   * igt@sw_sync@sync_busy_fork:
>     - shard-snb:          INCOMPLETE [fdo#105411] -> PASS +1
> 
>   
> #### Warnings ####
> 
>   * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
>     - shard-snb:          {SKIP} [fdo#109271] / [fdo#109278] -> DMESG-WARN [fdo#107956]
> 
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
>   [fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
>   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
>   [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
>   [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
>   [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
>   [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
>   [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
>   [fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
>   [fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
>   [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
>   [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
>   [fdo#109482]: https://bugs.freedesktop.org/show_bug.cgi?id=109482
>   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
>   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> 
> 
> Participating hosts (7 -> 5)
> ------------------------------
> 
>   Missing    (2): shard-skl shard-iclb 
> 
> 
> Build changes
> -------------
> 
>     * Linux: CI_DRM_5518 -> Patchwork_12103
> 
>   CI_DRM_5518: 2369fd28d3a46b865f6d4f1d309a4c6b7b4e6d93 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_12103: 70785cf59b0d35fc4508bdb6b2e98c71435fedaf @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12103/

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915: Enable transition watermarks for glk

[Petri Latvala]

On Mon, Feb 04, 2019 at 07:38:33PM +0200, Ville Syrjälä wrote:
> On Thu, Jan 31, 2019 at 08:07:35PM -0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: series starting with [1/4] drm/i915: Enable transition watermarks for glk
> > URL   : https://patchwork.freedesktop.org/series/56025/
> > State : failure
> > 
> > == Summary ==
> > 
> > CI Bug Log - changes from CI_DRM_5518_full -> Patchwork_12103_full
> > ====================================================
> > 
> > Summary
> > -------
> > 
> >   **FAILURE**
> > 
> >   Serious unknown changes coming with Patchwork_12103_full absolutely need to be
> >   verified manually.
> >   
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in Patchwork_12103_full, please notify your bug team to allow them
> >   to document this new failure mode, which will reduce false positives in CI.
> > 
> >   
> > 
> > Possible new issues
> > -------------------
> > 
> >   Here are the unknown changes that may have been introduced in Patchwork_12103_full:
> > 
> > ### IGT changes ###
> > 
> > #### Possible regressions ####
> > 
> >   * igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy:
> >     - shard-glk:          PASS -> FAIL +2
> 
> (kms_cursor_legacy:2984) CRITICAL: Test assertion failure function two_screens_cursor_vs_flip, file ../tests/kms_cursor_legacy.c:1207:
> (kms_cursor_legacy:2984) CRITICAL: Failed assertion: shared[child] > vrefresh[child]*target[child] / 2
> (kms_cursor_legacy:2984) CRITICAL: completed 382 cursor updated in a period of 30 flips, we expect to complete approximately 3840 updates, with the threshold set at 1920
> Subtest 2x-cursor-vs-flip-legacy failed.
> 
> 2x-cursor-vs-flip-atomic and 2x-long-cursor-vs-flip-atomic also flipped
> to fail but that fact is not reflected here for some reason.


It is, but obscurely. It's the "+2". Two more of the similar failure.



-- 
Petri Latvala
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Enable transition watermarks for glk (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [1/4] drm/i915: Enable transition watermarks for glk (rev2)
URL   : https://patchwork.freedesktop.org/series/56025/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5544 -> Patchwork_12146
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_12146 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_12146, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/56025/revisions/2/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_12146:

### IGT changes ###

#### Possible regressions ####

  * igt@core_auth@basic-auth:
    - fi-blb-e6850:       PASS -> DMESG-WARN

  
Known issues
------------

  Here are the changes found in Patchwork_12146 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_busy@basic-flip-a:
    - fi-gdg-551:         PASS -> FAIL [fdo#103182]

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       PASS -> FAIL [fdo#109485]

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-byt-clapper:     PASS -> FAIL [fdo#103191] / [fdo#107362]

  
#### Possible fixes ####

  * igt@i915_selftest@live_hangcheck:
    - {fi-icl-y}:         INCOMPLETE [fdo#108569] -> PASS

  * igt@kms_chamelium@common-hpd-after-suspend:
    - fi-kbl-7567u:       WARN [fdo#109380] -> PASS

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
    - fi-byt-clapper:     FAIL [fdo#103191] / [fdo#107362] -> PASS

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
    - fi-kbl-7567u:       {SKIP} [fdo#109271] -> PASS +33

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380
  [fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485


Participating hosts (49 -> 44)
------------------------------

  Additional (1): fi-byt-j1900 
  Missing    (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-skl-iommu 


Build changes
-------------

    * Linux: CI_DRM_5544 -> Patchwork_12146

  CI_DRM_5544: ed04149dce7c00619b3e4623bf809e6bacd659ce @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4810: 1f89f1a04016cef20aa278ad05508cafdb9976f5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_12146: 126bae1036cdbac075e2c8bf874a8b4e9afea22c @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

126bae1036cd drm/i915: Drop WaIncreaseLatencyIPCEnabled/1140 for cnl
582ea25c1e78 drm/i915: Document that we implement WaIncreaseLatencyIPCEnabled
2fdb2049a404 drm/i915: Implement display w/a 1140 for glk/cnl
235b741a10e7 drm/i915: Enable transition watermarks for glk

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12146/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx