public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/i915: Fix atomic state leak when resetting HDMI link
@ 2019-02-27 23:04 José Roberto de Souza
  2019-02-27 23:04 ` [PATCH 2/2] drm/i915: Don't manually add connectors and planes state José Roberto de Souza
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: José Roberto de Souza @ 2019-02-27 23:04 UTC (permalink / raw)
  To: intel-gfx

Atomic state needs to be put even if the commit was successful.

Fixes: dba14b27dd3c ("drm/i915: Reinitialize sink scrambling/TMDS clock ratio on HPD")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Lyude Paul <lyude@redhat.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index d918be927fc2..34dd5823398a 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -3984,12 +3984,7 @@ static int modeset_pipe(struct drm_crtc *crtc,
 		goto out;
 
 	ret = drm_atomic_commit(state);
-	if (ret)
-		goto out;
-
-	return 0;
-
- out:
+out:
 	drm_atomic_state_put(state);
 
 	return ret;
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2019-03-02  8:25 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-27 23:04 [PATCH 1/2] drm/i915: Fix atomic state leak when resetting HDMI link José Roberto de Souza
2019-02-27 23:04 ` [PATCH 2/2] drm/i915: Don't manually add connectors and planes state José Roberto de Souza
2019-02-28 11:37   ` Ville Syrjälä
2019-02-28 21:27     ` Souza, Jose
2019-03-01 13:43       ` Ville Syrjälä
2019-03-02  0:25         ` Souza, Jose
2019-02-28  0:19 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link Patchwork
2019-02-28  0:40   ` Souza, Jose
2019-02-28 11:35 ` [PATCH 1/2] " Ville Syrjälä
2019-03-02  0:47 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix atomic state leak when resetting HDMI link (rev2) Patchwork
2019-03-02  8:25 ` ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox