From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 00/10] drm/i915: Clean up intel_color_check()
Date: Tue, 19 Mar 2019 18:31:34 +0200 [thread overview]
Message-ID: <20190319163134.GF3888@intel.com> (raw)
In-Reply-To: <87d0mmg798.fsf@intel.com>
On Tue, Mar 19, 2019 at 06:26:43PM +0200, Jani Nikula wrote:
> On Mon, 18 Mar 2019, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > intel_color_check() is mess. Blow it up into clean platform sized
> > chunks. Also eliminate some redundant linear LUT loads as a result.
>
> How about a "load lut" -> "write lut" rename while at it? I think
> "loading" is confusing.
Should probably rename it something a bit more generic since vlv/chv
load the csc there too. .color_update_postvbl() or something, though
I'm not sure that shade really makes me happy either.
>
> BR,
> Jani.
>
>
> >
> > Ville Syrjälä (10):
> > drm/i915: Extract check_luts()
> > drm/i915: Turn intel_color_check() into a vfunc
> > drm/i915: Extract i9xx_color_check()
> > drm/i915: Extract chv_color_check()
> > drm/i915: Extract icl_color_check()
> > drm/i915: Extract glk_color_check()
> > drm/i915: Extract bdw_color_check()
> > drm/i915: Extract ilk_color_check()
> > drm/i915: Drop the pointless linear legacy LUT load on CHV
> > drm/i915: Skip the linear degamma LUT load on ICL+
> >
> > drivers/gpu/drm/i915/i915_drv.h | 1 +
> > drivers/gpu/drm/i915/intel_color.c | 384 +++++++++++++++++++++--------
> > 2 files changed, 286 insertions(+), 99 deletions(-)
>
> --
> Jani Nikula, Intel Open Source Graphics Center
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-03-19 16:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 16:13 [PATCH 00/10] drm/i915: Clean up intel_color_check() Ville Syrjala
2019-03-18 16:13 ` [PATCH 01/10] drm/i915: Extract check_luts() Ville Syrjala
2019-03-19 16:24 ` Jani Nikula
2019-03-20 14:46 ` Ville Syrjälä
2019-03-19 21:59 ` Matt Roper
2019-03-20 14:41 ` Ville Syrjälä
2019-03-20 15:14 ` Matt Roper
2019-03-20 15:31 ` Ville Syrjälä
2019-03-20 22:48 ` Matt Roper
2019-03-18 16:13 ` [PATCH 02/10] drm/i915: Turn intel_color_check() into a vfunc Ville Syrjala
2019-03-19 21:59 ` Matt Roper
2019-03-18 16:13 ` [PATCH 03/10] drm/i915: Extract i9xx_color_check() Ville Syrjala
2019-03-19 22:00 ` Matt Roper
2019-03-18 16:13 ` [PATCH 04/10] drm/i915: Extract chv_color_check() Ville Syrjala
2019-03-19 22:00 ` Matt Roper
2019-03-20 14:43 ` Ville Syrjälä
2019-03-18 16:13 ` [PATCH 05/10] drm/i915: Extract icl_color_check() Ville Syrjala
2019-03-18 16:13 ` [PATCH 06/10] drm/i915: Extract glk_color_check() Ville Syrjala
2019-03-18 16:13 ` [PATCH 07/10] drm/i915: Extract bdw_color_check() Ville Syrjala
2019-03-20 22:49 ` Matt Roper
2019-03-18 16:13 ` [PATCH 08/10] drm/i915: Extract ilk_color_check() Ville Syrjala
2019-03-20 22:49 ` Matt Roper
2019-03-21 10:05 ` Ville Syrjälä
2019-03-18 16:13 ` [PATCH 09/10] drm/i915: Drop the pointless linear legacy LUT load on CHV Ville Syrjala
2019-03-20 22:50 ` Matt Roper
2019-03-18 16:13 ` [PATCH 10/10] drm/i915: Skip the linear degamma LUT load on ICL+ Ville Syrjala
2019-03-20 22:50 ` Matt Roper
2019-03-18 20:15 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Clean up intel_color_check() Patchwork
2019-03-18 20:41 ` ✓ Fi.CI.BAT: success " Patchwork
2019-03-19 9:01 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-03-19 16:26 ` [PATCH 00/10] " Jani Nikula
2019-03-19 16:31 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319163134.GF3888@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox