Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/guc: Retry GuC load for all load failures
@ 2019-03-29 20:36 Robert M. Fosha
  2019-03-29 20:43 ` Chris Wilson
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Robert M. Fosha @ 2019-03-29 20:36 UTC (permalink / raw)
  To: intel-gfx

Currently we only retry to load GuC firmware if the load fails due to
timeout. On Gen9 GuC loading may fail for different reasons, not just
hang/timeout. Direction from the GuC team is to retry for all cases of
GuC load failure on Gen9, not just for timeout.

Signed-off-by: Robert M. Fosha <robert.m.fosha@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
 drivers/gpu/drm/i915/intel_uc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index 2d360d53757f..25b80ffe71ad 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -375,7 +375,7 @@ int intel_uc_init_hw(struct drm_i915_private *i915)
 
 		intel_guc_init_params(guc);
 		ret = intel_guc_fw_upload(guc);
-		if (ret == 0 || ret != -ETIMEDOUT)
+		if (ret == 0)
 			break;
 
 		DRM_DEBUG_DRIVER("GuC fw load failed: %d; will reset and "
-- 
2.21.0.5.gaeb582a983

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-03-30  8:07 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-29 20:36 [PATCH] drm/i915/guc: Retry GuC load for all load failures Robert M. Fosha
2019-03-29 20:43 ` Chris Wilson
2019-03-29 21:25 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-03-29 23:17 ` [PATCH v2] " Robert M. Fosha
2019-03-30  8:01   ` Chris Wilson
2019-03-30  8:07     ` Chris Wilson
2019-03-30  0:54 ` ✓ Fi.CI.BAT: success for drm/i915/guc: Retry GuC load for all load failures (rev2) Patchwork
2019-03-30  1:57 ` ✓ Fi.CI.IGT: success for drm/i915/guc: Retry GuC load for all load failures Patchwork
2019-03-30  3:59 ` ✓ Fi.CI.IGT: success for drm/i915/guc: Retry GuC load for all load failures (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox