From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>,
"Runyan, Arthur J" <arthur.j.runyan@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: Re: [PATCH 1/7] drm/i915/psr: Update PSR2 SU corruption workaround comment
Date: Wed, 3 Apr 2019 17:22:01 -0700 [thread overview]
Message-ID: <20190404002201.GA25758@intel.com> (raw)
In-Reply-To: <20190403233539.31828-1-jose.souza@intel.com>
On Wed, Apr 03, 2019 at 04:35:33PM -0700, José Roberto de Souza wrote:
> Turn out it is not a DMC bug it is actually a HW one, so this
> workaround will be needed for current gens, lets update the comment
> and remove the FIXME.
Do we have a Wa #number for this? p[art of workaround page
or just part of programming sequence?
>
> BSpec: 7723
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/intel_psr.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
> index ec874d802d48..c80bb3003a7d 100644
> --- a/drivers/gpu/drm/i915/intel_psr.c
> +++ b/drivers/gpu/drm/i915/intel_psr.c
> @@ -531,10 +531,8 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)
> val |= EDP_PSR2_TP2_TIME_2500us;
>
> /*
> - * FIXME: There is probably a issue in DMC firmwares(icl_dmc_ver1_07.bin
> - * and kbl_dmc_ver1_04.bin at least) that causes PSR2 SU to fail after
> - * exiting DC6 if EDP_PSR_TP1_TP3_SEL is kept in PSR_CTL, so for now
> - * lets workaround the issue by cleaning PSR_CTL before enable PSR2.
> + * PSR2 HW is incorrectly using EDP_PSR_TP1_TP3_SEL and BSpec is
> + * recommending keep this bit unset while PSR2 is enabled.
> */
> I915_WRITE(EDP_PSR_CTL, 0);
>
> --
> 2.21.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-04-04 0:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 23:35 [PATCH 1/7] drm/i915/psr: Update PSR2 SU corruption workaround comment José Roberto de Souza
2019-04-03 23:35 ` [PATCH 2/7] drm/i915: Remove unused VLV/CHV PSR registers José Roberto de Souza
2019-04-04 0:22 ` Rodrigo Vivi
2019-04-03 23:35 ` [PATCH 3/7] drm/i915/psr: Initialize PSR mutex even when sink is not reliable José Roberto de Souza
2019-04-04 0:27 ` Rodrigo Vivi
2019-04-04 19:25 ` Souza, Jose
2019-04-04 23:22 ` Rodrigo Vivi
2019-04-05 0:22 ` Dhinakaran Pandiyan
2019-04-05 0:32 ` Souza, Jose
2019-04-05 0:45 ` Dhinakaran Pandiyan
2019-04-03 23:35 ` [PATCH 4/7] drm/i915/psr: Do not enable PSR in interlaced mode for all GENs José Roberto de Souza
2019-04-04 0:29 ` Rodrigo Vivi
2019-04-04 22:02 ` Dhinakaran Pandiyan
2019-04-03 23:35 ` [PATCH 5/7] drm/i915/bdw+: Move misc display IRQ handling to it own function José Roberto de Souza
2019-04-05 0:38 ` Dhinakaran Pandiyan
2019-04-03 23:35 ` [PATCH 6/7] drm/i915/psr: Remove partial PSR support on multiple transcoders José Roberto de Souza
2019-04-04 0:31 ` Rodrigo Vivi
2019-04-04 19:40 ` Souza, Jose
2019-04-04 21:20 ` Rodrigo Vivi
2019-04-04 21:41 ` Pandiyan, Dhinakaran
2019-04-04 21:51 ` Rodrigo Vivi
2019-04-04 22:19 ` Souza, Jose
2019-04-04 22:06 ` Dhinakaran Pandiyan
2019-04-03 23:35 ` [PATCH 7/7] drm/i915: Make PSR registers relative to transcoders José Roberto de Souza
2019-04-06 0:55 ` Dhinakaran Pandiyan
2019-04-06 1:05 ` Souza, Jose
2019-04-03 23:43 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915/psr: Update PSR2 SU corruption workaround comment Patchwork
2019-04-03 23:46 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-04-04 0:04 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-04-04 0:22 ` Rodrigo Vivi [this message]
2019-04-04 0:39 ` [PATCH 1/7] " Runyan, Arthur J
2019-04-04 0:51 ` Rodrigo Vivi
2019-04-04 20:37 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915/psr: Update PSR2 SU corruption workaround comment (rev2) Patchwork
2019-04-04 20:40 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-04-04 21:01 ` ✓ Fi.CI.BAT: success " Patchwork
2019-04-05 16:44 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404002201.GA25758@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=arthur.j.runyan@intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox