* [PATCH] drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config
@ 2019-04-06 7:48 Chris Wilson
2019-04-06 8:03 ` Chris Wilson
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Chris Wilson @ 2019-04-06 7:48 UTC (permalink / raw)
To: intel-gfx
Haswell+ require many power wells to probe the current HW display state.
Under the wakeref tracking scheme, we want each owner to store and
release the wakeref they use, so we can identify callers that have
leaked their wakeref. For hsw_get_pipe_config, this means we have to
keep the array of all wakerefs as it current acquires its power wells
piecemeal and releases them en masse.
By tracking these wakerefs, we should be able to eliminate a lot of
noise from the runtime-pm debug logs.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_display.c | 42 ++++++++++++++++++++--------
1 file changed, 30 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 7ecfb7d98839..0cca7bb8fa3f 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -9754,7 +9754,8 @@ static void haswell_get_ddi_pll(struct drm_i915_private *dev_priv,
static bool hsw_get_transcoder_state(struct intel_crtc *crtc,
struct intel_crtc_state *pipe_config,
- u64 *power_domain_mask)
+ u64 *power_domain_mask,
+ intel_wakeref_t *wakeref)
{
struct drm_device *dev = crtc->base.dev;
struct drm_i915_private *dev_priv = to_i915(dev);
@@ -9827,10 +9828,13 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc,
enabled_panel_transcoders != BIT(TRANSCODER_EDP));
power_domain = POWER_DOMAIN_TRANSCODER(pipe_config->cpu_transcoder);
- if (!intel_display_power_get_if_enabled(dev_priv, power_domain))
+ WARN_ON(*power_domain_mask & BIT_ULL(power_domain));
+
+ wakeref[power_domain] =
+ intel_display_power_get_if_enabled(dev_priv, power_domain);
+ if (!wakeref[power_domain])
return false;
- WARN_ON(*power_domain_mask & BIT_ULL(power_domain));
*power_domain_mask |= BIT_ULL(power_domain);
tmp = I915_READ(PIPECONF(pipe_config->cpu_transcoder));
@@ -9840,7 +9844,8 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc,
static bool bxt_get_dsi_transcoder_state(struct intel_crtc *crtc,
struct intel_crtc_state *pipe_config,
- u64 *power_domain_mask)
+ u64 *power_domain_mask,
+ intel_wakeref_t *wakeref)
{
struct drm_device *dev = crtc->base.dev;
struct drm_i915_private *dev_priv = to_i915(dev);
@@ -9856,10 +9861,14 @@ static bool bxt_get_dsi_transcoder_state(struct intel_crtc *crtc,
cpu_transcoder = TRANSCODER_DSI_C;
power_domain = POWER_DOMAIN_TRANSCODER(cpu_transcoder);
- if (!intel_display_power_get_if_enabled(dev_priv, power_domain))
+ WARN_ON(*power_domain_mask & BIT_ULL(power_domain));
+
+ wakeref[power_domain] =
+ intel_display_power_get_if_enabled(dev_priv,
+ power_domain);
+ if (!wakeref[power_domain])
continue;
- WARN_ON(*power_domain_mask & BIT_ULL(power_domain));
*power_domain_mask |= BIT_ULL(power_domain);
/*
@@ -9939,22 +9948,27 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc,
{
struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
enum intel_display_power_domain power_domain;
+ intel_wakeref_t wakeref[POWER_DOMAIN_NUM];
u64 power_domain_mask;
bool active;
intel_crtc_init_scalers(crtc, pipe_config);
power_domain = POWER_DOMAIN_PIPE(crtc->pipe);
- if (!intel_display_power_get_if_enabled(dev_priv, power_domain))
+ wakeref[power_domain] =
+ intel_display_power_get_if_enabled(dev_priv, power_domain);
+ if (!wakeref[power_domain])
return false;
power_domain_mask = BIT_ULL(power_domain);
pipe_config->shared_dpll = NULL;
- active = hsw_get_transcoder_state(crtc, pipe_config, &power_domain_mask);
+ active = hsw_get_transcoder_state(crtc, pipe_config,
+ &power_domain_mask, wakeref);
if (IS_GEN9_LP(dev_priv) &&
- bxt_get_dsi_transcoder_state(crtc, pipe_config, &power_domain_mask)) {
+ bxt_get_dsi_transcoder_state(crtc, pipe_config,
+ &power_domain_mask, wakeref)) {
WARN_ON(active);
active = true;
}
@@ -9988,8 +10002,11 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc,
}
power_domain = POWER_DOMAIN_PIPE_PANEL_FITTER(crtc->pipe);
- if (intel_display_power_get_if_enabled(dev_priv, power_domain)) {
- WARN_ON(power_domain_mask & BIT_ULL(power_domain));
+ WARN_ON(power_domain_mask & BIT_ULL(power_domain));
+
+ wakeref[power_domain] =
+ intel_display_power_get_if_enabled(dev_priv, power_domain);
+ if (wakeref[power_domain]) {
power_domain_mask |= BIT_ULL(power_domain);
if (INTEL_GEN(dev_priv) >= 9)
@@ -10021,7 +10038,8 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc,
out:
for_each_power_domain(power_domain, power_domain_mask)
- intel_display_power_put_unchecked(dev_priv, power_domain);
+ intel_display_power_put(dev_priv,
+ power_domain, wakeref[power_domain]);
return active;
}
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config 2019-04-06 7:48 [PATCH] drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config Chris Wilson @ 2019-04-06 8:03 ` Chris Wilson 2019-04-07 13:34 ` Imre Deak 2019-04-06 8:18 ` ✓ Fi.CI.BAT: success for " Patchwork ` (2 subsequent siblings) 3 siblings, 1 reply; 6+ messages in thread From: Chris Wilson @ 2019-04-06 8:03 UTC (permalink / raw) To: intel-gfx Haswell+ require many power wells to probe the current HW display state. Under the wakeref tracking scheme, we want each owner to store and release the wakeref they use, so we can identify callers that have leaked their wakeref. For hsw_get_pipe_config, this means we have to keep the array of all wakerefs as it current acquires its power wells piecemeal and releases them en masse. By tracking these wakerefs, we should be able to eliminate a lot of noise from the runtime-pm debug logs. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> --- Help gcc by using explicit temporaries for the predicates. --- drivers/gpu/drm/i915/intel_display.c | 46 ++++++++++++++++++++-------- 1 file changed, 33 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 7ecfb7d98839..d765769d6bab 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9754,7 +9754,8 @@ static void haswell_get_ddi_pll(struct drm_i915_private *dev_priv, static bool hsw_get_transcoder_state(struct intel_crtc *crtc, struct intel_crtc_state *pipe_config, - u64 *power_domain_mask) + u64 *power_domain_mask, + intel_wakeref_t *wakerefs) { struct drm_device *dev = crtc->base.dev; struct drm_i915_private *dev_priv = to_i915(dev); @@ -9762,6 +9763,7 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc, unsigned long panel_transcoder_mask = 0; unsigned long enabled_panel_transcoders = 0; enum transcoder panel_transcoder; + intel_wakeref_t wf; u32 tmp; if (INTEL_GEN(dev_priv) >= 11) @@ -9827,10 +9829,13 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc, enabled_panel_transcoders != BIT(TRANSCODER_EDP)); power_domain = POWER_DOMAIN_TRANSCODER(pipe_config->cpu_transcoder); - if (!intel_display_power_get_if_enabled(dev_priv, power_domain)) + WARN_ON(*power_domain_mask & BIT_ULL(power_domain)); + + wf = intel_display_power_get_if_enabled(dev_priv, power_domain); + if (!wf) return false; - WARN_ON(*power_domain_mask & BIT_ULL(power_domain)); + wakerefs[power_domain] = wf; *power_domain_mask |= BIT_ULL(power_domain); tmp = I915_READ(PIPECONF(pipe_config->cpu_transcoder)); @@ -9840,13 +9845,15 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc, static bool bxt_get_dsi_transcoder_state(struct intel_crtc *crtc, struct intel_crtc_state *pipe_config, - u64 *power_domain_mask) + u64 *power_domain_mask, + intel_wakeref_t *wakerefs) { struct drm_device *dev = crtc->base.dev; struct drm_i915_private *dev_priv = to_i915(dev); enum intel_display_power_domain power_domain; - enum port port; enum transcoder cpu_transcoder; + intel_wakeref_t wf; + enum port port; u32 tmp; for_each_port_masked(port, BIT(PORT_A) | BIT(PORT_C)) { @@ -9856,10 +9863,13 @@ static bool bxt_get_dsi_transcoder_state(struct intel_crtc *crtc, cpu_transcoder = TRANSCODER_DSI_C; power_domain = POWER_DOMAIN_TRANSCODER(cpu_transcoder); - if (!intel_display_power_get_if_enabled(dev_priv, power_domain)) + WARN_ON(*power_domain_mask & BIT_ULL(power_domain)); + + wf = intel_display_power_get_if_enabled(dev_priv, power_domain); + if (!wf) continue; - WARN_ON(*power_domain_mask & BIT_ULL(power_domain)); + wakerefs[power_domain] = wf; *power_domain_mask |= BIT_ULL(power_domain); /* @@ -9938,6 +9948,7 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, struct intel_crtc_state *pipe_config) { struct drm_i915_private *dev_priv = to_i915(crtc->base.dev); + intel_wakeref_t wakerefs[POWER_DOMAIN_NUM], wf; enum intel_display_power_domain power_domain; u64 power_domain_mask; bool active; @@ -9945,16 +9956,21 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, intel_crtc_init_scalers(crtc, pipe_config); power_domain = POWER_DOMAIN_PIPE(crtc->pipe); - if (!intel_display_power_get_if_enabled(dev_priv, power_domain)) + wf = intel_display_power_get_if_enabled(dev_priv, power_domain); + if (!wf) return false; + + wakerefs[power_domain] = wf; power_domain_mask = BIT_ULL(power_domain); pipe_config->shared_dpll = NULL; - active = hsw_get_transcoder_state(crtc, pipe_config, &power_domain_mask); + active = hsw_get_transcoder_state(crtc, pipe_config, + &power_domain_mask, wakerefs); if (IS_GEN9_LP(dev_priv) && - bxt_get_dsi_transcoder_state(crtc, pipe_config, &power_domain_mask)) { + bxt_get_dsi_transcoder_state(crtc, pipe_config, + &power_domain_mask, wakerefs)) { WARN_ON(active); active = true; } @@ -9988,8 +10004,11 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, } power_domain = POWER_DOMAIN_PIPE_PANEL_FITTER(crtc->pipe); - if (intel_display_power_get_if_enabled(dev_priv, power_domain)) { - WARN_ON(power_domain_mask & BIT_ULL(power_domain)); + WARN_ON(power_domain_mask & BIT_ULL(power_domain)); + + wf = intel_display_power_get_if_enabled(dev_priv, power_domain); + if (wf) { + wakerefs[power_domain] = wf; power_domain_mask |= BIT_ULL(power_domain); if (INTEL_GEN(dev_priv) >= 9) @@ -10021,7 +10040,8 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, out: for_each_power_domain(power_domain, power_domain_mask) - intel_display_power_put_unchecked(dev_priv, power_domain); + intel_display_power_put(dev_priv, + power_domain, wakerefs[power_domain]); return active; } -- 2.20.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config 2019-04-06 8:03 ` Chris Wilson @ 2019-04-07 13:34 ` Imre Deak 0 siblings, 0 replies; 6+ messages in thread From: Imre Deak @ 2019-04-07 13:34 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx On Sat, Apr 06, 2019 at 09:03:41AM +0100, Chris Wilson wrote: > Haswell+ require many power wells to probe the current HW display state. > Under the wakeref tracking scheme, we want each owner to store and > release the wakeref they use, so we can identify callers that have > leaked their wakeref. For hsw_get_pipe_config, this means we have to > keep the array of all wakerefs as it current acquires its power wells > piecemeal and releases them en masse. > > By tracking these wakerefs, we should be able to eliminate a lot of > noise from the runtime-pm debug logs. > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Looks ok, thanks for fixing it: Reviewed-by: Imre Deak <imre.deak@intel.com> > --- > Help gcc by using explicit temporaries for the predicates. > --- > drivers/gpu/drm/i915/intel_display.c | 46 ++++++++++++++++++++-------- > 1 file changed, 33 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 7ecfb7d98839..d765769d6bab 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -9754,7 +9754,8 @@ static void haswell_get_ddi_pll(struct drm_i915_private *dev_priv, > > static bool hsw_get_transcoder_state(struct intel_crtc *crtc, > struct intel_crtc_state *pipe_config, > - u64 *power_domain_mask) > + u64 *power_domain_mask, > + intel_wakeref_t *wakerefs) > { > struct drm_device *dev = crtc->base.dev; > struct drm_i915_private *dev_priv = to_i915(dev); > @@ -9762,6 +9763,7 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc, > unsigned long panel_transcoder_mask = 0; > unsigned long enabled_panel_transcoders = 0; > enum transcoder panel_transcoder; > + intel_wakeref_t wf; > u32 tmp; > > if (INTEL_GEN(dev_priv) >= 11) > @@ -9827,10 +9829,13 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc, > enabled_panel_transcoders != BIT(TRANSCODER_EDP)); > > power_domain = POWER_DOMAIN_TRANSCODER(pipe_config->cpu_transcoder); > - if (!intel_display_power_get_if_enabled(dev_priv, power_domain)) > + WARN_ON(*power_domain_mask & BIT_ULL(power_domain)); > + > + wf = intel_display_power_get_if_enabled(dev_priv, power_domain); > + if (!wf) > return false; > > - WARN_ON(*power_domain_mask & BIT_ULL(power_domain)); > + wakerefs[power_domain] = wf; > *power_domain_mask |= BIT_ULL(power_domain); > > tmp = I915_READ(PIPECONF(pipe_config->cpu_transcoder)); > @@ -9840,13 +9845,15 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc, > > static bool bxt_get_dsi_transcoder_state(struct intel_crtc *crtc, > struct intel_crtc_state *pipe_config, > - u64 *power_domain_mask) > + u64 *power_domain_mask, > + intel_wakeref_t *wakerefs) > { > struct drm_device *dev = crtc->base.dev; > struct drm_i915_private *dev_priv = to_i915(dev); > enum intel_display_power_domain power_domain; > - enum port port; > enum transcoder cpu_transcoder; > + intel_wakeref_t wf; > + enum port port; > u32 tmp; > > for_each_port_masked(port, BIT(PORT_A) | BIT(PORT_C)) { > @@ -9856,10 +9863,13 @@ static bool bxt_get_dsi_transcoder_state(struct intel_crtc *crtc, > cpu_transcoder = TRANSCODER_DSI_C; > > power_domain = POWER_DOMAIN_TRANSCODER(cpu_transcoder); > - if (!intel_display_power_get_if_enabled(dev_priv, power_domain)) > + WARN_ON(*power_domain_mask & BIT_ULL(power_domain)); > + > + wf = intel_display_power_get_if_enabled(dev_priv, power_domain); > + if (!wf) > continue; > > - WARN_ON(*power_domain_mask & BIT_ULL(power_domain)); > + wakerefs[power_domain] = wf; > *power_domain_mask |= BIT_ULL(power_domain); > > /* > @@ -9938,6 +9948,7 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, > struct intel_crtc_state *pipe_config) > { > struct drm_i915_private *dev_priv = to_i915(crtc->base.dev); > + intel_wakeref_t wakerefs[POWER_DOMAIN_NUM], wf; > enum intel_display_power_domain power_domain; > u64 power_domain_mask; > bool active; > @@ -9945,16 +9956,21 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, > intel_crtc_init_scalers(crtc, pipe_config); > > power_domain = POWER_DOMAIN_PIPE(crtc->pipe); > - if (!intel_display_power_get_if_enabled(dev_priv, power_domain)) > + wf = intel_display_power_get_if_enabled(dev_priv, power_domain); > + if (!wf) > return false; > + > + wakerefs[power_domain] = wf; > power_domain_mask = BIT_ULL(power_domain); > > pipe_config->shared_dpll = NULL; > > - active = hsw_get_transcoder_state(crtc, pipe_config, &power_domain_mask); > + active = hsw_get_transcoder_state(crtc, pipe_config, > + &power_domain_mask, wakerefs); > > if (IS_GEN9_LP(dev_priv) && > - bxt_get_dsi_transcoder_state(crtc, pipe_config, &power_domain_mask)) { > + bxt_get_dsi_transcoder_state(crtc, pipe_config, > + &power_domain_mask, wakerefs)) { > WARN_ON(active); > active = true; > } > @@ -9988,8 +10004,11 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, > } > > power_domain = POWER_DOMAIN_PIPE_PANEL_FITTER(crtc->pipe); > - if (intel_display_power_get_if_enabled(dev_priv, power_domain)) { > - WARN_ON(power_domain_mask & BIT_ULL(power_domain)); > + WARN_ON(power_domain_mask & BIT_ULL(power_domain)); > + > + wf = intel_display_power_get_if_enabled(dev_priv, power_domain); > + if (wf) { > + wakerefs[power_domain] = wf; > power_domain_mask |= BIT_ULL(power_domain); > > if (INTEL_GEN(dev_priv) >= 9) > @@ -10021,7 +10040,8 @@ static bool haswell_get_pipe_config(struct intel_crtc *crtc, > > out: > for_each_power_domain(power_domain, power_domain_mask) > - intel_display_power_put_unchecked(dev_priv, power_domain); > + intel_display_power_put(dev_priv, > + power_domain, wakerefs[power_domain]); > > return active; > } > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config 2019-04-06 7:48 [PATCH] drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config Chris Wilson 2019-04-06 8:03 ` Chris Wilson @ 2019-04-06 8:18 ` Patchwork 2019-04-06 8:45 ` ✓ Fi.CI.BAT: success for drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config (rev2) Patchwork 2019-04-07 4:41 ` ✗ Fi.CI.IGT: failure " Patchwork 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2019-04-06 8:18 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config URL : https://patchwork.freedesktop.org/series/59089/ State : success == Summary == CI Bug Log - changes from CI_DRM_5882 -> Patchwork_12716 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/59089/revisions/1/mbox/ Known issues ------------ Here are the changes found in Patchwork_12716 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live_uncore: - fi-ivb-3770: PASS -> DMESG-FAIL [fdo#110210] * igt@kms_busy@basic-flip-c: - fi-skl-6770hq: PASS -> SKIP [fdo#109271] / [fdo#109278] +2 * igt@kms_flip@basic-flip-vs-dpms: - fi-skl-6770hq: PASS -> SKIP [fdo#109271] +33 * igt@kms_frontbuffer_tracking@basic: - fi-byt-clapper: PASS -> FAIL [fdo#103167] * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence: - fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362] #### Possible fixes #### * igt@i915_pm_rpm@module-reload: - fi-skl-6770hq: DMESG-WARN [fdo#105541] -> PASS * igt@kms_pipe_crc_basic@read-crc-pipe-b: - fi-byt-clapper: FAIL [fdo#107362] -> PASS [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541 [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210 Participating hosts (50 -> 40) ------------------------------ Missing (10): fi-kbl-soraka fi-ilk-m540 fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-icl-u3 fi-pnv-d510 fi-bdw-samus fi-skl-6600u fi-kbl-r Build changes ------------- * Linux: CI_DRM_5882 -> Patchwork_12716 CI_DRM_5882: 012535789c9c890854cd1e0fb926f44931a82a63 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4932: 08cf63a8fac11e3594b57580331fb319241a0d69 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12716: 1a308c8aae043a4ab3e28f58e38d6beb95a887a0 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 1a308c8aae04 drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12716/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config (rev2) 2019-04-06 7:48 [PATCH] drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config Chris Wilson 2019-04-06 8:03 ` Chris Wilson 2019-04-06 8:18 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2019-04-06 8:45 ` Patchwork 2019-04-07 4:41 ` ✗ Fi.CI.IGT: failure " Patchwork 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2019-04-06 8:45 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config (rev2) URL : https://patchwork.freedesktop.org/series/59089/ State : success == Summary == CI Bug Log - changes from CI_DRM_5882 -> Patchwork_12717 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/59089/revisions/2/mbox/ Known issues ------------ Here are the changes found in Patchwork_12717 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live_execlists: - fi-apl-guc: PASS -> INCOMPLETE [fdo#103927] / [fdo#109720] * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: - fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718] #### Possible fixes #### * igt@i915_pm_rpm@module-reload: - fi-skl-6770hq: DMESG-WARN [fdo#105541] -> PASS - {fi-icl-u3}: DMESG-WARN [fdo#107724] -> PASS * igt@kms_pipe_crc_basic@hang-read-crc-pipe-a: - fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS * igt@kms_pipe_crc_basic@read-crc-pipe-b: - fi-byt-clapper: FAIL [fdo#107362] -> PASS #### Warnings #### * igt@i915_selftest@live_contexts: - fi-icl-y: DMESG-FAIL [fdo#108569] -> INCOMPLETE [fdo#108569] {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541 [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569 [fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720 Participating hosts (50 -> 43) ------------------------------ Missing (7): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-bdw-samus fi-skl-6600u fi-kbl-r Build changes ------------- * Linux: CI_DRM_5882 -> Patchwork_12717 CI_DRM_5882: 012535789c9c890854cd1e0fb926f44931a82a63 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4932: 08cf63a8fac11e3594b57580331fb319241a0d69 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12717: 498e18c8f088dae6508a0f946933002eb46f121c @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 498e18c8f088 drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12717/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config (rev2) 2019-04-06 7:48 [PATCH] drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config Chris Wilson ` (2 preceding siblings ...) 2019-04-06 8:45 ` ✓ Fi.CI.BAT: success for drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config (rev2) Patchwork @ 2019-04-07 4:41 ` Patchwork 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2019-04-07 4:41 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config (rev2) URL : https://patchwork.freedesktop.org/series/59089/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5882_full -> Patchwork_12717_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_12717_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_12717_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_12717_full: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_reloc@basic-cpu-wc-active: - shard-iclb: PASS -> INCOMPLETE Known issues ------------ Here are the changes found in Patchwork_12717_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_parallel@bsd1: - shard-skl: NOTRUN -> SKIP [fdo#109271] +91 * igt@gem_exec_schedule@preempt-bsd2: - shard-apl: NOTRUN -> SKIP [fdo#109271] +3 * igt@gem_tiled_swapping@non-threaded: - shard-iclb: PASS -> FAIL [fdo#108686] * igt@i915_pm_rpm@pm-caching: - shard-skl: PASS -> INCOMPLETE [fdo#107807] * igt@i915_selftest@live_workarounds: - shard-iclb: PASS -> DMESG-FAIL [fdo#108954] * igt@kms_atomic_transition@3x-modeset-transitions: - shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +12 * igt@kms_atomic_transition@3x-modeset-transitions-fencing: - shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] * igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels: - shard-kbl: NOTRUN -> SKIP [fdo#109271] +19 * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c: - shard-skl: NOTRUN -> DMESG-WARN [fdo#110222] +1 * igt@kms_cursor_legacy@cursor-vs-flip-varying-size: - shard-iclb: PASS -> FAIL [fdo#103355] +1 * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible: - shard-glk: PASS -> FAIL [fdo#100368] * igt@kms_flip_tiling@flip-to-x-tiled: - shard-iclb: PASS -> FAIL [fdo#108134] * igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw: - shard-iclb: PASS -> FAIL [fdo#103167] +4 * igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-render: - shard-skl: PASS -> FAIL [fdo#105682] * igt@kms_frontbuffer_tracking@psr-1p-primscrn-shrfb-pgflip-blt: - shard-snb: NOTRUN -> SKIP [fdo#109271] +77 * igt@kms_frontbuffer_tracking@psr-rgb565-draw-render: - shard-iclb: PASS -> FAIL [fdo#109247] +9 * igt@kms_lease@setcrtc_implicit_plane: - shard-skl: NOTRUN -> FAIL [fdo#110281] * igt@kms_panel_fitting@legacy: - shard-skl: NOTRUN -> FAIL [fdo#105456] * igt@kms_plane_alpha_blend@pipe-c-alpha-7efc: - shard-skl: NOTRUN -> FAIL [fdo#107815] / [fdo#108145] * igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb: - shard-skl: NOTRUN -> FAIL [fdo#108145] * igt@kms_plane_scaling@2x-scaler-multi-pipe: - shard-skl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +4 * igt@kms_psr@cursor_blt: - shard-iclb: PASS -> FAIL [fdo#107383] / [fdo#110215] +3 * igt@kms_psr@psr2_cursor_plane_onoff: - shard-iclb: PASS -> SKIP [fdo#109441] +3 #### Possible fixes #### * igt@gem_tiled_pread_pwrite: - shard-iclb: TIMEOUT [fdo#109673] -> PASS * igt@i915_pm_rpm@system-suspend-modeset: - shard-iclb: FAIL [fdo#103375] -> PASS +1 * igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic: - shard-glk: FAIL [fdo#106509] / [fdo#107409] -> PASS * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible: - shard-glk: FAIL [fdo#105363] -> PASS * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt: - shard-iclb: FAIL [fdo#103167] -> PASS +7 * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite: - shard-iclb: FAIL [fdo#109247] -> PASS +15 * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes: - shard-skl: INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: FAIL [fdo#107815] -> PASS +1 * igt@kms_psr2_su@frontbuffer: - shard-iclb: SKIP [fdo#109642] -> PASS +1 * igt@kms_psr@sprite_mmap_cpu: - shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> PASS +1 * igt@kms_vblank@pipe-c-ts-continuation-suspend: - shard-iclb: FAIL [fdo#104894] -> PASS [fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355 [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105456]: https://bugs.freedesktop.org/show_bug.cgi?id=105456 [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682 [fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509 [fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383 [fdo#107409]: https://bugs.freedesktop.org/show_bug.cgi?id=107409 [fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773 [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807 [fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815 [fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686 [fdo#108954]: https://bugs.freedesktop.org/show_bug.cgi?id=108954 [fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673 [fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215 [fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222 [fdo#110281]: https://bugs.freedesktop.org/show_bug.cgi?id=110281 Participating hosts (10 -> 9) ------------------------------ Missing (1): shard-hsw Build changes ------------- * Linux: CI_DRM_5882 -> Patchwork_12717 CI_DRM_5882: 012535789c9c890854cd1e0fb926f44931a82a63 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4932: 08cf63a8fac11e3594b57580331fb319241a0d69 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_12717: 498e18c8f088dae6508a0f946933002eb46f121c @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12717/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-07 13:35 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-04-06 7:48 [PATCH] drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config Chris Wilson 2019-04-06 8:03 ` Chris Wilson 2019-04-07 13:34 ` Imre Deak 2019-04-06 8:18 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-04-06 8:45 ` ✓ Fi.CI.BAT: success for drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config (rev2) Patchwork 2019-04-07 4:41 ` ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox