[PATCH] drm/i915: Tune down WARN about incorrect VBT TC legacy flag

[PATCH] drm/i915: Tune down WARN about incorrect VBT TC legacy flag

[Imre Deak]

Looks like VBT contains again the wrong information about a port's TypeC
legacy vs. DP-alt/TBT-alt type. There is no further issues after we
notice this and fix it up, so tune down the WARN to be a a DRM_ERROR.

This also avoids CI tainting the kernel and stopping the test run.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110578
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 4e7b8d29d733..07fa2670a677 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -5230,9 +5230,12 @@ static bool icl_tc_port_connected(struct drm_i915_private *dev_priv,
 	 * WARN if we got a legacy port HPD, but VBT didn't mark the port as
 	 * legacy. Treat the port as legacy from now on.
 	 */
-	if (WARN_ON(!intel_dig_port->tc_legacy_port &&
-		    I915_READ(SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port)))
+	if (!intel_dig_port->tc_legacy_port &&
+	    I915_READ(SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port)) {
+		DRM_ERROR("VBT incorrectly claims port %c is not TypeC legacy\n",
+			  port_name(port));
 		intel_dig_port->tc_legacy_port = true;
+	}
 	is_legacy = intel_dig_port->tc_legacy_port;
 
 	/*
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Tune down WARN about incorrect VBT TC legacy flag

[Jani Nikula]

On Thu, 02 May 2019, Imre Deak <imre.deak@intel.com> wrote:
> Looks like VBT contains again the wrong information about a port's TypeC
> legacy vs. DP-alt/TBT-alt type. There is no further issues after we
> notice this and fix it up, so tune down the WARN to be a a DRM_ERROR.
>
> This also avoids CI tainting the kernel and stopping the test run.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110578
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 4e7b8d29d733..07fa2670a677 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -5230,9 +5230,12 @@ static bool icl_tc_port_connected(struct drm_i915_private *dev_priv,
>  	 * WARN if we got a legacy port HPD, but VBT didn't mark the port as
           ^^^^

With the comment fixed,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

>  	 * legacy. Treat the port as legacy from now on.
>  	 */
> -	if (WARN_ON(!intel_dig_port->tc_legacy_port &&
> -		    I915_READ(SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port)))
> +	if (!intel_dig_port->tc_legacy_port &&
> +	    I915_READ(SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port)) {
> +		DRM_ERROR("VBT incorrectly claims port %c is not TypeC legacy\n",
> +			  port_name(port));
>  		intel_dig_port->tc_legacy_port = true;
> +	}
>  	is_legacy = intel_dig_port->tc_legacy_port;
>  
>  	/*

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Tune down WARN about incorrect VBT TC legacy flag

[Daniel Vetter]

On Thu, May 02, 2019 at 03:09:00PM +0300, Jani Nikula wrote:
> On Thu, 02 May 2019, Imre Deak <imre.deak@intel.com> wrote:
> > Looks like VBT contains again the wrong information about a port's TypeC
> > legacy vs. DP-alt/TBT-alt type. There is no further issues after we
> > notice this and fix it up, so tune down the WARN to be a a DRM_ERROR.
> >
> > This also avoids CI tainting the kernel and stopping the test run.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110578
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_dp.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> > index 4e7b8d29d733..07fa2670a677 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -5230,9 +5230,12 @@ static bool icl_tc_port_connected(struct drm_i915_private *dev_priv,
> >  	 * WARN if we got a legacy port HPD, but VBT didn't mark the port as
>            ^^^^
> 
> With the comment fixed,
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> 
> >  	 * legacy. Treat the port as legacy from now on.
> >  	 */
> > -	if (WARN_ON(!intel_dig_port->tc_legacy_port &&
> > -		    I915_READ(SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port)))
> > +	if (!intel_dig_port->tc_legacy_port &&
> > +	    I915_READ(SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port)) {
> > +		DRM_ERROR("VBT incorrectly claims port %c is not TypeC legacy\n",
> > +			  port_name(port));
> >  		intel_dig_port->tc_legacy_port = true;

DRM_ERRROR still causes CI failures (e.g. module reload, where I guess
this ends up in the logs).

If we really can fully fix it up I think a DRM_INFO is the right level.
-Daniel

> > +	}
> >  	is_legacy = intel_dig_port->tc_legacy_port;
> >  
> >  	/*
> 
> -- 
> Jani Nikula, Intel Open Source Graphics Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Tune down WARN about incorrect VBT TC legacy flag

[Imre Deak]

On Fri, May 03, 2019 at 02:35:59PM +0200, Daniel Vetter wrote:
> On Thu, May 02, 2019 at 03:09:00PM +0300, Jani Nikula wrote:
> > On Thu, 02 May 2019, Imre Deak <imre.deak@intel.com> wrote:
> > > Looks like VBT contains again the wrong information about a port's TypeC
> > > legacy vs. DP-alt/TBT-alt type. There is no further issues after we
> > > notice this and fix it up, so tune down the WARN to be a a DRM_ERROR.
> > >
> > > This also avoids CI tainting the kernel and stopping the test run.
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110578
> > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/intel_dp.c | 7 +++++--
> > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> > > index 4e7b8d29d733..07fa2670a677 100644
> > > --- a/drivers/gpu/drm/i915/intel_dp.c
> > > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > > @@ -5230,9 +5230,12 @@ static bool icl_tc_port_connected(struct drm_i915_private *dev_priv,
> > >  	 * WARN if we got a legacy port HPD, but VBT didn't mark the port as
> >            ^^^^
> > 
> > With the comment fixed,
> > 
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> > 
> > >  	 * legacy. Treat the port as legacy from now on.
> > >  	 */
> > > -	if (WARN_ON(!intel_dig_port->tc_legacy_port &&
> > > -		    I915_READ(SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port)))
> > > +	if (!intel_dig_port->tc_legacy_port &&
> > > +	    I915_READ(SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port)) {
> > > +		DRM_ERROR("VBT incorrectly claims port %c is not TypeC legacy\n",
> > > +			  port_name(port));
> > >  		intel_dig_port->tc_legacy_port = true;
> 
> DRM_ERRROR still causes CI failures (e.g. module reload, where I guess
> this ends up in the logs).
> 
> If we really can fully fix it up I think a DRM_INFO is the right level.

We have to wait until the first legacy HPD interrupt, whereas with a
correct VBT info we would configure the correct mode right from the
start. So I think it's still a problem and we should be complaining
about it louder even later.

I filed an HSD for it and would hope it would be treated as a real issue
by that team, not just yet another HSD. For that reason too I'd go
keeping it as an error, not to lose it from the radar.

Meanwhile, the error message is very specific (about this particular port
and scenario) so I think CI filtering could cope with marking it as a
known issue, until we get it fixed in VBT.

> -Daniel
> 
> > > +	}
> > >  	is_legacy = intel_dig_port->tc_legacy_port;
> > >  
> > >  	/*
> > 
> > -- 
> > Jani Nikula, Intel Open Source Graphics Center
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: Tune down WARN about incorrect VBT TC legacy flag

[Patchwork]

== Series Details ==

Series: drm/i915: Tune down WARN about incorrect VBT TC legacy flag
URL   : https://patchwork.freedesktop.org/series/60197/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6026 -> Patchwork_12938
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/60197/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_12938:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@kms_chamelium@dp-crc-fast:
    - {fi-icl-u2}:        NOTRUN -> [DMESG-WARN][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/fi-icl-u2/igt@kms_chamelium@dp-crc-fast.html

  * igt@runner@aborted:
    - {fi-icl-u2}:        [FAIL][2] ([fdo#110578] / [k.org#202973]) -> [FAIL][3]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/fi-icl-u2/igt@runner@aborted.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/fi-icl-u2/igt@runner@aborted.html

  
Known issues
------------

  Here are the changes found in Patchwork_12938 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@amdgpu/amd_basic@userptr:
    - fi-kbl-8809g:       [DMESG-WARN][4] ([fdo#108965]) -> [PASS][5]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/fi-kbl-8809g/igt@amdgpu/amd_basic@userptr.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
  [fdo#110578]: https://bugs.freedesktop.org/show_bug.cgi?id=110578
  [k.org#202973]: https://bugzilla.kernel.org/show_bug.cgi?id=202973


Participating hosts (52 -> 46)
------------------------------

  Additional (1): fi-byt-j1900 
  Missing    (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * Linux: CI_DRM_6026 -> Patchwork_12938

  CI_DRM_6026: 2d2d8d3b9d8896c99c88307a881120885afd2ddb @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4972: f052e49a43cc9704ea5f240df15dd9d3dfed68ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_12938: 51220cd2ff773c282dd02aef53c605577f5ce73d @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

51220cd2ff77 drm/i915: Tune down WARN about incorrect VBT TC legacy flag

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for drm/i915: Tune down WARN about incorrect VBT TC legacy flag

[Patchwork]

== Series Details ==

Series: drm/i915: Tune down WARN about incorrect VBT TC legacy flag
URL   : https://patchwork.freedesktop.org/series/60197/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6026_full -> Patchwork_12938_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Known issues
------------

  Here are the changes found in Patchwork_12938_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_eio@reset-stress:
    - shard-skl:          [PASS][1] -> [FAIL][2] ([fdo#105957])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-skl8/igt@gem_eio@reset-stress.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-skl8/igt@gem_eio@reset-stress.html

  * igt@gem_mmap_gtt@forked-basic-small-copy:
    - shard-hsw:          [PASS][3] -> [INCOMPLETE][4] ([fdo#103540] / [fdo#110581])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-hsw2/igt@gem_mmap_gtt@forked-basic-small-copy.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-hsw1/igt@gem_mmap_gtt@forked-basic-small-copy.html

  * igt@i915_pm_rpm@i2c:
    - shard-iclb:         [PASS][5] -> [DMESG-WARN][6] ([fdo#109982])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-iclb5/igt@i915_pm_rpm@i2c.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-iclb2/igt@i915_pm_rpm@i2c.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         [PASS][7] -> [FAIL][8] ([fdo#103167]) +3 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu:
    - shard-skl:          [PASS][9] -> [FAIL][10] ([fdo#103167] / [fdo#110379])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-skl8/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-skl8/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-apl:          [PASS][11] -> [DMESG-WARN][12] ([fdo#108566]) +1 similar issue
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-apl8/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-apl6/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
    - shard-skl:          [PASS][13] -> [FAIL][14] ([fdo#108145])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html

  * igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
    - shard-glk:          [PASS][15] -> [SKIP][16] ([fdo#109271] / [fdo#109278]) +1 similar issue
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-glk9/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-glk4/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [PASS][17] -> [SKIP][18] ([fdo#109441]) +2 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-iclb1/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@kms_sysfs_edid_timing:
    - shard-iclb:         [PASS][19] -> [FAIL][20] ([fdo#100047])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-iclb1/igt@kms_sysfs_edid_timing.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-iclb3/igt@kms_sysfs_edid_timing.html

  
#### Possible fixes ####

  * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
    - shard-glk:          [FAIL][21] ([fdo#104873]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-glk9/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html

  * igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled:
    - shard-skl:          [FAIL][23] ([fdo#103184] / [fdo#103232]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-skl8/igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-skl8/igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled.html

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-glk:          [FAIL][25] ([fdo#102887] / [fdo#105363]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-glk5/igt@kms_flip@flip-vs-expired-vblank.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-glk8/igt@kms_flip@flip-vs-expired-vblank.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
    - shard-iclb:         [FAIL][27] ([fdo#103167]) -> [PASS][28] +2 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
    - shard-apl:          [DMESG-WARN][29] ([fdo#108566]) -> [PASS][30] +6 similar issues
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html

  * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
    - shard-skl:          [FAIL][31] ([fdo#108145] / [fdo#110403]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html

  * igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
    - shard-glk:          [SKIP][33] ([fdo#109271] / [fdo#109278]) -> [PASS][34] +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-glk7/igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-glk9/igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping.html

  * igt@kms_psr@psr2_cursor_plane_onoff:
    - shard-iclb:         [SKIP][35] ([fdo#109441]) -> [PASS][36] +3 similar issues
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-iclb7/igt@kms_psr@psr2_cursor_plane_onoff.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html

  * igt@kms_setmode@basic:
    - shard-apl:          [FAIL][37] ([fdo#99912]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-apl2/igt@kms_setmode@basic.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-apl4/igt@kms_setmode@basic.html

  
  [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105957]: https://bugs.freedesktop.org/show_bug.cgi?id=105957
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
  [fdo#110379]: https://bugs.freedesktop.org/show_bug.cgi?id=110379
  [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
  [fdo#110581]: https://bugs.freedesktop.org/show_bug.cgi?id=110581
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_6026 -> Patchwork_12938

  CI_DRM_6026: 2d2d8d3b9d8896c99c88307a881120885afd2ddb @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4972: f052e49a43cc9704ea5f240df15dd9d3dfed68ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_12938: 51220cd2ff773c282dd02aef53c605577f5ce73d @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✓ Fi.CI.IGT: success for drm/i915: Tune down WARN about incorrect VBT TC legacy flag

[Imre Deak]

On Thu, May 02, 2019 at 04:57:24PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Tune down WARN about incorrect VBT TC legacy flag
> URL   : https://patchwork.freedesktop.org/series/60197/
> State : success

Thanks for the review, pushed to -dinq with the code comment updated.

> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_6026_full -> Patchwork_12938_full
> ====================================================
> 
> Summary
> -------
> 
>   **SUCCESS**
> 
>   No regressions found.
> 
>   
> 
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_12938_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_eio@reset-stress:
>     - shard-skl:          [PASS][1] -> [FAIL][2] ([fdo#105957])
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-skl8/igt@gem_eio@reset-stress.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-skl8/igt@gem_eio@reset-stress.html
> 
>   * igt@gem_mmap_gtt@forked-basic-small-copy:
>     - shard-hsw:          [PASS][3] -> [INCOMPLETE][4] ([fdo#103540] / [fdo#110581])
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-hsw2/igt@gem_mmap_gtt@forked-basic-small-copy.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-hsw1/igt@gem_mmap_gtt@forked-basic-small-copy.html
> 
>   * igt@i915_pm_rpm@i2c:
>     - shard-iclb:         [PASS][5] -> [DMESG-WARN][6] ([fdo#109982])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-iclb5/igt@i915_pm_rpm@i2c.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-iclb2/igt@i915_pm_rpm@i2c.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
>     - shard-iclb:         [PASS][7] -> [FAIL][8] ([fdo#103167]) +3 similar issues
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu:
>     - shard-skl:          [PASS][9] -> [FAIL][10] ([fdo#103167] / [fdo#110379])
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-skl8/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-skl8/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-suspend:
>     - shard-apl:          [PASS][11] -> [DMESG-WARN][12] ([fdo#108566]) +1 similar issue
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-apl8/igt@kms_frontbuffer_tracking@fbc-suspend.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-apl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
> 
>   * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
>     - shard-skl:          [PASS][13] -> [FAIL][14] ([fdo#108145])
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
> 
>   * igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
>     - shard-glk:          [PASS][15] -> [SKIP][16] ([fdo#109271] / [fdo#109278]) +1 similar issue
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-glk9/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-glk4/igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping.html
> 
>   * igt@kms_psr@psr2_sprite_plane_move:
>     - shard-iclb:         [PASS][17] -> [SKIP][18] ([fdo#109441]) +2 similar issues
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-iclb1/igt@kms_psr@psr2_sprite_plane_move.html
> 
>   * igt@kms_sysfs_edid_timing:
>     - shard-iclb:         [PASS][19] -> [FAIL][20] ([fdo#100047])
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-iclb1/igt@kms_sysfs_edid_timing.html
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-iclb3/igt@kms_sysfs_edid_timing.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
>     - shard-glk:          [FAIL][21] ([fdo#104873]) -> [PASS][22]
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-glk9/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
> 
>   * igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled:
>     - shard-skl:          [FAIL][23] ([fdo#103184] / [fdo#103232]) -> [PASS][24]
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-skl8/igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled.html
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-skl8/igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank:
>     - shard-glk:          [FAIL][25] ([fdo#102887] / [fdo#105363]) -> [PASS][26]
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-glk5/igt@kms_flip@flip-vs-expired-vblank.html
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-glk8/igt@kms_flip@flip-vs-expired-vblank.html
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
>     - shard-iclb:         [FAIL][27] ([fdo#103167]) -> [PASS][28] +2 similar issues
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
> 
>   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
>     - shard-apl:          [DMESG-WARN][29] ([fdo#108566]) -> [PASS][30] +6 similar issues
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-apl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
> 
>   * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
>     - shard-skl:          [FAIL][31] ([fdo#108145] / [fdo#110403]) -> [PASS][32]
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
> 
>   * igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
>     - shard-glk:          [SKIP][33] ([fdo#109271] / [fdo#109278]) -> [PASS][34] +1 similar issue
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-glk7/igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping.html
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-glk9/igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping.html
> 
>   * igt@kms_psr@psr2_cursor_plane_onoff:
>     - shard-iclb:         [SKIP][35] ([fdo#109441]) -> [PASS][36] +3 similar issues
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-iclb7/igt@kms_psr@psr2_cursor_plane_onoff.html
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html
> 
>   * igt@kms_setmode@basic:
>     - shard-apl:          [FAIL][37] ([fdo#99912]) -> [PASS][38]
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6026/shard-apl2/igt@kms_setmode@basic.html
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/shard-apl4/igt@kms_setmode@basic.html
> 
>   
>   [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
>   [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
>   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
>   [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
>   [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
>   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>   [fdo#105957]: https://bugs.freedesktop.org/show_bug.cgi?id=105957
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>   [fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
>   [fdo#110379]: https://bugs.freedesktop.org/show_bug.cgi?id=110379
>   [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
>   [fdo#110581]: https://bugs.freedesktop.org/show_bug.cgi?id=110581
>   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> 
> 
> Participating hosts (10 -> 10)
> ------------------------------
> 
>   No changes in participating hosts
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_6026 -> Patchwork_12938
> 
>   CI_DRM_6026: 2d2d8d3b9d8896c99c88307a881120885afd2ddb @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_4972: f052e49a43cc9704ea5f240df15dd9d3dfed68ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_12938: 51220cd2ff773c282dd02aef53c605577f5ce73d @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12938/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx