* [PATCH 2/3] drm/i915/dp: Initialise locals for static analysis
2019-05-17 10:22 [PATCH 1/3] drm/i915/gvt: Set return value for ppgtt_populate error path Chris Wilson
@ 2019-05-17 10:22 ` Chris Wilson
2019-05-17 12:09 ` Imre Deak
2019-05-17 10:22 ` [PATCH 3/3] drm/i915/hdcp: Use both bits for device_count Chris Wilson
` (5 subsequent siblings)
6 siblings, 1 reply; 11+ messages in thread
From: Chris Wilson @ 2019-05-17 10:22 UTC (permalink / raw)
To: intel-gfx
Just to squelch an smatch warning that doesn't see the with_() being
taken unconditionally:
drivers/gpu/drm/i915//intel_dp.c:230 intel_dp_get_fia_supported_lane_count() error: uninitialized symbol 'lane_info'.
drivers/gpu/drm/i915//intel_dp.c:5338 intel_digital_port_connected() error: uninitialized symbol 'is_connected'.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/intel_dp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index e3e719c04440..77ba4da6b981 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -222,6 +222,7 @@ static int intel_dp_get_fia_supported_lane_count(struct intel_dp *intel_dp)
if (tc_port == PORT_TC_NONE || dig_port->tc_type != TC_PORT_TYPEC)
return 4;
+ lane_info = 0;
with_intel_display_power(dev_priv, POWER_DOMAIN_DISPLAY_CORE, wakeref)
lane_info = (I915_READ(PORT_TX_DFLEXDPSP) &
DP_LANE_ASSIGNMENT_MASK(tc_port)) >>
@@ -5329,8 +5330,8 @@ static bool __intel_digital_port_connected(struct intel_encoder *encoder)
bool intel_digital_port_connected(struct intel_encoder *encoder)
{
struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
+ bool is_connected = false;
intel_wakeref_t wakeref;
- bool is_connected;
with_intel_display_power(dev_priv, POWER_DOMAIN_DISPLAY_CORE, wakeref)
is_connected = __intel_digital_port_connected(encoder);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 2/3] drm/i915/dp: Initialise locals for static analysis
2019-05-17 10:22 ` [PATCH 2/3] drm/i915/dp: Initialise locals for static analysis Chris Wilson
@ 2019-05-17 12:09 ` Imre Deak
0 siblings, 0 replies; 11+ messages in thread
From: Imre Deak @ 2019-05-17 12:09 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, May 17, 2019 at 11:22:24AM +0100, Chris Wilson wrote:
> Just to squelch an smatch warning that doesn't see the with_() being
> taken unconditionally:
> drivers/gpu/drm/i915//intel_dp.c:230 intel_dp_get_fia_supported_lane_count() error: uninitialized symbol 'lane_info'.
> drivers/gpu/drm/i915//intel_dp.c:5338 intel_digital_port_connected() error: uninitialized symbol 'is_connected'.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index e3e719c04440..77ba4da6b981 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -222,6 +222,7 @@ static int intel_dp_get_fia_supported_lane_count(struct intel_dp *intel_dp)
> if (tc_port == PORT_TC_NONE || dig_port->tc_type != TC_PORT_TYPEC)
> return 4;
>
> + lane_info = 0;
> with_intel_display_power(dev_priv, POWER_DOMAIN_DISPLAY_CORE, wakeref)
> lane_info = (I915_READ(PORT_TX_DFLEXDPSP) &
> DP_LANE_ASSIGNMENT_MASK(tc_port)) >>
> @@ -5329,8 +5330,8 @@ static bool __intel_digital_port_connected(struct intel_encoder *encoder)
> bool intel_digital_port_connected(struct intel_encoder *encoder)
> {
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> + bool is_connected = false;
> intel_wakeref_t wakeref;
> - bool is_connected;
>
> with_intel_display_power(dev_priv, POWER_DOMAIN_DISPLAY_CORE, wakeref)
> is_connected = __intel_digital_port_connected(encoder);
> --
> 2.20.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/3] drm/i915/hdcp: Use both bits for device_count
2019-05-17 10:22 [PATCH 1/3] drm/i915/gvt: Set return value for ppgtt_populate error path Chris Wilson
2019-05-17 10:22 ` [PATCH 2/3] drm/i915/dp: Initialise locals for static analysis Chris Wilson
@ 2019-05-17 10:22 ` Chris Wilson
2019-05-17 12:55 ` Ramalingam C
2019-05-17 12:46 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gvt: Set return value for ppgtt_populate error path Patchwork
` (4 subsequent siblings)
6 siblings, 1 reply; 11+ messages in thread
From: Chris Wilson @ 2019-05-17 10:22 UTC (permalink / raw)
To: intel-gfx
Smatch spotted:
drivers/gpu/drm/i915//intel_hdcp.c:1406 hdcp2_authenticate_repeater_topology() warn: should this be a bitwise op?
and indeed looks to be suspect that we do need to use a bitwise or to
combine the two register fields into one counter.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ramalingam C <ramalingam.c@intel.com>
---
drivers/gpu/drm/i915/intel_hdcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
index 53df2f2376e8..bc3a94d491c4 100644
--- a/drivers/gpu/drm/i915/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/intel_hdcp.c
@@ -1402,8 +1402,8 @@ int hdcp2_authenticate_repeater_topology(struct intel_connector *connector)
return -EINVAL;
}
- device_cnt = HDCP_2_2_DEV_COUNT_HI(rx_info[0]) << 4 ||
- HDCP_2_2_DEV_COUNT_LO(rx_info[1]);
+ device_cnt = (HDCP_2_2_DEV_COUNT_HI(rx_info[0]) << 4 |
+ HDCP_2_2_DEV_COUNT_LO(rx_info[1]));
if (drm_hdcp_check_ksvs_revoked(dev, msgs.recvid_list.receiver_ids,
device_cnt)) {
DRM_ERROR("Revoked receiver ID(s) is in list\n");
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 3/3] drm/i915/hdcp: Use both bits for device_count
2019-05-17 10:22 ` [PATCH 3/3] drm/i915/hdcp: Use both bits for device_count Chris Wilson
@ 2019-05-17 12:55 ` Ramalingam C
0 siblings, 0 replies; 11+ messages in thread
From: Ramalingam C @ 2019-05-17 12:55 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On 2019-05-17 at 11:22:25 +0100, Chris Wilson wrote:
> Smatch spotted:
> drivers/gpu/drm/i915//intel_hdcp.c:1406 hdcp2_authenticate_repeater_topology() warn: should this be a bitwise op?
>
> and indeed looks to be suspect that we do need to use a bitwise or to
> combine the two register fields into one counter.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ramalingam C <ramalingam.c@intel.com>
Thanks for fixing it.
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
-Ram
> ---
> drivers/gpu/drm/i915/intel_hdcp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
> index 53df2f2376e8..bc3a94d491c4 100644
> --- a/drivers/gpu/drm/i915/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/intel_hdcp.c
> @@ -1402,8 +1402,8 @@ int hdcp2_authenticate_repeater_topology(struct intel_connector *connector)
> return -EINVAL;
> }
>
> - device_cnt = HDCP_2_2_DEV_COUNT_HI(rx_info[0]) << 4 ||
> - HDCP_2_2_DEV_COUNT_LO(rx_info[1]);
> + device_cnt = (HDCP_2_2_DEV_COUNT_HI(rx_info[0]) << 4 |
> + HDCP_2_2_DEV_COUNT_LO(rx_info[1]));
> if (drm_hdcp_check_ksvs_revoked(dev, msgs.recvid_list.receiver_ids,
> device_cnt)) {
> DRM_ERROR("Revoked receiver ID(s) is in list\n");
> --
> 2.20.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gvt: Set return value for ppgtt_populate error path
2019-05-17 10:22 [PATCH 1/3] drm/i915/gvt: Set return value for ppgtt_populate error path Chris Wilson
2019-05-17 10:22 ` [PATCH 2/3] drm/i915/dp: Initialise locals for static analysis Chris Wilson
2019-05-17 10:22 ` [PATCH 3/3] drm/i915/hdcp: Use both bits for device_count Chris Wilson
@ 2019-05-17 12:46 ` Patchwork
2019-05-17 13:01 ` [PATCH 1/3] " Ramalingam C
` (3 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2019-05-17 12:46 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915/gvt: Set return value for ppgtt_populate error path
URL : https://patchwork.freedesktop.org/series/60769/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
06cf16cbe5f5 drm/i915/gvt: Set return value for ppgtt_populate error path
-:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7:
drivers/gpu/drm/i915//gvt/gtt.c:1106 ppgtt_populate_spt_by_guest_entry() error: uninitialized symbol 'ret'.
total: 0 errors, 1 warnings, 0 checks, 11 lines checked
2d8a516fb459 drm/i915/dp: Initialise locals for static analysis
-:8: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#8:
drivers/gpu/drm/i915//intel_dp.c:230 intel_dp_get_fia_supported_lane_count() error: uninitialized symbol 'lane_info'.
total: 0 errors, 1 warnings, 0 checks, 16 lines checked
b11cea9f17b9 drm/i915/hdcp: Use both bits for device_count
-:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7:
drivers/gpu/drm/i915//intel_hdcp.c:1406 hdcp2_authenticate_repeater_topology() warn: should this be a bitwise op?
total: 0 errors, 1 warnings, 0 checks, 10 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 1/3] drm/i915/gvt: Set return value for ppgtt_populate error path
2019-05-17 10:22 [PATCH 1/3] drm/i915/gvt: Set return value for ppgtt_populate error path Chris Wilson
` (2 preceding siblings ...)
2019-05-17 12:46 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gvt: Set return value for ppgtt_populate error path Patchwork
@ 2019-05-17 13:01 ` Ramalingam C
2019-05-17 13:10 ` Ramalingam C
2019-05-17 13:39 ` ✓ Fi.CI.BAT: success for series starting with [1/3] " Patchwork
` (2 subsequent siblings)
6 siblings, 1 reply; 11+ messages in thread
From: Ramalingam C @ 2019-05-17 13:01 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On 2019-05-17 at 11:22:23 +0100, Chris Wilson wrote:
> Caught by smatch:
> drivers/gpu/drm/i915//gvt/gtt.c:1106 ppgtt_populate_spt_by_guest_entry() error: uninitialized symbol 'ret'.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gvt/gtt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
> index 08c74e65836b..244ad1729764 100644
> --- a/drivers/gpu/drm/i915/gvt/gtt.c
> +++ b/drivers/gpu/drm/i915/gvt/gtt.c
> @@ -1076,8 +1076,10 @@ static struct intel_vgpu_ppgtt_spt *ppgtt_populate_spt_by_guest_entry(
> } else {
> int type = get_next_pt_type(we->type);
>
> - if (!gtt_type_is_pt(type))
> + if (!gtt_type_is_pt(type)) {
> + ret = -EINVAL;
> goto err;
> + }
ret will be still uninitialized if we pass
if (spt) {
and not pass
if (ips != spt->guest_page.pde_ips) {
-Ram
>
> spt = ppgtt_alloc_spt_gfn(vgpu, type, ops->get_pfn(we), ips);
> if (IS_ERR(spt)) {
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 1/3] drm/i915/gvt: Set return value for ppgtt_populate error path
2019-05-17 13:01 ` [PATCH 1/3] " Ramalingam C
@ 2019-05-17 13:10 ` Ramalingam C
0 siblings, 0 replies; 11+ messages in thread
From: Ramalingam C @ 2019-05-17 13:10 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On 2019-05-17 at 18:31:42 +0530, Ramalingam C wrote:
> On 2019-05-17 at 11:22:23 +0100, Chris Wilson wrote:
> > Caught by smatch:
> > drivers/gpu/drm/i915//gvt/gtt.c:1106 ppgtt_populate_spt_by_guest_entry() error: uninitialized symbol 'ret'.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/gvt/gtt.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
> > index 08c74e65836b..244ad1729764 100644
> > --- a/drivers/gpu/drm/i915/gvt/gtt.c
> > +++ b/drivers/gpu/drm/i915/gvt/gtt.c
> > @@ -1076,8 +1076,10 @@ static struct intel_vgpu_ppgtt_spt *ppgtt_populate_spt_by_guest_entry(
> > } else {
> > int type = get_next_pt_type(we->type);
> >
> > - if (!gtt_type_is_pt(type))
> > + if (!gtt_type_is_pt(type)) {
> > + ret = -EINVAL;
> > goto err;
> > + }
>
> ret will be still uninitialized if we pass
> if (spt) {
> and not pass
> if (ips != spt->guest_page.pde_ips) {
relooking at it if we dont pass the "if (ips !=
spt->guest_page.pde_ips)" then there is no err exit.
So
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
-Ram
>
> -Ram
> >
> > spt = ppgtt_alloc_spt_gfn(vgpu, type, ops->get_pfn(we), ips);
> > if (IS_ERR(spt)) {
> > --
> > 2.20.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/gvt: Set return value for ppgtt_populate error path
2019-05-17 10:22 [PATCH 1/3] drm/i915/gvt: Set return value for ppgtt_populate error path Chris Wilson
` (3 preceding siblings ...)
2019-05-17 13:01 ` [PATCH 1/3] " Ramalingam C
@ 2019-05-17 13:39 ` Patchwork
2019-05-17 19:38 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-20 2:51 ` [PATCH 1/3] " Zhenyu Wang
6 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2019-05-17 13:39 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915/gvt: Set return value for ppgtt_populate error path
URL : https://patchwork.freedesktop.org/series/60769/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6093 -> Patchwork_13030
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/
Known issues
------------
Here are the changes found in Patchwork_13030 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][1] -> [DMESG-WARN][2] ([fdo#102614])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
- fi-icl-u2: [PASS][3] -> [FAIL][4] ([fdo#103167])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
#### Possible fixes ####
* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: [DMESG-FAIL][5] ([fdo#110235]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/fi-skl-gvtdvm/igt@i915_selftest@live_contexts.html
* igt@prime_vgem@basic-fence-flip:
- fi-ilk-650: [DMESG-WARN][7] ([fdo#106387]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/fi-ilk-650/igt@prime_vgem@basic-fence-flip.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/fi-ilk-650/igt@prime_vgem@basic-fence-flip.html
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
Participating hosts (53 -> 44)
------------------------------
Missing (9): fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6093 -> Patchwork_13030
CI_DRM_6093: 3521a84b80042a6ff62b7a29ffb291acbb601d31 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4994: 555019f862c35f1619627761d6da21385be40920 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13030: b11cea9f17b98733e2b1ea2d0f9b39490e727ec2 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b11cea9f17b9 drm/i915/hdcp: Use both bits for device_count
2d8a516fb459 drm/i915/dp: Initialise locals for static analysis
06cf16cbe5f5 drm/i915/gvt: Set return value for ppgtt_populate error path
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread* ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/gvt: Set return value for ppgtt_populate error path
2019-05-17 10:22 [PATCH 1/3] drm/i915/gvt: Set return value for ppgtt_populate error path Chris Wilson
` (4 preceding siblings ...)
2019-05-17 13:39 ` ✓ Fi.CI.BAT: success for series starting with [1/3] " Patchwork
@ 2019-05-17 19:38 ` Patchwork
2019-05-20 2:51 ` [PATCH 1/3] " Zhenyu Wang
6 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2019-05-17 19:38 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/3] drm/i915/gvt: Set return value for ppgtt_populate error path
URL : https://patchwork.freedesktop.org/series/60769/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6093_full -> Patchwork_13030_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13030_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@kms_cursor_crc@pipe-a-cursor-suspend}:
- shard-snb: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-snb4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-snb6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
Known issues
------------
Here are the changes found in Patchwork_13030_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@legacy-planes:
- shard-apl: [PASS][3] -> [INCOMPLETE][4] ([fdo#103927])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-apl6/igt@i915_pm_rpm@legacy-planes.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-apl1/igt@i915_pm_rpm@legacy-planes.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +6 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-apl1/igt@i915_suspend@debugfs-reader.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-apl4/igt@i915_suspend@debugfs-reader.html
* igt@i915_suspend@sysfs-reader:
- shard-skl: [PASS][7] -> [INCOMPLETE][8] ([fdo#104108])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-skl6/igt@i915_suspend@sysfs-reader.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-skl10/igt@i915_suspend@sysfs-reader.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [PASS][9] -> [FAIL][10] ([fdo#105767])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled:
- shard-skl: [PASS][11] -> [FAIL][12] ([fdo#103184] / [fdo#103232] / [fdo#108472])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-skl3/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-skl9/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-untiled.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-glk: [PASS][13] -> [FAIL][14] ([fdo#100368])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-glk6/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-glk8/igt@kms_flip@plain-flip-fb-recreate-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#103167]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#103167] / [fdo#110378])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-render:
- shard-skl: [PASS][19] -> [FAIL][20] ([fdo#103167])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-skl10/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-render.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][21] -> [FAIL][22] ([fdo#108145]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][23] -> [FAIL][24] ([fdo#108145] / [fdo#110403]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][25] -> [FAIL][26] ([fdo#103166])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-x.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
* igt@kms_rotation_crc@primary-rotation-270:
- shard-iclb: [PASS][29] -> [INCOMPLETE][30] ([fdo#107713] / [fdo#110026] / [fdo#110040 ])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-iclb7/igt@kms_rotation_crc@primary-rotation-270.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-iclb7/igt@kms_rotation_crc@primary-rotation-270.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-kbl6/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-kbl7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [DMESG-WARN][33] ([fdo#108566]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-kbl7/igt@gem_exec_suspend@basic-s3.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-kbl3/igt@gem_exec_suspend@basic-s3.html
* igt@gem_mmap_gtt@forked-big-copy:
- shard-iclb: [INCOMPLETE][35] ([fdo#107713] / [fdo#109100]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-iclb1/igt@gem_mmap_gtt@forked-big-copy.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-iclb2/igt@gem_mmap_gtt@forked-big-copy.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][37] ([fdo#104108] / [fdo#107773]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-skl9/igt@gem_softpin@noreloc-s3.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-skl9/igt@gem_softpin@noreloc-s3.html
* igt@i915_pm_rpm@debugfs-read:
- shard-skl: [INCOMPLETE][39] ([fdo#107807]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-skl8/igt@i915_pm_rpm@debugfs-read.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-skl3/igt@i915_pm_rpm@debugfs-read.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-skl: [INCOMPLETE][41] ([fdo#104108] / [fdo#107807]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-skl8/igt@i915_pm_rpm@system-suspend-execbuf.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-skl2/igt@i915_pm_rpm@system-suspend-execbuf.html
* igt@i915_suspend@debugfs-reader:
- shard-skl: [INCOMPLETE][43] ([fdo#104108]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-skl5/igt@i915_suspend@debugfs-reader.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-skl5/igt@i915_suspend@debugfs-reader.html
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: [FAIL][45] ([fdo#106509] / [fdo#107409]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-glk4/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-glk4/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][47] ([fdo#103167]) -> [PASS][48] +3 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [FAIL][49] ([fdo#103166]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-iclb8/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][51] ([fdo#108566]) -> [PASS][52] +8 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-apl7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-apl1/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-kbl: [FAIL][53] ([fdo#105010]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-kbl2/igt@perf_pmu@rc6-runtime-pm-long.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-kbl1/igt@perf_pmu@rc6-runtime-pm-long.html
#### Warnings ####
* igt@gem_mmap_gtt@forked-big-copy-odd:
- shard-iclb: [INCOMPLETE][55] ([fdo#107713] / [fdo#109100]) -> [TIMEOUT][56] ([fdo#109673])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6093/shard-iclb3/igt@gem_mmap_gtt@forked-big-copy-odd.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/shard-iclb5/igt@gem_mmap_gtt@forked-big-copy-odd.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100368]: https://bugs.freedesktop.org/show_bug.cgi?id=100368
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#107409]: https://bugs.freedesktop.org/show_bug.cgi?id=107409
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108472]: https://bugs.freedesktop.org/show_bug.cgi?id=108472
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
[fdo#110026]: https://bugs.freedesktop.org/show_bug.cgi?id=110026
[fdo#110040 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110040
[fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6093 -> Patchwork_13030
CI_DRM_6093: 3521a84b80042a6ff62b7a29ffb291acbb601d31 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4994: 555019f862c35f1619627761d6da21385be40920 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13030: b11cea9f17b98733e2b1ea2d0f9b39490e727ec2 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13030/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 1/3] drm/i915/gvt: Set return value for ppgtt_populate error path
2019-05-17 10:22 [PATCH 1/3] drm/i915/gvt: Set return value for ppgtt_populate error path Chris Wilson
` (5 preceding siblings ...)
2019-05-17 19:38 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-05-20 2:51 ` Zhenyu Wang
6 siblings, 0 replies; 11+ messages in thread
From: Zhenyu Wang @ 2019-05-20 2:51 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 1239 bytes --]
On 2019.05.17 11:22:23 +0100, Chris Wilson wrote:
> Caught by smatch:
> drivers/gpu/drm/i915//gvt/gtt.c:1106 ppgtt_populate_spt_by_guest_entry() error: uninitialized symbol 'ret'.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gvt/gtt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
> index 08c74e65836b..244ad1729764 100644
> --- a/drivers/gpu/drm/i915/gvt/gtt.c
> +++ b/drivers/gpu/drm/i915/gvt/gtt.c
> @@ -1076,8 +1076,10 @@ static struct intel_vgpu_ppgtt_spt *ppgtt_populate_spt_by_guest_entry(
> } else {
> int type = get_next_pt_type(we->type);
>
> - if (!gtt_type_is_pt(type))
> + if (!gtt_type_is_pt(type)) {
> + ret = -EINVAL;
> goto err;
> + }
>
> spt = ppgtt_alloc_spt_gfn(vgpu, type, ops->get_pfn(we), ips);
> if (IS_ERR(spt)) {
> --
I've already merged Dan's patch for this, I was out for some days of
last week, so haven't sent pull yet. Will include this in next pull.
Thanks
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread