Re: [PATCH] gpu/drm/i915: globally replace dev_priv with i915

[Lucas De Marchi <lucas.de.marchi@gmail.com>]

On Thu, Jun 13, 2019 at 07:07:28AM +0100, Chris Wilson wrote:
>Quoting Lucas De Marchi (2019-06-12 17:29:00)
>> We are slowly converting dev_priv to i915 everywhere, spread into
>> smaller series. While this is good to avoid unrelated breakages to other
>> inflight patches, it's bad because inflight patches on nearby paths keep
>> breaking. Paired with other code moves and refactores this is becoming a
>> nightmare.
>>
>> Now that I915_{READ,WRITE} are gone and implicit access to dev_priv no
>> longer exists we can simply sed all files and be done with the
>> conversion. This was generated with the following commands with no
>> additional fixups:
>>
>>         git ls-files --full-name -z -- drivers/gpu/drm/i915/ | \
>>                 xargs -0 sed -i 's/\bdev_priv\b/i915/g'
>>
>> Any pending series can apply the same search and replace when rebasing.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> ---
>>  drivers/gpu/drm/i915/dvo_ch7017.c             |    6 +-
>>  drivers/gpu/drm/i915/dvo_ch7xxx.c             |   10 +-
>>  drivers/gpu/drm/i915/dvo_ivch.c               |   14 +-
>>  drivers/gpu/drm/i915/dvo_ns2501.c             |   14 +-
>>  drivers/gpu/drm/i915/dvo_sil164.c             |   10 +-
>>  drivers/gpu/drm/i915/dvo_tfp410.c             |   10 +-
>
>Notice that the very start of this, the dev_priv backpointers are
>not i915.

true. AFAICS it's in all the dvo_*.c - I will fix it for next time.

thanks
Lucas De Marchi

>-Chris
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx