Re: [PATCH] gpu/drm/i915: globally replace dev_priv with i915

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 12 Jun 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> We are slowly converting dev_priv to i915 everywhere, spread into
> smaller series. While this is good to avoid unrelated breakages to other
> inflight patches, it's bad because inflight patches on nearby paths keep
> breaking. Paired with other code moves and refactores this is becoming a
> nightmare.
>
> Now that I915_{READ,WRITE} are gone and implicit access to dev_priv no
> longer exists we can simply sed all files and be done with the
> conversion. This was generated with the following commands with no
> additional fixups:
>
> 	git ls-files --full-name -z -- drivers/gpu/drm/i915/ | \
> 		xargs -0 sed -i 's/\bdev_priv\b/i915/g'
>
> Any pending series can apply the same search and replace when rebasing.

I'm pretty strongly against renaming the implicit dev_priv local
variable before we've gotten rid of it. Renaming s/dev_priv/i915/ upon
converting a function to not use the implicit dev_priv helps us by
catching any leftover references.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx