From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Lucas De Marchi <lucas.demarchi@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] gpu/drm/i915: globally replace dev_priv with i915
Date: Thu, 13 Jun 2019 16:21:34 +0100 [thread overview]
Message-ID: <c89a5f38-94f1-0441-2e3f-ab6b19a6b069@linux.intel.com> (raw)
In-Reply-To: <156043918400.17012.6235201090156630460@skylake-alporthouse-com>
On 13/06/2019 16:19, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-06-13 16:12:16)
>>
>> On 12/06/2019 17:29, Lucas De Marchi wrote:
>>> We are slowly converting dev_priv to i915 everywhere, spread into
>>> smaller series. While this is good to avoid unrelated breakages to other
>>> inflight patches, it's bad because inflight patches on nearby paths keep
>>> breaking. Paired with other code moves and refactores this is becoming a
>>> nightmare.
>>>
>>> Now that I915_{READ,WRITE} are gone and implicit access to dev_priv no
>>
>> Who removed I915_READ/WRITE? In fact I see some in this patch. Well
>> colour me confused.. how did the patch compile?
>
> The secret is in changing the implicit parameter as well, s/dev_priv/i915/
Lolz are on me. :))
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-13 15:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190612162900.13777-1-lucas.demarchi@intel.com>
2019-06-13 1:02 ` ✗ Fi.CI.CHECKPATCH: warning for gpu/drm/i915: globally replace dev_priv with i915 Patchwork
2019-06-13 1:03 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-06-13 2:19 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-13 6:07 ` [PATCH] " Chris Wilson
2019-06-13 6:14 ` Lucas De Marchi
2019-06-13 13:12 ` Jani Nikula
2019-06-13 16:29 ` Lucas De Marchi
2019-06-13 16:48 ` Lucas De Marchi
2019-06-13 17:04 ` Rodrigo Vivi
2019-06-14 12:47 ` Jani Nikula
2019-06-14 17:06 ` Lucas De Marchi
[not found] ` <0000a4b2-ac8b-a18d-4c78-0db197c712a1@linux.intel.com>
2019-06-13 15:19 ` Chris Wilson
2019-06-13 15:21 ` Tvrtko Ursulin [this message]
2019-06-14 16:41 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c89a5f38-94f1-0441-2e3f-ab6b19a6b069@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox