* [PATCH 01/11] drm/i915: make i915_fixed.h self-contained
2019-06-17 9:50 drm/i915: last bits to make headers self-contained Jani Nikula
@ 2019-06-17 9:50 ` Jani Nikula
2019-06-17 9:50 ` [PATCH 02/11] drm/i915: make i915_gem_gtt.h self-contained Jani Nikula
` (12 subsequent siblings)
13 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-06-17 9:50 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Add the minimal includes/declarations to make the header self-contained,
and ensure it stays that way.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
| 1 +
drivers/gpu/drm/i915/i915_fixed.h | 5 +++++
2 files changed, 6 insertions(+)
--git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index e6ba66f787f9..f6ec3e72ae38 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -6,6 +6,7 @@ header_test := \
i915_active_types.h \
i915_debugfs.h \
i915_drv.h \
+ i915_fixed.h \
i915_irq.h \
i915_params.h \
i915_priolist_types.h \
diff --git a/drivers/gpu/drm/i915/i915_fixed.h b/drivers/gpu/drm/i915/i915_fixed.h
index 6621595fe74c..a327094de2bd 100644
--- a/drivers/gpu/drm/i915/i915_fixed.h
+++ b/drivers/gpu/drm/i915/i915_fixed.h
@@ -6,6 +6,11 @@
#ifndef _I915_FIXED_H_
#define _I915_FIXED_H_
+#include <linux/bug.h>
+#include <linux/kernel.h>
+#include <linux/math64.h>
+#include <linux/types.h>
+
typedef struct {
u32 val;
} uint_fixed_16_16_t;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 02/11] drm/i915: make i915_gem_gtt.h self-contained
2019-06-17 9:50 drm/i915: last bits to make headers self-contained Jani Nikula
2019-06-17 9:50 ` [PATCH 01/11] drm/i915: make i915_fixed.h self-contained Jani Nikula
@ 2019-06-17 9:50 ` Jani Nikula
2019-06-17 9:51 ` [PATCH 03/11] drm/i915: make i915_globals.h self-contained Jani Nikula
` (11 subsequent siblings)
13 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-06-17 9:50 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Add the minimal includes/declarations to make the header self-contained,
and ensure it stays that way.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
| 1 +
drivers/gpu/drm/i915/i915_gem_gtt.h | 2 ++
2 files changed, 3 insertions(+)
--git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index f6ec3e72ae38..00a437db434d 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -7,6 +7,7 @@ header_test := \
i915_debugfs.h \
i915_drv.h \
i915_fixed.h \
+ i915_gem_gtt.h \
i915_irq.h \
i915_params.h \
i915_priolist_types.h \
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h b/drivers/gpu/drm/i915/i915_gem_gtt.h
index 63fa357c69de..108d4c7293d7 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.h
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.h
@@ -38,6 +38,8 @@
#include <linux/mm.h>
#include <linux/pagevec.h>
+#include <drm/drm_mm.h>
+
#include "gt/intel_reset.h"
#include "i915_gem_fence_reg.h"
#include "i915_request.h"
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 03/11] drm/i915: make i915_globals.h self-contained
2019-06-17 9:50 drm/i915: last bits to make headers self-contained Jani Nikula
2019-06-17 9:50 ` [PATCH 01/11] drm/i915: make i915_fixed.h self-contained Jani Nikula
2019-06-17 9:50 ` [PATCH 02/11] drm/i915: make i915_gem_gtt.h self-contained Jani Nikula
@ 2019-06-17 9:51 ` Jani Nikula
2019-06-17 9:51 ` [PATCH 04/11] drm/i915: make i915_pvinfo.h self-contained Jani Nikula
` (10 subsequent siblings)
13 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-06-17 9:51 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Add the minimal includes/declarations to make the header self-contained,
and ensure it stays that way.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
| 1 +
drivers/gpu/drm/i915/i915_globals.h | 2 ++
2 files changed, 3 insertions(+)
--git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index 00a437db434d..4f7a349dcfc5 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -8,6 +8,7 @@ header_test := \
i915_drv.h \
i915_fixed.h \
i915_gem_gtt.h \
+ i915_globals.h \
i915_irq.h \
i915_params.h \
i915_priolist_types.h \
diff --git a/drivers/gpu/drm/i915/i915_globals.h b/drivers/gpu/drm/i915/i915_globals.h
index 04c1ce107fc0..2d199f411a4a 100644
--- a/drivers/gpu/drm/i915/i915_globals.h
+++ b/drivers/gpu/drm/i915/i915_globals.h
@@ -7,6 +7,8 @@
#ifndef _I915_GLOBALS_H_
#define _I915_GLOBALS_H_
+#include <linux/types.h>
+
typedef void (*i915_global_func_t)(void);
struct i915_global {
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 04/11] drm/i915: make i915_pvinfo.h self-contained
2019-06-17 9:50 drm/i915: last bits to make headers self-contained Jani Nikula
` (2 preceding siblings ...)
2019-06-17 9:51 ` [PATCH 03/11] drm/i915: make i915_globals.h self-contained Jani Nikula
@ 2019-06-17 9:51 ` Jani Nikula
2019-06-17 9:51 ` [PATCH 05/11] drm/i915: make i915_vgpu.h self-contained Jani Nikula
` (9 subsequent siblings)
13 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-06-17 9:51 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Add the minimal includes/declarations to make the header self-contained,
and ensure it stays that way.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
| 1 +
drivers/gpu/drm/i915/i915_pvinfo.h | 2 ++
2 files changed, 3 insertions(+)
--git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index 4f7a349dcfc5..c0d1663e5b61 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -12,6 +12,7 @@ header_test := \
i915_irq.h \
i915_params.h \
i915_priolist_types.h \
+ i915_pvinfo.h \
i915_reg.h \
i915_scheduler_types.h \
i915_timeline_types.h \
diff --git a/drivers/gpu/drm/i915/i915_pvinfo.h b/drivers/gpu/drm/i915/i915_pvinfo.h
index 969e514916ab..2b29065da6d1 100644
--- a/drivers/gpu/drm/i915/i915_pvinfo.h
+++ b/drivers/gpu/drm/i915/i915_pvinfo.h
@@ -24,6 +24,8 @@
#ifndef _I915_PVINFO_H_
#define _I915_PVINFO_H_
+#include <linux/types.h>
+
/* The MMIO offset of the shared info between guest and host emulator */
#define VGT_PVINFO_PAGE 0x78000
#define VGT_PVINFO_SIZE 0x1000
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 05/11] drm/i915: make i915_vgpu.h self-contained
2019-06-17 9:50 drm/i915: last bits to make headers self-contained Jani Nikula
` (3 preceding siblings ...)
2019-06-17 9:51 ` [PATCH 04/11] drm/i915: make i915_pvinfo.h self-contained Jani Nikula
@ 2019-06-17 9:51 ` Jani Nikula
2019-06-17 9:51 ` [PATCH 06/11] drm/i915: make intel_guc_ct.h self-contained Jani Nikula
` (8 subsequent siblings)
13 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-06-17 9:51 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Add the minimal includes/declarations to make the header self-contained,
and ensure it stays that way.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
| 1 +
drivers/gpu/drm/i915/i915_vgpu.h | 1 +
2 files changed, 2 insertions(+)
--git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index c0d1663e5b61..0961b661df09 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -17,6 +17,7 @@ header_test := \
i915_scheduler_types.h \
i915_timeline_types.h \
i915_utils.h \
+ i915_vgpu.h \
intel_csr.h \
intel_drv.h \
intel_pm.h \
diff --git a/drivers/gpu/drm/i915/i915_vgpu.h b/drivers/gpu/drm/i915/i915_vgpu.h
index ebe1b7bced98..0ad3c491c5d9 100644
--- a/drivers/gpu/drm/i915/i915_vgpu.h
+++ b/drivers/gpu/drm/i915/i915_vgpu.h
@@ -24,6 +24,7 @@
#ifndef _I915_VGPU_H_
#define _I915_VGPU_H_
+#include "i915_drv.h"
#include "i915_pvinfo.h"
void i915_check_vgpu(struct drm_i915_private *dev_priv);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 06/11] drm/i915: make intel_guc_ct.h self-contained
2019-06-17 9:50 drm/i915: last bits to make headers self-contained Jani Nikula
` (4 preceding siblings ...)
2019-06-17 9:51 ` [PATCH 05/11] drm/i915: make i915_vgpu.h self-contained Jani Nikula
@ 2019-06-17 9:51 ` Jani Nikula
2019-06-17 9:51 ` [PATCH 07/11] drm/i915: make intel_guc_fwif.h self-contained Jani Nikula
` (7 subsequent siblings)
13 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-06-17 9:51 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Add the minimal includes/declarations to make the header self-contained,
and ensure it stays that way.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
| 1 +
drivers/gpu/drm/i915/intel_guc_ct.h | 6 ++++--
2 files changed, 5 insertions(+), 2 deletions(-)
--git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index 0961b661df09..315f0b7d0406 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -20,6 +20,7 @@ header_test := \
i915_vgpu.h \
intel_csr.h \
intel_drv.h \
+ intel_guc_ct.h \
intel_pm.h \
intel_runtime_pm.h \
intel_sideband.h \
diff --git a/drivers/gpu/drm/i915/intel_guc_ct.h b/drivers/gpu/drm/i915/intel_guc_ct.h
index 41ba593a4df7..d7b8c1223964 100644
--- a/drivers/gpu/drm/i915/intel_guc_ct.h
+++ b/drivers/gpu/drm/i915/intel_guc_ct.h
@@ -24,11 +24,13 @@
#ifndef _INTEL_GUC_CT_H_
#define _INTEL_GUC_CT_H_
-struct intel_guc;
-struct i915_vma;
+#include <linux/spinlock.h>
+#include <linux/workqueue.h>
#include "intel_guc_fwif.h"
+struct i915_vma;
+
/**
* DOC: Command Transport (CT).
*
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 07/11] drm/i915: make intel_guc_fwif.h self-contained
2019-06-17 9:50 drm/i915: last bits to make headers self-contained Jani Nikula
` (5 preceding siblings ...)
2019-06-17 9:51 ` [PATCH 06/11] drm/i915: make intel_guc_ct.h self-contained Jani Nikula
@ 2019-06-17 9:51 ` Jani Nikula
2019-06-17 9:51 ` [PATCH 08/11] drm/i915: make intel_guc_reg.h self-contained Jani Nikula
` (6 subsequent siblings)
13 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-06-17 9:51 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Add the minimal includes/declarations to make the header self-contained,
and ensure it stays that way.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
| 1 +
drivers/gpu/drm/i915/intel_guc_fwif.h | 4 ++++
2 files changed, 5 insertions(+)
--git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index 315f0b7d0406..b140afeb617e 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -21,6 +21,7 @@ header_test := \
intel_csr.h \
intel_drv.h \
intel_guc_ct.h \
+ intel_guc_fwif.h \
intel_pm.h \
intel_runtime_pm.h \
intel_sideband.h \
diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h b/drivers/gpu/drm/i915/intel_guc_fwif.h
index f55f3bc8524d..92bd7ffb5b10 100644
--- a/drivers/gpu/drm/i915/intel_guc_fwif.h
+++ b/drivers/gpu/drm/i915/intel_guc_fwif.h
@@ -23,6 +23,10 @@
#ifndef _INTEL_GUC_FWIF_H
#define _INTEL_GUC_FWIF_H
+#include <linux/bits.h>
+#include <linux/compiler.h>
+#include <linux/types.h>
+
#define GUC_CLIENT_PRIORITY_KMD_HIGH 0
#define GUC_CLIENT_PRIORITY_HIGH 1
#define GUC_CLIENT_PRIORITY_KMD_NORMAL 2
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 08/11] drm/i915: make intel_guc_reg.h self-contained
2019-06-17 9:50 drm/i915: last bits to make headers self-contained Jani Nikula
` (6 preceding siblings ...)
2019-06-17 9:51 ` [PATCH 07/11] drm/i915: make intel_guc_fwif.h self-contained Jani Nikula
@ 2019-06-17 9:51 ` Jani Nikula
2019-06-17 14:45 ` Michal Wajdeczko
2019-06-17 9:51 ` [PATCH 09/11] drm/i915: make intel_gvt.h self-contained Jani Nikula
` (5 subsequent siblings)
13 siblings, 1 reply; 17+ messages in thread
From: Jani Nikula @ 2019-06-17 9:51 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Add the minimal includes/declarations to make the header self-contained,
and ensure it stays that way.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
| 1 +
drivers/gpu/drm/i915/intel_guc_reg.h | 3 +++
2 files changed, 4 insertions(+)
--git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index b140afeb617e..085fba8e71f2 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -22,6 +22,7 @@ header_test := \
intel_drv.h \
intel_guc_ct.h \
intel_guc_fwif.h \
+ intel_guc_reg.h \
intel_pm.h \
intel_runtime_pm.h \
intel_sideband.h \
diff --git a/drivers/gpu/drm/i915/intel_guc_reg.h b/drivers/gpu/drm/i915/intel_guc_reg.h
index a214f8b71929..02f4b1d61a98 100644
--- a/drivers/gpu/drm/i915/intel_guc_reg.h
+++ b/drivers/gpu/drm/i915/intel_guc_reg.h
@@ -24,6 +24,9 @@
#ifndef _INTEL_GUC_REG_H_
#define _INTEL_GUC_REG_H_
+#include <linux/compiler.h>
+#include <linux/types.h>
+
/* Definitions of GuC H/W registers, bits, etc */
#define GUC_STATUS _MMIO(0xc000)
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 08/11] drm/i915: make intel_guc_reg.h self-contained
2019-06-17 9:51 ` [PATCH 08/11] drm/i915: make intel_guc_reg.h self-contained Jani Nikula
@ 2019-06-17 14:45 ` Michal Wajdeczko
2019-06-25 9:29 ` Jani Nikula
0 siblings, 1 reply; 17+ messages in thread
From: Michal Wajdeczko @ 2019-06-17 14:45 UTC (permalink / raw)
To: intel-gfx, Jani Nikula
On Mon, 17 Jun 2019 11:51:05 +0200, Jani Nikula <jani.nikula@intel.com>
wrote:
> Add the minimal includes/declarations to make the header self-contained,
> and ensure it stays that way.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/Makefile.header-test | 1 +
> drivers/gpu/drm/i915/intel_guc_reg.h | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/Makefile.header-test
> b/drivers/gpu/drm/i915/Makefile.header-test
> index b140afeb617e..085fba8e71f2 100644
> --- a/drivers/gpu/drm/i915/Makefile.header-test
> +++ b/drivers/gpu/drm/i915/Makefile.header-test
> @@ -22,6 +22,7 @@ header_test := \
> intel_drv.h \
> intel_guc_ct.h \
> intel_guc_fwif.h \
> + intel_guc_reg.h \
> intel_pm.h \
> intel_runtime_pm.h \
> intel_sideband.h \
> diff --git a/drivers/gpu/drm/i915/intel_guc_reg.h
> b/drivers/gpu/drm/i915/intel_guc_reg.h
> index a214f8b71929..02f4b1d61a98 100644
> --- a/drivers/gpu/drm/i915/intel_guc_reg.h
> +++ b/drivers/gpu/drm/i915/intel_guc_reg.h
> @@ -24,6 +24,9 @@
> #ifndef _INTEL_GUC_REG_H_
> #define _INTEL_GUC_REG_H_
> +#include <linux/compiler.h>
> +#include <linux/types.h>
> +
> /* Definitions of GuC H/W registers, bits, etc */
> #define GUC_STATUS _MMIO(0xc000)
shouldn't we also include i915_reg.h for _MMIO definition?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 08/11] drm/i915: make intel_guc_reg.h self-contained
2019-06-17 14:45 ` Michal Wajdeczko
@ 2019-06-25 9:29 ` Jani Nikula
0 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-06-25 9:29 UTC (permalink / raw)
To: Michal Wajdeczko, intel-gfx
On Mon, 17 Jun 2019, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> On Mon, 17 Jun 2019 11:51:05 +0200, Jani Nikula <jani.nikula@intel.com>
> wrote:
>
>> Add the minimal includes/declarations to make the header self-contained,
>> and ensure it stays that way.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/Makefile.header-test | 1 +
>> drivers/gpu/drm/i915/intel_guc_reg.h | 3 +++
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/Makefile.header-test
>> b/drivers/gpu/drm/i915/Makefile.header-test
>> index b140afeb617e..085fba8e71f2 100644
>> --- a/drivers/gpu/drm/i915/Makefile.header-test
>> +++ b/drivers/gpu/drm/i915/Makefile.header-test
>> @@ -22,6 +22,7 @@ header_test := \
>> intel_drv.h \
>> intel_guc_ct.h \
>> intel_guc_fwif.h \
>> + intel_guc_reg.h \
>> intel_pm.h \
>> intel_runtime_pm.h \
>> intel_sideband.h \
>> diff --git a/drivers/gpu/drm/i915/intel_guc_reg.h
>> b/drivers/gpu/drm/i915/intel_guc_reg.h
>> index a214f8b71929..02f4b1d61a98 100644
>> --- a/drivers/gpu/drm/i915/intel_guc_reg.h
>> +++ b/drivers/gpu/drm/i915/intel_guc_reg.h
>> @@ -24,6 +24,9 @@
>> #ifndef _INTEL_GUC_REG_H_
>> #define _INTEL_GUC_REG_H_
>> +#include <linux/compiler.h>
>> +#include <linux/types.h>
>> +
>> /* Definitions of GuC H/W registers, bits, etc */
>> #define GUC_STATUS _MMIO(0xc000)
>
> shouldn't we also include i915_reg.h for _MMIO definition?
Thanks, added that in v2. Though this compiles just fine standalone when
nobody uses the macros. ;)
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 09/11] drm/i915: make intel_gvt.h self-contained
2019-06-17 9:50 drm/i915: last bits to make headers self-contained Jani Nikula
` (7 preceding siblings ...)
2019-06-17 9:51 ` [PATCH 08/11] drm/i915: make intel_guc_reg.h self-contained Jani Nikula
@ 2019-06-17 9:51 ` Jani Nikula
2019-06-17 9:51 ` [PATCH 10/11] drm/i915: make intel_uc_fw.h self-contained Jani Nikula
` (4 subsequent siblings)
13 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-06-17 9:51 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Add the minimal includes/declarations to make the header self-contained,
and ensure it stays that way.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
| 1 +
drivers/gpu/drm/i915/intel_gvt.h | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
--git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index 085fba8e71f2..5ae2cae27e85 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -23,6 +23,7 @@ header_test := \
intel_guc_ct.h \
intel_guc_fwif.h \
intel_guc_reg.h \
+ intel_gvt.h \
intel_pm.h \
intel_runtime_pm.h \
intel_sideband.h \
diff --git a/drivers/gpu/drm/i915/intel_gvt.h b/drivers/gpu/drm/i915/intel_gvt.h
index 61b246470282..85ce37eb7cd6 100644
--- a/drivers/gpu/drm/i915/intel_gvt.h
+++ b/drivers/gpu/drm/i915/intel_gvt.h
@@ -24,7 +24,7 @@
#ifndef _INTEL_GVT_H_
#define _INTEL_GVT_H_
-struct intel_gvt;
+struct drm_i915_private;
#ifdef CONFIG_DRM_I915_GVT
int intel_gvt_init(struct drm_i915_private *dev_priv);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 10/11] drm/i915: make intel_uc_fw.h self-contained
2019-06-17 9:50 drm/i915: last bits to make headers self-contained Jani Nikula
` (8 preceding siblings ...)
2019-06-17 9:51 ` [PATCH 09/11] drm/i915: make intel_gvt.h self-contained Jani Nikula
@ 2019-06-17 9:51 ` Jani Nikula
2019-06-17 9:51 ` [PATCH 11/11] drm/i915: use wildcard to ensure all headers stay self-contained Jani Nikula
` (3 subsequent siblings)
13 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-06-17 9:51 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Add the minimal includes/declarations to make the header self-contained,
and ensure it stays that way.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
| 1 +
drivers/gpu/drm/i915/intel_uc_fw.h | 2 ++
2 files changed, 3 insertions(+)
--git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index 5ae2cae27e85..919d3a848b0b 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -27,6 +27,7 @@ header_test := \
intel_pm.h \
intel_runtime_pm.h \
intel_sideband.h \
+ intel_uc_fw.h \
intel_uncore.h \
intel_wakeref.h
diff --git a/drivers/gpu/drm/i915/intel_uc_fw.h b/drivers/gpu/drm/i915/intel_uc_fw.h
index ff98f8661d72..24e66469153c 100644
--- a/drivers/gpu/drm/i915/intel_uc_fw.h
+++ b/drivers/gpu/drm/i915/intel_uc_fw.h
@@ -25,6 +25,8 @@
#ifndef _INTEL_UC_FW_H_
#define _INTEL_UC_FW_H_
+#include <linux/types.h>
+
struct drm_printer;
struct drm_i915_private;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 11/11] drm/i915: use wildcard to ensure all headers stay self-contained
2019-06-17 9:50 drm/i915: last bits to make headers self-contained Jani Nikula
` (9 preceding siblings ...)
2019-06-17 9:51 ` [PATCH 10/11] drm/i915: make intel_uc_fw.h self-contained Jani Nikula
@ 2019-06-17 9:51 ` Jani Nikula
2019-06-17 12:15 ` drm/i915: last bits to make headers self-contained Chris Wilson
` (2 subsequent siblings)
13 siblings, 0 replies; 17+ messages in thread
From: Jani Nikula @ 2019-06-17 9:51 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Skip the generated i915_oa_*.h files.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
| 29 +----------------------
1 file changed, 1 insertion(+), 28 deletions(-)
--git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index 919d3a848b0b..f6641eca0d2d 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -2,34 +2,7 @@
# Copyright © 2019 Intel Corporation
# Test the headers are compilable as standalone units
-header_test := \
- i915_active_types.h \
- i915_debugfs.h \
- i915_drv.h \
- i915_fixed.h \
- i915_gem_gtt.h \
- i915_globals.h \
- i915_irq.h \
- i915_params.h \
- i915_priolist_types.h \
- i915_pvinfo.h \
- i915_reg.h \
- i915_scheduler_types.h \
- i915_timeline_types.h \
- i915_utils.h \
- i915_vgpu.h \
- intel_csr.h \
- intel_drv.h \
- intel_guc_ct.h \
- intel_guc_fwif.h \
- intel_guc_reg.h \
- intel_gvt.h \
- intel_pm.h \
- intel_runtime_pm.h \
- intel_sideband.h \
- intel_uc_fw.h \
- intel_uncore.h \
- intel_wakeref.h
+header_test := $(notdir $(filter-out $(src)/i915_oa_%.h,$(wildcard $(src)/*.h)))
quiet_cmd_header_test = HDRTEST $@
cmd_header_test = echo "\#include \"$(<F)\"" > $@
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: drm/i915: last bits to make headers self-contained
2019-06-17 9:50 drm/i915: last bits to make headers self-contained Jani Nikula
` (10 preceding siblings ...)
2019-06-17 9:51 ` [PATCH 11/11] drm/i915: use wildcard to ensure all headers stay self-contained Jani Nikula
@ 2019-06-17 12:15 ` Chris Wilson
2019-06-17 15:41 ` ✗ Fi.CI.SPARSE: warning for series starting with [01/11] drm/i915: make i915_fixed.h self-contained Patchwork
2019-06-17 16:18 ` ✓ Fi.CI.BAT: success " Patchwork
13 siblings, 0 replies; 17+ messages in thread
From: Chris Wilson @ 2019-06-17 12:15 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Quoting Jani Nikula (2019-06-17 10:50:57)
> After this, all headers except display/intel_vbt_defs.h (which is also
> copy-pasted to userspace) and i915_oa_*.h (which are generated files)
> are self-contained.
All looked fine,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread* ✗ Fi.CI.SPARSE: warning for series starting with [01/11] drm/i915: make i915_fixed.h self-contained
2019-06-17 9:50 drm/i915: last bits to make headers self-contained Jani Nikula
` (11 preceding siblings ...)
2019-06-17 12:15 ` drm/i915: last bits to make headers self-contained Chris Wilson
@ 2019-06-17 15:41 ` Patchwork
2019-06-17 16:18 ` ✓ Fi.CI.BAT: success " Patchwork
13 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-06-17 15:41 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: series starting with [01/11] drm/i915: make i915_fixed.h self-contained
URL : https://patchwork.freedesktop.org/series/62192/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: make i915_fixed.h self-contained
Okay!
Commit: drm/i915: make i915_gem_gtt.h self-contained
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
Commit: drm/i915: make i915_globals.h self-contained
Okay!
Commit: drm/i915: make i915_pvinfo.h self-contained
Okay!
Commit: drm/i915: make i915_vgpu.h self-contained
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
Commit: drm/i915: make intel_guc_ct.h self-contained
Okay!
Commit: drm/i915: make intel_guc_fwif.h self-contained
Okay!
Commit: drm/i915: make intel_guc_reg.h self-contained
Okay!
Commit: drm/i915: make intel_gvt.h self-contained
Okay!
Commit: drm/i915: make intel_uc_fw.h self-contained
Okay!
Commit: drm/i915: use wildcard to ensure all headers stay self-contained
-
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
+./include/uapi/linux/perf_event.h:147:56: warning: cast truncates bits from constant value (8000000000000000 becomes 0)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread* ✓ Fi.CI.BAT: success for series starting with [01/11] drm/i915: make i915_fixed.h self-contained
2019-06-17 9:50 drm/i915: last bits to make headers self-contained Jani Nikula
` (12 preceding siblings ...)
2019-06-17 15:41 ` ✗ Fi.CI.SPARSE: warning for series starting with [01/11] drm/i915: make i915_fixed.h self-contained Patchwork
@ 2019-06-17 16:18 ` Patchwork
13 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2019-06-17 16:18 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: series starting with [01/11] drm/i915: make i915_fixed.h self-contained
URL : https://patchwork.freedesktop.org/series/62192/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6286 -> Patchwork_13305
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13305/
Known issues
------------
Here are the changes found in Patchwork_13305 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_basic@bad-close:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-icl-u3/igt@gem_basic@bad-close.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13305/fi-icl-u3/igt@gem_basic@bad-close.html
* igt@gem_ctx_switch@basic-default:
- fi-icl-y: [PASS][3] -> [INCOMPLETE][4] ([fdo#107713] / [fdo#108569])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-icl-y/igt@gem_ctx_switch@basic-default.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13305/fi-icl-y/igt@gem_ctx_switch@basic-default.html
* igt@i915_selftest@live_hangcheck:
- fi-icl-u2: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713] / [fdo#108569])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13305/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
* igt@i915_selftest@live_reset:
- fi-bsw-kefka: [PASS][7] -> [DMESG-WARN][8] ([fdo#107709])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-bsw-kefka/igt@i915_selftest@live_reset.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13305/fi-bsw-kefka/igt@i915_selftest@live_reset.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-icl-dsi: [PASS][9] -> [DMESG-WARN][10] ([fdo#106107])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-icl-dsi/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13305/fi-icl-dsi/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@prime_vgem@basic-fence-flip:
- fi-ilk-650: [PASS][11] -> [DMESG-WARN][12] ([fdo#106387]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-ilk-650/igt@prime_vgem@basic-fence-flip.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13305/fi-ilk-650/igt@prime_vgem@basic-fence-flip.html
#### Possible fixes ####
* igt@gem_ctx_switch@basic-default:
- fi-icl-guc: [INCOMPLETE][13] ([fdo#107713] / [fdo#108569]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-icl-guc/igt@gem_ctx_switch@basic-default.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13305/fi-icl-guc/igt@gem_ctx_switch@basic-default.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][15] ([fdo#109485]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13305/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [FAIL][17] ([fdo#103167]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13305/fi-icl-u2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-ilk-650: [DMESG-WARN][19] ([fdo#106387]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6286/fi-ilk-650/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13305/fi-ilk-650/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
[fdo#107709]: https://bugs.freedesktop.org/show_bug.cgi?id=107709
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
Participating hosts (46 -> 39)
------------------------------
Additional (1): fi-pnv-d510
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-8809g fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6286 -> Patchwork_13305
CI_DRM_6286: 4853198e8f13330c123082ef1f0759d476ca62d8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5059: 1f67ee0d09d6513f487f2be74aae9700e755258a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13305: 1ade6ac44ed24e8fae4b16f19aa8455328f31acb @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
1ade6ac44ed2 drm/i915: use wildcard to ensure all headers stay self-contained
077ef1c2f625 drm/i915: make intel_uc_fw.h self-contained
6ac9cac9d5e3 drm/i915: make intel_gvt.h self-contained
e6667bd4c3d1 drm/i915: make intel_guc_reg.h self-contained
fe22d174190b drm/i915: make intel_guc_fwif.h self-contained
f20af320a263 drm/i915: make intel_guc_ct.h self-contained
50c57049cfa9 drm/i915: make i915_vgpu.h self-contained
82e2baae1150 drm/i915: make i915_pvinfo.h self-contained
c91b88b5ea58 drm/i915: make i915_globals.h self-contained
6262af325b07 drm/i915: make i915_gem_gtt.h self-contained
8e6b7603e76b drm/i915: make i915_fixed.h self-contained
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13305/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread