public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/5] drm/i915/icl: Drop port parameter to icl_get_combo_buf_trans()
Date: Thu, 20 Jun 2019 19:01:28 -0700	[thread overview]
Message-ID: <20190621020132.1164-2-matthew.d.roper@intel.com> (raw)
In-Reply-To: <20190621020132.1164-1-matthew.d.roper@intel.com>

The port parameter hasn't been used since the last bspec phy programming
update.  Drop it to make some upcoming changes simpler.

References: 9659c1af451a ("drm/i915/icl: combo port vswing programming changes per BSPEC")
Cc: Clint Taylor <clinton.a.taylor@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 7925a176f900..593806d44ad4 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -846,8 +846,8 @@ cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv, int *n_entries)
 }
 
 static const struct cnl_ddi_buf_trans *
-icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, enum port port,
-			int type, int rate, int *n_entries)
+icl_get_combo_buf_trans(struct drm_i915_private *dev_priv, int type, int rate,
+			int *n_entries)
 {
 	if (type == INTEL_OUTPUT_HDMI) {
 		*n_entries = ARRAY_SIZE(icl_combo_phy_ddi_translations_hdmi);
@@ -872,7 +872,7 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
 
 	if (INTEL_GEN(dev_priv) >= 11) {
 		if (intel_port_is_combophy(dev_priv, port))
-			icl_get_combo_buf_trans(dev_priv, port, INTEL_OUTPUT_HDMI,
+			icl_get_combo_buf_trans(dev_priv, INTEL_OUTPUT_HDMI,
 						0, &n_entries);
 		else
 			n_entries = ARRAY_SIZE(icl_mg_phy_ddi_translations);
@@ -2231,7 +2231,7 @@ u8 intel_ddi_dp_voltage_max(struct intel_encoder *encoder)
 
 	if (INTEL_GEN(dev_priv) >= 11) {
 		if (intel_port_is_combophy(dev_priv, port))
-			icl_get_combo_buf_trans(dev_priv, port, encoder->type,
+			icl_get_combo_buf_trans(dev_priv, encoder->type,
 						intel_dp->link_rate, &n_entries);
 		else
 			n_entries = ARRAY_SIZE(icl_mg_phy_ddi_translations);
@@ -2420,8 +2420,8 @@ static void icl_ddi_combo_vswing_program(struct drm_i915_private *dev_priv,
 	u32 n_entries, val;
 	int ln;
 
-	ddi_translations = icl_get_combo_buf_trans(dev_priv, port, type,
-						   rate, &n_entries);
+	ddi_translations = icl_get_combo_buf_trans(dev_priv, type, rate,
+						   &n_entries);
 	if (!ddi_translations)
 		return;
 
-- 
2.17.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2019-06-21  2:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21  2:01 [PATCH 0/5] EHL port programming Matt Roper
2019-06-21  2:01 ` Matt Roper [this message]
2019-06-21 22:23   ` [PATCH 1/5] drm/i915/icl: Drop port parameter to icl_get_combo_buf_trans() Clinton Taylor
2019-06-21  2:01 ` [PATCH 2/5] drm/i915/ehl: Add third combo PHY offset Matt Roper
2019-06-21 20:19   ` Souza, Jose
2019-06-21  2:01 ` [PATCH 3/5] drm/i915/ehl: Don't program PHY_MISC on EHL PHY C Matt Roper
2019-06-21 20:34   ` Souza, Jose
2019-06-21  2:01 ` [PATCH 4/5] drm/i915/gen11: Start distinguishing 'phy' from 'port' Matt Roper
2019-06-21 14:08   ` Matt Roper
2019-06-22  0:24     ` Souza, Jose
2019-06-25 12:46       ` Ville Syrjälä
2019-06-25 20:54       ` Matt Roper
2019-06-21  2:01 ` [PATCH 5/5] drm/i915/ehl: Enable DDI-D Matt Roper
2019-06-21 20:52   ` Souza, Jose
2019-06-25 22:19     ` Matt Roper
2019-06-26 21:11       ` Souza, Jose
2019-06-21  2:27 ` ✗ Fi.CI.CHECKPATCH: warning for EHL port programming Patchwork
2019-06-21  2:30 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-06-21  3:04 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-21  9:09 ` ✓ Fi.CI.IGT: " Patchwork
2019-06-21 14:36 ` ✗ Fi.CI.CHECKPATCH: warning for EHL port programming (rev2) Patchwork
2019-06-21 14:59 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-21 21:21 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190621020132.1164-2-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox