From: Patchwork <patchwork@emeril.freedesktop.org>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for EHL port programming (rev2)
Date: Fri, 21 Jun 2019 14:36:35 -0000 [thread overview]
Message-ID: <20190621143635.9269.96930@emeril.freedesktop.org> (raw)
In-Reply-To: <20190621020132.1164-1-matthew.d.roper@intel.com>
== Series Details ==
Series: EHL port programming (rev2)
URL : https://patchwork.freedesktop.org/series/62492/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
5685d98b6706 drm/i915/icl: Drop port parameter to icl_get_combo_buf_trans()
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10:
References: 9659c1af451a ("drm/i915/icl: combo port vswing programming changes per BSPEC")
-:10: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9659c1af451a ("drm/i915/icl: combo port vswing programming changes per BSPEC")'
#10:
References: 9659c1af451a ("drm/i915/icl: combo port vswing programming changes per BSPEC")
total: 1 errors, 1 warnings, 0 checks, 36 lines checked
a396b4e39927 drm/i915/ehl: Add third combo PHY offset
83b87151a761 drm/i915/ehl: Don't program PHY_MISC on EHL PHY C
be24fefad142 drm/i915/gen11: Start distinguishing 'phy' from 'port'
-:167: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__phy' - possible side-effects?
#167: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:9:
+#define for_each_combo_phy(__dev_priv, __phy) \
+ for ((__phy) = PHY_A; (__phy) < I915_MAX_PHYS; (__phy)++) \
+ for_each_if(intel_phy_is_combo(__dev_priv, __phy))
-:174: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__phy' - possible side-effects?
#174: FILE: drivers/gpu/drm/i915/display/intel_combo_phy.c:13:
+#define for_each_combo_phy_reverse(__dev_priv, __phy) \
+ for ((__phy) = I915_MAX_PHYS; (__phy)-- > PHY_A;) \
+ for_each_if(intel_phy_is_combo(__dev_priv, __phy))
-:1048: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'phy' - possible side-effects?
#1048: FILE: drivers/gpu/drm/i915/i915_reg.h:9684:
+#define DPCLKA_CFGCR0_DDI_CLK_OFF(phy) (1 << ((phy) == PHY_F ? 23 : \
+ (phy) + 10))
-:1057: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'phy' - possible side-effects?
#1057: FILE: drivers/gpu/drm/i915/i915_reg.h:9689:
+#define DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(phy) ((phy) == PHY_F ? 21 : \
+ (phy) * 2)
total: 0 errors, 0 warnings, 4 checks, 926 lines checked
4b99477f1916 drm/i915/ehl: Enable DDI-D
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-21 14:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 2:01 [PATCH 0/5] EHL port programming Matt Roper
2019-06-21 2:01 ` [PATCH 1/5] drm/i915/icl: Drop port parameter to icl_get_combo_buf_trans() Matt Roper
2019-06-21 22:23 ` Clinton Taylor
2019-06-21 2:01 ` [PATCH 2/5] drm/i915/ehl: Add third combo PHY offset Matt Roper
2019-06-21 20:19 ` Souza, Jose
2019-06-21 2:01 ` [PATCH 3/5] drm/i915/ehl: Don't program PHY_MISC on EHL PHY C Matt Roper
2019-06-21 20:34 ` Souza, Jose
2019-06-21 2:01 ` [PATCH 4/5] drm/i915/gen11: Start distinguishing 'phy' from 'port' Matt Roper
2019-06-21 14:08 ` Matt Roper
2019-06-22 0:24 ` Souza, Jose
2019-06-25 12:46 ` Ville Syrjälä
2019-06-25 20:54 ` Matt Roper
2019-06-21 2:01 ` [PATCH 5/5] drm/i915/ehl: Enable DDI-D Matt Roper
2019-06-21 20:52 ` Souza, Jose
2019-06-25 22:19 ` Matt Roper
2019-06-26 21:11 ` Souza, Jose
2019-06-21 2:27 ` ✗ Fi.CI.CHECKPATCH: warning for EHL port programming Patchwork
2019-06-21 2:30 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-06-21 3:04 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-21 9:09 ` ✓ Fi.CI.IGT: " Patchwork
2019-06-21 14:36 ` Patchwork [this message]
2019-06-21 14:59 ` ✓ Fi.CI.BAT: success for EHL port programming (rev2) Patchwork
2019-06-21 21:21 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621143635.9269.96930@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox