From: "Souza, Jose" <jose.souza@intel.com>
To: "Roper, Matthew D" <matthew.d.roper@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/5] drm/i915/ehl: Add third combo PHY offset
Date: Fri, 21 Jun 2019 20:19:17 +0000 [thread overview]
Message-ID: <7cae6401281570e7c493b3cb6f27bcbe74b305b4.camel@intel.com> (raw)
In-Reply-To: <20190621020132.1164-3-matthew.d.roper@intel.com>
On Thu, 2019-06-20 at 19:01 -0700, Matt Roper wrote:
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> b/drivers/gpu/drm/i915/i915_reg.h
> index 7e6009cefb18..7e748bb3f324 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -1793,8 +1793,10 @@ enum i915_power_well_id {
> */
> #define _ICL_COMBOPHY_A 0x162000
> #define _ICL_COMBOPHY_B 0x6C000
> +#define _ICL_COMBOPHY_C_EHL 0x160000
> #define _ICL_COMBOPHY(port) _PICK(port, _ICL_COMBOPHY_A, \
> - _ICL_COMBOPHY_B)
> + _ICL_COMBOPHY_B, \
> + _ICL_COMBOPHY_C_EHL)
>
Rename to _EHL_COMBOPHY_C.
With that: Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> /* CNL/ICL Port CL_DW registers */
> #define _ICL_PORT_CL_DW(dw, port) (_ICL_COMBOPHY(port) + \
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-21 20:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 2:01 [PATCH 0/5] EHL port programming Matt Roper
2019-06-21 2:01 ` [PATCH 1/5] drm/i915/icl: Drop port parameter to icl_get_combo_buf_trans() Matt Roper
2019-06-21 22:23 ` Clinton Taylor
2019-06-21 2:01 ` [PATCH 2/5] drm/i915/ehl: Add third combo PHY offset Matt Roper
2019-06-21 20:19 ` Souza, Jose [this message]
2019-06-21 2:01 ` [PATCH 3/5] drm/i915/ehl: Don't program PHY_MISC on EHL PHY C Matt Roper
2019-06-21 20:34 ` Souza, Jose
2019-06-21 2:01 ` [PATCH 4/5] drm/i915/gen11: Start distinguishing 'phy' from 'port' Matt Roper
2019-06-21 14:08 ` Matt Roper
2019-06-22 0:24 ` Souza, Jose
2019-06-25 12:46 ` Ville Syrjälä
2019-06-25 20:54 ` Matt Roper
2019-06-21 2:01 ` [PATCH 5/5] drm/i915/ehl: Enable DDI-D Matt Roper
2019-06-21 20:52 ` Souza, Jose
2019-06-25 22:19 ` Matt Roper
2019-06-26 21:11 ` Souza, Jose
2019-06-21 2:27 ` ✗ Fi.CI.CHECKPATCH: warning for EHL port programming Patchwork
2019-06-21 2:30 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-06-21 3:04 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-21 9:09 ` ✓ Fi.CI.IGT: " Patchwork
2019-06-21 14:36 ` ✗ Fi.CI.CHECKPATCH: warning for EHL port programming (rev2) Patchwork
2019-06-21 14:59 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-21 21:21 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cae6401281570e7c493b3cb6f27bcbe74b305b4.camel@intel.com \
--to=jose.souza@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox