Re: [PATCH] drm/i915/tgl: Enabling DSC on Pipe A for TGL

[Manasi Navare <manasi.d.navare@intel.com>]

On Wed, Aug 14, 2019 at 04:51:17PM -0700, Madhumitha Tolakanahalli Pradeep wrote:
> Removing restriction on Pipe A as TigerLake onwards, all the pipes support DSC.

May be elaborate this commit message a little bit something like:
"On previous platforms, DSC was not supported on Pipe A while starting TGL, its is supported
on all pipes. So remove the DSC and FEC restriction on Pipe A for TGL onwards.

> 
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Signed-off-by: Madhumitha Tolakanahalli Pradeep <madhumitha.tolakanahalli.pradeep@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 4884c87c8ed7..a5b50f93fac5 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1739,8 +1739,12 @@ static bool intel_dp_source_supports_fec(struct intel_dp *intel_dp,
>  {
>  	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
>  
> -	return INTEL_GEN(dev_priv) >= 11 &&
> -		pipe_config->cpu_transcoder != TRANSCODER_A;
> +	/* On TGL, DSC is supported on all Pipes */

                   ^^^^ FEC supported on all pipes
> +	if (INTEL_GEN(dev_priv) >= 12)
> +		return true;
> +	else
> +		return INTEL_GEN(dev_priv) == 11 &&
> +			pipe_config->cpu_transcoder != TRANSCODER_A;
>  }
>  
>  static bool intel_dp_supports_fec(struct intel_dp *intel_dp,
> @@ -1755,8 +1759,12 @@ static bool intel_dp_source_supports_dsc(struct intel_dp *intel_dp,
>  {
>  	struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
>  
> -	return INTEL_GEN(dev_priv) >= 10 &&
> -		pipe_config->cpu_transcoder != TRANSCODER_A;
> +	/* On TGL, DSC is supported on all Pipes */
> +	if (INTEL_GEN(dev_priv) >= 12)
> +		return true;
> +	else
> +		return (INTEL_GEN(dev_priv) == 10 || INTEL_GEN(dev_priv) == 11) &&

Why cant you just use INTEL_GEN(dev_priv) >=10 ?

Manasi

> +			pipe_config->cpu_transcoder != TRANSCODER_A;
>  }
>  
>  static bool intel_dp_supports_dsc(struct intel_dp *intel_dp,
> -- 
> 2.17.1
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx