* [PATCH] drm/i915: Sanitize PHY state during display core uninit
@ 2019-08-16 9:55 Imre Deak
2019-08-16 13:23 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Imre Deak @ 2019-08-16 9:55 UTC (permalink / raw)
To: intel-gfx
To work around a DMC/Punit issue on ICL where the driver's
ICL_PORT_COMP_DW8/IREFGEN PHY setting is lost when entering/exiting DC6
state, make sure to reinit the PHY whenever disabling DC states.
Similarly the driver's PHY/DBUF/CDCLK settings should have been preserved
across DC5/6 transitions, so check this on all platforms.
This gets rid of the following WARN during suspend:
Combo PHY A HW state changed unexpectedly
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
.../gpu/drm/i915/display/intel_display_power.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 374b75602141..5f2395585abc 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -966,8 +966,7 @@ static void gen9_assert_dbuf_enabled(struct drm_i915_private *dev_priv)
"Unexpected DBuf power power state (0x%08x)\n", tmp);
}
-static void gen9_dc_off_power_well_enable(struct drm_i915_private *dev_priv,
- struct i915_power_well *power_well)
+static void gen9_disable_dc_states(struct drm_i915_private *dev_priv)
{
struct intel_cdclk_state cdclk_state = {};
@@ -991,6 +990,12 @@ static void gen9_dc_off_power_well_enable(struct drm_i915_private *dev_priv,
intel_combo_phy_init(dev_priv);
}
+static void gen9_dc_off_power_well_enable(struct drm_i915_private *dev_priv,
+ struct i915_power_well *power_well)
+{
+ gen9_disable_dc_states(dev_priv);
+}
+
static void gen9_dc_off_power_well_disable(struct drm_i915_private *dev_priv,
struct i915_power_well *power_well)
{
@@ -4521,7 +4526,7 @@ static void skl_display_core_uninit(struct drm_i915_private *dev_priv)
struct i915_power_domains *power_domains = &dev_priv->power_domains;
struct i915_power_well *well;
- gen9_set_dc_state(dev_priv, DC_STATE_DISABLE);
+ gen9_disable_dc_states(dev_priv);
gen9_dbuf_disable(dev_priv);
@@ -4582,7 +4587,7 @@ static void bxt_display_core_uninit(struct drm_i915_private *dev_priv)
struct i915_power_domains *power_domains = &dev_priv->power_domains;
struct i915_power_well *well;
- gen9_set_dc_state(dev_priv, DC_STATE_DISABLE);
+ gen9_disable_dc_states(dev_priv);
gen9_dbuf_disable(dev_priv);
@@ -4642,7 +4647,7 @@ static void cnl_display_core_uninit(struct drm_i915_private *dev_priv)
struct i915_power_domains *power_domains = &dev_priv->power_domains;
struct i915_power_well *well;
- gen9_set_dc_state(dev_priv, DC_STATE_DISABLE);
+ gen9_disable_dc_states(dev_priv);
/* 1. Disable all display engine functions -> aready done */
@@ -4709,7 +4714,7 @@ static void icl_display_core_uninit(struct drm_i915_private *dev_priv)
struct i915_power_domains *power_domains = &dev_priv->power_domains;
struct i915_power_well *well;
- gen9_set_dc_state(dev_priv, DC_STATE_DISABLE);
+ gen9_disable_dc_states(dev_priv);
/* 1. Disable all display engine functions -> aready done */
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Sanitize PHY state during display core uninit 2019-08-16 9:55 [PATCH] drm/i915: Sanitize PHY state during display core uninit Imre Deak @ 2019-08-16 13:23 ` Patchwork 2019-08-17 2:58 ` ✓ Fi.CI.IGT: " Patchwork 2019-08-19 21:43 ` [PATCH] " Souza, Jose 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2019-08-16 13:23 UTC (permalink / raw) To: Imre Deak; +Cc: intel-gfx == Series Details == Series: drm/i915: Sanitize PHY state during display core uninit URL : https://patchwork.freedesktop.org/series/65298/ State : success == Summary == CI Bug Log - changes from CI_DRM_6718 -> Patchwork_14050 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/ Known issues ------------ Here are the changes found in Patchwork_14050 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_suspend@basic-s3: - fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([fdo#107718]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html #### Possible fixes #### * igt@i915_selftest@live_execlists: - fi-skl-gvtdvm: [DMESG-FAIL][3] ([fdo#111108]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/fi-skl-gvtdvm/igt@i915_selftest@live_execlists.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483 [fdo#111108]: https://bugs.freedesktop.org/show_bug.cgi?id=111108 [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407 Participating hosts (54 -> 45) ------------------------------ Missing (9): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-skl-guc fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_6718 -> Patchwork_14050 CI-20190529: 20190529 CI_DRM_6718: b6d542cb2fbbc69487b1e83634395439a8fafa94 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5138: b9abe0bf6c478c4f6cac56bff286d6926ad8c0ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14050: edfd85985b68f1974f531b0a154461c1b62fe561 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == edfd85985b68 drm/i915: Sanitize PHY state during display core uninit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Sanitize PHY state during display core uninit 2019-08-16 9:55 [PATCH] drm/i915: Sanitize PHY state during display core uninit Imre Deak 2019-08-16 13:23 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2019-08-17 2:58 ` Patchwork 2019-08-20 13:21 ` Imre Deak 2019-08-19 21:43 ` [PATCH] " Souza, Jose 2 siblings, 1 reply; 5+ messages in thread From: Patchwork @ 2019-08-17 2:58 UTC (permalink / raw) To: Imre Deak; +Cc: intel-gfx == Series Details == Series: drm/i915: Sanitize PHY state during display core uninit URL : https://patchwork.freedesktop.org/series/65298/ State : success == Summary == CI Bug Log - changes from CI_DRM_6718_full -> Patchwork_14050_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_14050_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_eio@unwedge-stress: - shard-snb: [PASS][1] -> [FAIL][2] ([fdo#109661]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-snb6/igt@gem_eio@unwedge-stress.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-snb7/igt@gem_eio@unwedge-stress.html * igt@gem_exec_async@concurrent-writes-bsd: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#111325]) +4 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb3/igt@gem_exec_async@concurrent-writes-bsd.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb2/igt@gem_exec_async@concurrent-writes-bsd.html * igt@gem_exec_balancer@smoke: - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#110854]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb4/igt@gem_exec_balancer@smoke.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb3/igt@gem_exec_balancer@smoke.html * igt@gem_exec_flush@basic-wb-prw-default: - shard-apl: [PASS][7] -> [INCOMPLETE][8] ([fdo#103927]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-apl1/igt@gem_exec_flush@basic-wb-prw-default.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-apl6/igt@gem_exec_flush@basic-wb-prw-default.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-apl: [PASS][9] -> [DMESG-WARN][10] ([fdo#108566]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic: - shard-hsw: [PASS][11] -> [FAIL][12] ([fdo#105767]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-glk: [PASS][13] -> [FAIL][14] ([fdo#105363]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-glk2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend: - shard-hsw: [PASS][15] -> [INCOMPLETE][16] ([fdo#103540]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-hsw2/igt@kms_flip@flip-vs-suspend.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-hsw5/igt@kms_flip@flip-vs-suspend.html * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite: - shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#103167]) +2 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html * igt@kms_psr@no_drrs: - shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#108341]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb3/igt@kms_psr@no_drrs.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb1/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_sprite_mmap_gtt: - shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109441]) +1 similar issue [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html * igt@prime_busy@after-bsd2: - shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109276]) +18 similar issues [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb4/igt@prime_busy@after-bsd2.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb3/igt@prime_busy@after-bsd2.html #### Possible fixes #### * igt@gem_exec_schedule@in-order-bsd: - shard-iclb: [SKIP][25] ([fdo#111325]) -> [PASS][26] +2 similar issues [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb1/igt@gem_exec_schedule@in-order-bsd.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb7/igt@gem_exec_schedule@in-order-bsd.html * igt@gem_exec_schedule@preempt-queue-bsd1: - shard-iclb: [SKIP][27] ([fdo#109276]) -> [PASS][28] +12 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html * igt@i915_pm_rpm@system-suspend-execbuf: - shard-skl: [INCOMPLETE][29] ([fdo#104108] / [fdo#107807]) -> [PASS][30] [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-skl4/igt@i915_pm_rpm@system-suspend-execbuf.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-skl1/igt@i915_pm_rpm@system-suspend-execbuf.html * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy: - shard-hsw: [FAIL][31] ([fdo#105767]) -> [PASS][32] [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-hsw2/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-glk: [INCOMPLETE][33] ([fdo#103359] / [k.org#198133]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-glk2/igt@kms_flip@flip-vs-suspend-interruptible.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-glk8/igt@kms_flip@flip-vs-suspend-interruptible.html - shard-apl: [DMESG-WARN][35] ([fdo#108566]) -> [PASS][36] +4 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite: - shard-iclb: [FAIL][37] ([fdo#103167]) -> [PASS][38] +6 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-skl: [FAIL][39] ([fdo#108145]) -> [PASS][40] [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [FAIL][41] ([fdo#108145] / [fdo#110403]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_plane_lowres@pipe-a-tiling-x: - shard-iclb: [FAIL][43] ([fdo#103166]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html * igt@kms_plane_multiple@atomic-pipe-c-tiling-y: - shard-skl: [DMESG-WARN][45] ([fdo#106885]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-skl9/igt@kms_plane_multiple@atomic-pipe-c-tiling-y.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-skl6/igt@kms_plane_multiple@atomic-pipe-c-tiling-y.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [SKIP][47] ([fdo#109441]) -> [PASS][48] [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html * igt@perf@polling: - shard-skl: [FAIL][49] ([fdo#110728]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-skl3/igt@perf@polling.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-skl4/igt@perf@polling.html #### Warnings #### * igt@gem_ctx_isolation@vcs1-nonpriv: - shard-iclb: [SKIP][51] ([fdo#109276]) -> [FAIL][52] ([fdo#111329]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv.html [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767 [fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885 [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 [fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325 [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329 [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_6718 -> Patchwork_14050 CI-20190529: 20190529 CI_DRM_6718: b6d542cb2fbbc69487b1e83634395439a8fafa94 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5138: b9abe0bf6c478c4f6cac56bff286d6926ad8c0ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14050: edfd85985b68f1974f531b0a154461c1b62fe561 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ✓ Fi.CI.IGT: success for drm/i915: Sanitize PHY state during display core uninit 2019-08-17 2:58 ` ✓ Fi.CI.IGT: " Patchwork @ 2019-08-20 13:21 ` Imre Deak 0 siblings, 0 replies; 5+ messages in thread From: Imre Deak @ 2019-08-20 13:21 UTC (permalink / raw) To: intel-gfx, Jose Souza On Sat, Aug 17, 2019 at 02:58:45AM +0000, Patchwork wrote: > == Series Details == > > Series: drm/i915: Sanitize PHY state during display core uninit > URL : https://patchwork.freedesktop.org/series/65298/ > State : success Thanks for the review, pushed to -dinq. > > == Summary == > > CI Bug Log - changes from CI_DRM_6718_full -> Patchwork_14050_full > ==================================================== > > Summary > ------- > > **SUCCESS** > > No regressions found. > > > > Known issues > ------------ > > Here are the changes found in Patchwork_14050_full that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@gem_eio@unwedge-stress: > - shard-snb: [PASS][1] -> [FAIL][2] ([fdo#109661]) > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-snb6/igt@gem_eio@unwedge-stress.html > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-snb7/igt@gem_eio@unwedge-stress.html > > * igt@gem_exec_async@concurrent-writes-bsd: > - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#111325]) +4 similar issues > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb3/igt@gem_exec_async@concurrent-writes-bsd.html > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb2/igt@gem_exec_async@concurrent-writes-bsd.html > > * igt@gem_exec_balancer@smoke: > - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#110854]) > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb4/igt@gem_exec_balancer@smoke.html > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb3/igt@gem_exec_balancer@smoke.html > > * igt@gem_exec_flush@basic-wb-prw-default: > - shard-apl: [PASS][7] -> [INCOMPLETE][8] ([fdo#103927]) +1 similar issue > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-apl1/igt@gem_exec_flush@basic-wb-prw-default.html > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-apl6/igt@gem_exec_flush@basic-wb-prw-default.html > > * igt@kms_cursor_crc@pipe-c-cursor-suspend: > - shard-apl: [PASS][9] -> [DMESG-WARN][10] ([fdo#108566]) > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-suspend.html > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html > > * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic: > - shard-hsw: [PASS][11] -> [FAIL][12] ([fdo#105767]) > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html > > * igt@kms_flip@flip-vs-expired-vblank-interruptible: > - shard-glk: [PASS][13] -> [FAIL][14] ([fdo#105363]) > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible.html > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-glk2/igt@kms_flip@flip-vs-expired-vblank-interruptible.html > > * igt@kms_flip@flip-vs-suspend: > - shard-hsw: [PASS][15] -> [INCOMPLETE][16] ([fdo#103540]) > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-hsw2/igt@kms_flip@flip-vs-suspend.html > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-hsw5/igt@kms_flip@flip-vs-suspend.html > > * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite: > - shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#103167]) +2 similar issues > [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html > [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html > > * igt@kms_psr@no_drrs: > - shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#108341]) > [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb3/igt@kms_psr@no_drrs.html > [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb1/igt@kms_psr@no_drrs.html > > * igt@kms_psr@psr2_sprite_mmap_gtt: > - shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109441]) +1 similar issue > [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html > [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html > > * igt@prime_busy@after-bsd2: > - shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109276]) +18 similar issues > [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb4/igt@prime_busy@after-bsd2.html > [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb3/igt@prime_busy@after-bsd2.html > > > #### Possible fixes #### > > * igt@gem_exec_schedule@in-order-bsd: > - shard-iclb: [SKIP][25] ([fdo#111325]) -> [PASS][26] +2 similar issues > [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb1/igt@gem_exec_schedule@in-order-bsd.html > [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb7/igt@gem_exec_schedule@in-order-bsd.html > > * igt@gem_exec_schedule@preempt-queue-bsd1: > - shard-iclb: [SKIP][27] ([fdo#109276]) -> [PASS][28] +12 similar issues > [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html > [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html > > * igt@i915_pm_rpm@system-suspend-execbuf: > - shard-skl: [INCOMPLETE][29] ([fdo#104108] / [fdo#107807]) -> [PASS][30] > [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-skl4/igt@i915_pm_rpm@system-suspend-execbuf.html > [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-skl1/igt@i915_pm_rpm@system-suspend-execbuf.html > > * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy: > - shard-hsw: [FAIL][31] ([fdo#105767]) -> [PASS][32] > [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html > [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-hsw2/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html > > * igt@kms_flip@flip-vs-suspend-interruptible: > - shard-glk: [INCOMPLETE][33] ([fdo#103359] / [k.org#198133]) -> [PASS][34] > [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-glk2/igt@kms_flip@flip-vs-suspend-interruptible.html > [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-glk8/igt@kms_flip@flip-vs-suspend-interruptible.html > - shard-apl: [DMESG-WARN][35] ([fdo#108566]) -> [PASS][36] +4 similar issues > [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible.html > [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible.html > > * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite: > - shard-iclb: [FAIL][37] ([fdo#103167]) -> [PASS][38] +6 similar issues > [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html > [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html > > * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: > - shard-skl: [FAIL][39] ([fdo#108145]) -> [PASS][40] > [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html > [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html > > * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: > - shard-skl: [FAIL][41] ([fdo#108145] / [fdo#110403]) -> [PASS][42] > [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html > [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html > > * igt@kms_plane_lowres@pipe-a-tiling-x: > - shard-iclb: [FAIL][43] ([fdo#103166]) -> [PASS][44] > [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html > [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html > > * igt@kms_plane_multiple@atomic-pipe-c-tiling-y: > - shard-skl: [DMESG-WARN][45] ([fdo#106885]) -> [PASS][46] > [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-skl9/igt@kms_plane_multiple@atomic-pipe-c-tiling-y.html > [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-skl6/igt@kms_plane_multiple@atomic-pipe-c-tiling-y.html > > * igt@kms_psr@psr2_sprite_plane_move: > - shard-iclb: [SKIP][47] ([fdo#109441]) -> [PASS][48] > [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb4/igt@kms_psr@psr2_sprite_plane_move.html > [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html > > * igt@perf@polling: > - shard-skl: [FAIL][49] ([fdo#110728]) -> [PASS][50] > [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-skl3/igt@perf@polling.html > [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-skl4/igt@perf@polling.html > > > #### Warnings #### > > * igt@gem_ctx_isolation@vcs1-nonpriv: > - shard-iclb: [SKIP][51] ([fdo#109276]) -> [FAIL][52] ([fdo#111329]) > [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6718/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html > [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv.html > > > [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 > [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 > [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359 > [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 > [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 > [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 > [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 > [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767 > [fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885 > [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807 > [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 > [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341 > [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 > [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 > [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 > [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661 > [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 > [fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728 > [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 > [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325 > [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329 > [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133 > > > Participating hosts (10 -> 10) > ------------------------------ > > No changes in participating hosts > > > Build changes > ------------- > > * CI: CI-20190529 -> None > * Linux: CI_DRM_6718 -> Patchwork_14050 > > CI-20190529: 20190529 > CI_DRM_6718: b6d542cb2fbbc69487b1e83634395439a8fafa94 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_5138: b9abe0bf6c478c4f6cac56bff286d6926ad8c0ab @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_14050: edfd85985b68f1974f531b0a154461c1b62fe561 @ git://anongit.freedesktop.org/gfx-ci/linux > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14050/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Sanitize PHY state during display core uninit 2019-08-16 9:55 [PATCH] drm/i915: Sanitize PHY state during display core uninit Imre Deak 2019-08-16 13:23 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-08-17 2:58 ` ✓ Fi.CI.IGT: " Patchwork @ 2019-08-19 21:43 ` Souza, Jose 2 siblings, 0 replies; 5+ messages in thread From: Souza, Jose @ 2019-08-19 21:43 UTC (permalink / raw) To: intel-gfx@lists.freedesktop.org, Deak, Imre On Fri, 2019-08-16 at 12:55 +0300, Imre Deak wrote: > To work around a DMC/Punit issue on ICL where the driver's > ICL_PORT_COMP_DW8/IREFGEN PHY setting is lost when entering/exiting > DC6 > state, make sure to reinit the PHY whenever disabling DC states. > Similarly the driver's PHY/DBUF/CDCLK settings should have been > preserved > across DC5/6 transitions, so check this on all platforms. > > This gets rid of the following WARN during suspend: > Combo PHY A HW state changed unexpectedly Reviewed-by: José Roberto de Souza <jose.souza@intel.com> > > Signed-off-by: Imre Deak <imre.deak@intel.com> > --- > .../gpu/drm/i915/display/intel_display_power.c | 17 +++++++++++-- > ---- > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c > b/drivers/gpu/drm/i915/display/intel_display_power.c > index 374b75602141..5f2395585abc 100644 > --- a/drivers/gpu/drm/i915/display/intel_display_power.c > +++ b/drivers/gpu/drm/i915/display/intel_display_power.c > @@ -966,8 +966,7 @@ static void gen9_assert_dbuf_enabled(struct > drm_i915_private *dev_priv) > "Unexpected DBuf power power state (0x%08x)\n", tmp); > } > > -static void gen9_dc_off_power_well_enable(struct drm_i915_private > *dev_priv, > - struct i915_power_well > *power_well) > +static void gen9_disable_dc_states(struct drm_i915_private > *dev_priv) > { > struct intel_cdclk_state cdclk_state = {}; > > @@ -991,6 +990,12 @@ static void gen9_dc_off_power_well_enable(struct > drm_i915_private *dev_priv, > intel_combo_phy_init(dev_priv); > } > > +static void gen9_dc_off_power_well_enable(struct drm_i915_private > *dev_priv, > + struct i915_power_well > *power_well) > +{ > + gen9_disable_dc_states(dev_priv); > +} > + > static void gen9_dc_off_power_well_disable(struct drm_i915_private > *dev_priv, > struct i915_power_well > *power_well) > { > @@ -4521,7 +4526,7 @@ static void skl_display_core_uninit(struct > drm_i915_private *dev_priv) > struct i915_power_domains *power_domains = &dev_priv- > >power_domains; > struct i915_power_well *well; > > - gen9_set_dc_state(dev_priv, DC_STATE_DISABLE); > + gen9_disable_dc_states(dev_priv); > > gen9_dbuf_disable(dev_priv); > > @@ -4582,7 +4587,7 @@ static void bxt_display_core_uninit(struct > drm_i915_private *dev_priv) > struct i915_power_domains *power_domains = &dev_priv- > >power_domains; > struct i915_power_well *well; > > - gen9_set_dc_state(dev_priv, DC_STATE_DISABLE); > + gen9_disable_dc_states(dev_priv); > > gen9_dbuf_disable(dev_priv); > > @@ -4642,7 +4647,7 @@ static void cnl_display_core_uninit(struct > drm_i915_private *dev_priv) > struct i915_power_domains *power_domains = &dev_priv- > >power_domains; > struct i915_power_well *well; > > - gen9_set_dc_state(dev_priv, DC_STATE_DISABLE); > + gen9_disable_dc_states(dev_priv); > > /* 1. Disable all display engine functions -> aready done */ > > @@ -4709,7 +4714,7 @@ static void icl_display_core_uninit(struct > drm_i915_private *dev_priv) > struct i915_power_domains *power_domains = &dev_priv- > >power_domains; > struct i915_power_well *well; > > - gen9_set_dc_state(dev_priv, DC_STATE_DISABLE); > + gen9_disable_dc_states(dev_priv); > > /* 1. Disable all display engine functions -> aready done */ > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-20 13:22 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-08-16 9:55 [PATCH] drm/i915: Sanitize PHY state during display core uninit Imre Deak 2019-08-16 13:23 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-08-17 2:58 ` ✓ Fi.CI.IGT: " Patchwork 2019-08-20 13:21 ` Imre Deak 2019-08-19 21:43 ` [PATCH] " Souza, Jose
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox