From: Patchwork <patchwork@emeril.freedesktop.org>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for DP AUX updates (rev3)
Date: Sat, 26 Oct 2019 06:26:43 -0000 [thread overview]
Message-ID: <20191026062643.22476.82450@emeril.freedesktop.org> (raw)
In-Reply-To: <20191025230623.27829-1-matthew.d.roper@intel.com>
== Series Details ==
Series: DP AUX updates (rev3)
URL : https://patchwork.freedesktop.org/series/68590/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e8d35bb35f25 drm/i915/tgl: Handle AUX interrupts for TC ports
8902f9c59666 drm/i915: Drop unused AUX register offsets
-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#48: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2879:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_B), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
-:51: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#51: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2881:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_C), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
-:54: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#54: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2883:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_D), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
total: 0 errors, 0 warnings, 3 checks, 79 lines checked
ec5b0b7e9f53 drm/i915: Add missing AUX channel H & I support
-:75: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#75: FILE: drivers/gpu/drm/i915/display/intel_display.c:6862:
+ return POWER_DOMAIN_AUX_A + dig_port->aux_ch;
+ } else {
total: 0 errors, 1 warnings, 0 checks, 91 lines checked
cd4efc30f3a8 drm/i915: Provide more information on DP AUX failures
4eb074ab8c76 drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Matt Roper" <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DP AUX updates (rev3)
Date: Sat, 26 Oct 2019 06:26:43 -0000 [thread overview]
Message-ID: <20191026062643.22476.82450@emeril.freedesktop.org> (raw)
Message-ID: <20191026062643.4RHlbe46-rjR206t-ZiAMziJVrQpisux2WN3H16hm6A@z> (raw)
In-Reply-To: <20191025230623.27829-1-matthew.d.roper@intel.com>
== Series Details ==
Series: DP AUX updates (rev3)
URL : https://patchwork.freedesktop.org/series/68590/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e8d35bb35f25 drm/i915/tgl: Handle AUX interrupts for TC ports
8902f9c59666 drm/i915: Drop unused AUX register offsets
-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#48: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2879:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_B), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
-:51: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#51: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2881:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_C), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
-:54: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#54: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2883:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_D), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
total: 0 errors, 0 warnings, 3 checks, 79 lines checked
ec5b0b7e9f53 drm/i915: Add missing AUX channel H & I support
-:75: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#75: FILE: drivers/gpu/drm/i915/display/intel_display.c:6862:
+ return POWER_DOMAIN_AUX_A + dig_port->aux_ch;
+ } else {
total: 0 errors, 1 warnings, 0 checks, 91 lines checked
cd4efc30f3a8 drm/i915: Provide more information on DP AUX failures
4eb074ab8c76 drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-26 6:26 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 23:06 [PATCH 0/5] DP AUX updates Matt Roper
2019-10-25 23:06 ` [Intel-gfx] " Matt Roper
2019-10-25 23:06 ` [PATCH 1/5] drm/i915/tgl: Handle AUX interrupts for TC ports Matt Roper
2019-10-25 23:06 ` [Intel-gfx] " Matt Roper
2019-10-25 23:11 ` Lucas De Marchi
2019-10-25 23:11 ` [Intel-gfx] " Lucas De Marchi
2019-10-25 23:06 ` [PATCH 2/5] drm/i915: Drop unused AUX register offsets Matt Roper
2019-10-25 23:06 ` [Intel-gfx] " Matt Roper
2019-10-25 23:11 ` Lucas De Marchi
2019-10-25 23:11 ` [Intel-gfx] " Lucas De Marchi
2019-10-26 5:12 ` Matt Roper
2019-10-26 5:12 ` [Intel-gfx] " Matt Roper
2019-10-25 23:06 ` [PATCH 3/5] drm/i915: Add missing AUX channel H & I support Matt Roper
2019-10-25 23:06 ` [Intel-gfx] " Matt Roper
2019-10-25 23:13 ` Lucas De Marchi
2019-10-25 23:13 ` [Intel-gfx] " Lucas De Marchi
2019-10-28 14:57 ` Matt Roper
2019-10-28 14:57 ` [Intel-gfx] " Matt Roper
2019-10-29 17:59 ` Lucas De Marchi
2019-10-29 17:59 ` [Intel-gfx] " Lucas De Marchi
2019-10-25 23:06 ` [PATCH 4/5] drm/i915: Provide more information on DP AUX failures Matt Roper
2019-10-25 23:06 ` [Intel-gfx] " Matt Roper
2019-10-25 23:19 ` Lucas De Marchi
2019-10-25 23:19 ` [Intel-gfx] " Lucas De Marchi
2019-10-25 23:25 ` Matt Roper
2019-10-25 23:25 ` [Intel-gfx] " Matt Roper
2019-10-25 23:32 ` Lucas De Marchi
2019-10-25 23:32 ` [Intel-gfx] " Lucas De Marchi
2019-10-29 17:31 ` [PATCH v2 " Matt Roper
2019-10-29 17:31 ` [Intel-gfx] " Matt Roper
2019-10-29 19:33 ` Lucas De Marchi
2019-10-29 19:33 ` [Intel-gfx] " Lucas De Marchi
2019-10-28 16:43 ` [PATCH " Ville Syrjälä
2019-10-28 16:43 ` [Intel-gfx] " Ville Syrjälä
2019-10-25 23:06 ` [PATCH 5/5] drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS Matt Roper
2019-10-25 23:06 ` [Intel-gfx] " Matt Roper
2019-10-25 23:24 ` Lucas De Marchi
2019-10-25 23:24 ` [Intel-gfx] " Lucas De Marchi
2019-10-26 8:57 ` Imre Deak
2019-10-26 8:57 ` [Intel-gfx] " Imre Deak
2019-10-26 1:09 ` ✗ Fi.CI.BUILD: failure for DP AUX updates Patchwork
2019-10-26 1:09 ` [Intel-gfx] " Patchwork
2019-10-26 5:37 ` ✗ Fi.CI.CHECKPATCH: warning for DP AUX updates (rev2) Patchwork
2019-10-26 5:37 ` [Intel-gfx] " Patchwork
2019-10-26 5:57 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-10-26 5:57 ` [Intel-gfx] " Patchwork
2019-10-26 6:26 ` Patchwork [this message]
2019-10-26 6:26 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DP AUX updates (rev3) Patchwork
2019-10-26 6:47 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-26 6:47 ` [Intel-gfx] " Patchwork
2019-10-28 1:02 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-28 1:02 ` [Intel-gfx] " Patchwork
2019-10-29 17:58 ` Matt Roper
2019-10-29 17:58 ` [Intel-gfx] " Matt Roper
2019-10-29 19:56 ` Matt Roper
2019-10-29 19:56 ` [Intel-gfx] " Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191026062643.22476.82450@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox