From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/i915: Provide more information on DP AUX failures
Date: Mon, 28 Oct 2019 18:43:12 +0200 [thread overview]
Message-ID: <20191028164312.GQ1208@intel.com> (raw)
In-Reply-To: <20191025230623.27829-5-matthew.d.roper@intel.com>
On Fri, Oct 25, 2019 at 04:06:22PM -0700, Matt Roper wrote:
> We're seeing some failures where an aux transaction still shows as
> 'busy' well after the timeout limit that the hardware is supposed to
> enforce. Improve the error message so that we can see exactly which aux
> channel this error happened on and what the status bits were during this
> case that isn't supposed to happen.
Pretty sure I have a patch somewhere that adds the aux name
to all the messages. I should probably dig that up and post it.
>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 65bab46f7b43..2b4915b5cf52 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1190,7 +1190,8 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>
> if (!done)
> - DRM_ERROR("dp aux hw did not signal timeout!\n");
> + DRM_ERROR("%s did not complete or timeout within 10ms (status 0x%08x)\n",
> + intel_dp->aux.name ?: "AUX", status);
> #undef C
>
> return status;
> --
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 4/5] drm/i915: Provide more information on DP AUX failures
Date: Mon, 28 Oct 2019 18:43:12 +0200 [thread overview]
Message-ID: <20191028164312.GQ1208@intel.com> (raw)
Message-ID: <20191028164312.25O9aC0URTw_EYJ-3W_UVJwqqgdXBKB4Oug8CDEhZxw@z> (raw)
In-Reply-To: <20191025230623.27829-5-matthew.d.roper@intel.com>
On Fri, Oct 25, 2019 at 04:06:22PM -0700, Matt Roper wrote:
> We're seeing some failures where an aux transaction still shows as
> 'busy' well after the timeout limit that the hardware is supposed to
> enforce. Improve the error message so that we can see exactly which aux
> channel this error happened on and what the status bits were during this
> case that isn't supposed to happen.
Pretty sure I have a patch somewhere that adds the aux name
to all the messages. I should probably dig that up and post it.
>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 65bab46f7b43..2b4915b5cf52 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1190,7 +1190,8 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>
> if (!done)
> - DRM_ERROR("dp aux hw did not signal timeout!\n");
> + DRM_ERROR("%s did not complete or timeout within 10ms (status 0x%08x)\n",
> + intel_dp->aux.name ?: "AUX", status);
> #undef C
>
> return status;
> --
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-28 16:43 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 23:06 [PATCH 0/5] DP AUX updates Matt Roper
2019-10-25 23:06 ` [Intel-gfx] " Matt Roper
2019-10-25 23:06 ` [PATCH 1/5] drm/i915/tgl: Handle AUX interrupts for TC ports Matt Roper
2019-10-25 23:06 ` [Intel-gfx] " Matt Roper
2019-10-25 23:11 ` Lucas De Marchi
2019-10-25 23:11 ` [Intel-gfx] " Lucas De Marchi
2019-10-25 23:06 ` [PATCH 2/5] drm/i915: Drop unused AUX register offsets Matt Roper
2019-10-25 23:06 ` [Intel-gfx] " Matt Roper
2019-10-25 23:11 ` Lucas De Marchi
2019-10-25 23:11 ` [Intel-gfx] " Lucas De Marchi
2019-10-26 5:12 ` Matt Roper
2019-10-26 5:12 ` [Intel-gfx] " Matt Roper
2019-10-25 23:06 ` [PATCH 3/5] drm/i915: Add missing AUX channel H & I support Matt Roper
2019-10-25 23:06 ` [Intel-gfx] " Matt Roper
2019-10-25 23:13 ` Lucas De Marchi
2019-10-25 23:13 ` [Intel-gfx] " Lucas De Marchi
2019-10-28 14:57 ` Matt Roper
2019-10-28 14:57 ` [Intel-gfx] " Matt Roper
2019-10-29 17:59 ` Lucas De Marchi
2019-10-29 17:59 ` [Intel-gfx] " Lucas De Marchi
2019-10-25 23:06 ` [PATCH 4/5] drm/i915: Provide more information on DP AUX failures Matt Roper
2019-10-25 23:06 ` [Intel-gfx] " Matt Roper
2019-10-25 23:19 ` Lucas De Marchi
2019-10-25 23:19 ` [Intel-gfx] " Lucas De Marchi
2019-10-25 23:25 ` Matt Roper
2019-10-25 23:25 ` [Intel-gfx] " Matt Roper
2019-10-25 23:32 ` Lucas De Marchi
2019-10-25 23:32 ` [Intel-gfx] " Lucas De Marchi
2019-10-29 17:31 ` [PATCH v2 " Matt Roper
2019-10-29 17:31 ` [Intel-gfx] " Matt Roper
2019-10-29 19:33 ` Lucas De Marchi
2019-10-29 19:33 ` [Intel-gfx] " Lucas De Marchi
2019-10-28 16:43 ` Ville Syrjälä [this message]
2019-10-28 16:43 ` [Intel-gfx] [PATCH " Ville Syrjälä
2019-10-25 23:06 ` [PATCH 5/5] drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS Matt Roper
2019-10-25 23:06 ` [Intel-gfx] " Matt Roper
2019-10-25 23:24 ` Lucas De Marchi
2019-10-25 23:24 ` [Intel-gfx] " Lucas De Marchi
2019-10-26 8:57 ` Imre Deak
2019-10-26 8:57 ` [Intel-gfx] " Imre Deak
2019-10-26 1:09 ` ✗ Fi.CI.BUILD: failure for DP AUX updates Patchwork
2019-10-26 1:09 ` [Intel-gfx] " Patchwork
2019-10-26 5:37 ` ✗ Fi.CI.CHECKPATCH: warning for DP AUX updates (rev2) Patchwork
2019-10-26 5:37 ` [Intel-gfx] " Patchwork
2019-10-26 5:57 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-10-26 5:57 ` [Intel-gfx] " Patchwork
2019-10-26 6:26 ` ✗ Fi.CI.CHECKPATCH: warning for DP AUX updates (rev3) Patchwork
2019-10-26 6:26 ` [Intel-gfx] " Patchwork
2019-10-26 6:47 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-26 6:47 ` [Intel-gfx] " Patchwork
2019-10-28 1:02 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-28 1:02 ` [Intel-gfx] " Patchwork
2019-10-29 17:58 ` Matt Roper
2019-10-29 17:58 ` [Intel-gfx] " Matt Roper
2019-10-29 19:56 ` Matt Roper
2019-10-29 19:56 ` [Intel-gfx] " Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028164312.GQ1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox