From: Ramalingam C <ramalingam.c@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 4/9] drm/i915: Refactor debugfs display info code
Date: Mon, 2 Dec 2019 20:04:13 +0530 [thread overview]
Message-ID: <20191202143413.GB15371@intel.com> (raw)
In-Reply-To: <20191129185434.25549-5-ville.syrjala@linux.intel.com>
On 2019-11-29 at 20:54:29 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Pull the crtc dumping stuff into a nice function so the
> loop over the crtcs doesn't look like crap.
Looks good to me.
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 52 ++++++++++++++++-------------
> 1 file changed, 28 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index b4fffcce2d12..28f45f25cfc0 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2638,6 +2638,33 @@ static void intel_scaler_info(struct seq_file *m, struct intel_crtc *crtc)
> }
> }
>
> +static void intel_crtc_info(struct seq_file *m, struct intel_crtc *crtc)
> +{
> + struct drm_i915_private *dev_priv = node_to_i915(m->private);
> + const struct intel_crtc_state *crtc_state =
> + to_intel_crtc_state(crtc->base.state);
> +
> + seq_printf(m, "CRTC %d: pipe: %c, active=%s, (size=%dx%d), dither=%s, bpp=%d\n",
> + crtc->base.base.id, pipe_name(crtc->pipe),
> + yesno(crtc_state->hw.active),
> + crtc_state->pipe_src_w, crtc_state->pipe_src_h,
> + yesno(crtc_state->dither), crtc_state->pipe_bpp);
> +
> + if (crtc_state->hw.active) {
> + struct intel_encoder *encoder;
> +
> + for_each_encoder_on_crtc(&dev_priv->drm, &crtc->base, encoder)
> + intel_encoder_info(m, crtc, encoder);
> +
> + intel_scaler_info(m, crtc);
> + intel_plane_info(m, crtc);
> + }
> +
> + seq_printf(m, "\tunderrun reporting: cpu=%s pch=%s\n",
> + yesno(!crtc->cpu_fifo_underrun_disabled),
> + yesno(!crtc->pch_fifo_underrun_disabled));
> +}
> +
> static int i915_display_info(struct seq_file *m, void *unused)
> {
> struct drm_i915_private *dev_priv = node_to_i915(m->private);
> @@ -2652,31 +2679,8 @@ static int i915_display_info(struct seq_file *m, void *unused)
> seq_printf(m, "CRTC info\n");
> seq_printf(m, "---------\n");
> for_each_intel_crtc(dev, crtc) {
> - const struct intel_crtc_state *crtc_state;
> -
> drm_modeset_lock(&crtc->base.mutex, NULL);
> -
> - crtc_state = to_intel_crtc_state(crtc->base.state);
> -
> - seq_printf(m, "CRTC %d: pipe: %c, active=%s, (size=%dx%d), dither=%s, bpp=%d\n",
> - crtc->base.base.id, pipe_name(crtc->pipe),
> - yesno(crtc_state->hw.active),
> - crtc_state->pipe_src_w, crtc_state->pipe_src_h,
> - yesno(crtc_state->dither), crtc_state->pipe_bpp);
> -
> - if (crtc_state->hw.active) {
> - struct intel_encoder *encoder;
> -
> - for_each_encoder_on_crtc(dev, &crtc->base, encoder)
> - intel_encoder_info(m, crtc, encoder);
> -
> - intel_scaler_info(m, crtc);
> - intel_plane_info(m, crtc);
> - }
> -
> - seq_printf(m, "\tunderrun reporting: cpu=%s pch=%s \n",
> - yesno(!crtc->cpu_fifo_underrun_disabled),
> - yesno(!crtc->pch_fifo_underrun_disabled));
> + intel_crtc_info(m, crtc);
> drm_modeset_unlock(&crtc->base.mutex);
> }
>
> --
> 2.23.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Ramalingam C <ramalingam.c@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 4/9] drm/i915: Refactor debugfs display info code
Date: Mon, 2 Dec 2019 20:04:13 +0530 [thread overview]
Message-ID: <20191202143413.GB15371@intel.com> (raw)
Message-ID: <20191202143413.qbd8yKM3a35L6e1GuNH34unsKgVmYfCgBWdmEpTGZis@z> (raw)
In-Reply-To: <20191129185434.25549-5-ville.syrjala@linux.intel.com>
On 2019-11-29 at 20:54:29 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Pull the crtc dumping stuff into a nice function so the
> loop over the crtcs doesn't look like crap.
Looks good to me.
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 52 ++++++++++++++++-------------
> 1 file changed, 28 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index b4fffcce2d12..28f45f25cfc0 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2638,6 +2638,33 @@ static void intel_scaler_info(struct seq_file *m, struct intel_crtc *crtc)
> }
> }
>
> +static void intel_crtc_info(struct seq_file *m, struct intel_crtc *crtc)
> +{
> + struct drm_i915_private *dev_priv = node_to_i915(m->private);
> + const struct intel_crtc_state *crtc_state =
> + to_intel_crtc_state(crtc->base.state);
> +
> + seq_printf(m, "CRTC %d: pipe: %c, active=%s, (size=%dx%d), dither=%s, bpp=%d\n",
> + crtc->base.base.id, pipe_name(crtc->pipe),
> + yesno(crtc_state->hw.active),
> + crtc_state->pipe_src_w, crtc_state->pipe_src_h,
> + yesno(crtc_state->dither), crtc_state->pipe_bpp);
> +
> + if (crtc_state->hw.active) {
> + struct intel_encoder *encoder;
> +
> + for_each_encoder_on_crtc(&dev_priv->drm, &crtc->base, encoder)
> + intel_encoder_info(m, crtc, encoder);
> +
> + intel_scaler_info(m, crtc);
> + intel_plane_info(m, crtc);
> + }
> +
> + seq_printf(m, "\tunderrun reporting: cpu=%s pch=%s\n",
> + yesno(!crtc->cpu_fifo_underrun_disabled),
> + yesno(!crtc->pch_fifo_underrun_disabled));
> +}
> +
> static int i915_display_info(struct seq_file *m, void *unused)
> {
> struct drm_i915_private *dev_priv = node_to_i915(m->private);
> @@ -2652,31 +2679,8 @@ static int i915_display_info(struct seq_file *m, void *unused)
> seq_printf(m, "CRTC info\n");
> seq_printf(m, "---------\n");
> for_each_intel_crtc(dev, crtc) {
> - const struct intel_crtc_state *crtc_state;
> -
> drm_modeset_lock(&crtc->base.mutex, NULL);
> -
> - crtc_state = to_intel_crtc_state(crtc->base.state);
> -
> - seq_printf(m, "CRTC %d: pipe: %c, active=%s, (size=%dx%d), dither=%s, bpp=%d\n",
> - crtc->base.base.id, pipe_name(crtc->pipe),
> - yesno(crtc_state->hw.active),
> - crtc_state->pipe_src_w, crtc_state->pipe_src_h,
> - yesno(crtc_state->dither), crtc_state->pipe_bpp);
> -
> - if (crtc_state->hw.active) {
> - struct intel_encoder *encoder;
> -
> - for_each_encoder_on_crtc(dev, &crtc->base, encoder)
> - intel_encoder_info(m, crtc, encoder);
> -
> - intel_scaler_info(m, crtc);
> - intel_plane_info(m, crtc);
> - }
> -
> - seq_printf(m, "\tunderrun reporting: cpu=%s pch=%s \n",
> - yesno(!crtc->cpu_fifo_underrun_disabled),
> - yesno(!crtc->pch_fifo_underrun_disabled));
> + intel_crtc_info(m, crtc);
> drm_modeset_unlock(&crtc->base.mutex);
> }
>
> --
> 2.23.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-02 14:35 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 18:54 [PATCH v2 0/9] drm/i915: i915_display_info cleanup Ville Syrjala
2019-11-29 18:54 ` [Intel-gfx] " Ville Syrjala
2019-11-29 18:54 ` [PATCH v2 1/9] drm/i915: Use drm_rect to simplify plane {crtc, src}_{x, y, w, h} printing Ville Syrjala
2019-11-29 18:54 ` [Intel-gfx] " Ville Syrjala
2019-12-02 7:55 ` Ramalingam C
2019-12-02 7:55 ` [Intel-gfx] " Ramalingam C
2019-11-29 18:54 ` [PATCH v2 2/9] drm/i915: Switch to intel_ types in debugfs display_info Ville Syrjala
2019-11-29 18:54 ` [Intel-gfx] " Ville Syrjala
2019-12-02 8:59 ` Ramalingam C
2019-12-02 8:59 ` [Intel-gfx] " Ramalingam C
2019-11-29 18:54 ` [PATCH v2 3/9] drm/i915: Reorganize plane/fb dump in debugfs Ville Syrjala
2019-11-29 18:54 ` [Intel-gfx] " Ville Syrjala
2019-12-02 14:27 ` Ramalingam C
2019-12-02 14:27 ` [Intel-gfx] " Ramalingam C
2019-11-29 18:54 ` [PATCH v2 4/9] drm/i915: Refactor debugfs display info code Ville Syrjala
2019-11-29 18:54 ` [Intel-gfx] " Ville Syrjala
2019-12-02 14:34 ` Ramalingam C [this message]
2019-12-02 14:34 ` Ramalingam C
2019-11-29 18:54 ` [PATCH v2 5/9] drm/i915: Dump the mode for the crtc just the once Ville Syrjala
2019-11-29 18:54 ` [Intel-gfx] " Ville Syrjala
2019-12-02 14:56 ` Ramalingam C
2019-12-02 14:56 ` [Intel-gfx] " Ramalingam C
2019-11-29 18:54 ` [PATCH v2 6/9] drm/i915: Use drm_modeset_lock_all() in debugfs display info Ville Syrjala
2019-11-29 18:54 ` [Intel-gfx] " Ville Syrjala
2019-12-02 15:05 ` Ramalingam C
2019-12-02 15:05 ` [Intel-gfx] " Ramalingam C
2019-11-29 18:54 ` [PATCH v2 7/9] drm/i915: Use the canonical [CRTC:%d:%s]/etc. format in i915_display_info Ville Syrjala
2019-11-29 18:54 ` [Intel-gfx] " Ville Syrjala
2019-12-02 15:08 ` Ramalingam C
2019-12-02 15:08 ` [Intel-gfx] " Ramalingam C
2019-12-02 15:43 ` Ramalingam C
2019-12-02 15:43 ` [Intel-gfx] " Ramalingam C
2019-11-29 18:54 ` [PATCH v2 8/9] drm/i915: Dump both the uapi and hw states for crtcs and planes Ville Syrjala
2019-11-29 18:54 ` [Intel-gfx] " Ville Syrjala
2019-12-02 15:18 ` Ramalingam C
2019-12-02 15:18 ` [Intel-gfx] " Ramalingam C
2019-11-29 18:54 ` [PATCH v2 9/9] drm/i915: Stop using connector->encoder and encoder->crtc links in i915_display_info Ville Syrjala
2019-11-29 18:54 ` [Intel-gfx] " Ville Syrjala
2019-12-02 15:40 ` Ramalingam C
2019-12-02 15:40 ` [Intel-gfx] " Ramalingam C
2019-12-02 16:24 ` Ville Syrjälä
2019-12-02 16:24 ` [Intel-gfx] " Ville Syrjälä
2019-12-02 16:52 ` Ramalingam C
2019-12-02 16:52 ` [Intel-gfx] " Ramalingam C
2019-11-29 21:43 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: i915_display_info cleanup Patchwork
2019-11-29 21:43 ` [Intel-gfx] " Patchwork
2019-11-29 22:27 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-29 22:27 ` [Intel-gfx] " Patchwork
2019-12-01 1:15 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-12-01 1:15 ` [Intel-gfx] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202143413.GB15371@intel.com \
--to=ramalingam.c@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox