From: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: ville.syrjala@intel.com, nanley.g.chery@intel.com,
dhinakaran.pandiyan@intel.com
Subject: Re: [Intel-gfx] [PATCH v7 2/7] drm/i915: Use intel_tile_height() instead of re-implementing
Date: Thu, 12 Dec 2019 07:51:05 -0800 [thread overview]
Message-ID: <20191212155104.GB21507@InViCtUs> (raw)
In-Reply-To: <20191126002635.5779-3-radhakrishna.sripada@intel.com>
On Mon, Nov 25, 2019 at 04:26:30PM -0800, Radhakrishna Sripada wrote:
> From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>
> intel_tile_dims() computes tile height using size and width, when there
> is already a function to do just that - intel_tile_height()
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 53dc310a5f6d..2a4593afbe86 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -2017,7 +2017,7 @@ static void intel_tile_dims(const struct drm_framebuffer *fb, int color_plane,
> unsigned int cpp = fb->format->cpp[color_plane];
>
> *tile_width = tile_width_bytes / cpp;
> - *tile_height = intel_tile_size(to_i915(fb->dev)) / tile_width_bytes;
> + *tile_height = intel_tile_height(fb, color_plane);
> }
>
> unsigned int
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-12 15:58 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 0:26 [PATCH v7 0/7] Clear Color Support for TGL Render Decompression Radhakrishna Sripada
2019-11-26 0:26 ` [Intel-gfx] " Radhakrishna Sripada
2019-11-26 0:26 ` [PATCH v7 1/7] drm/framebuffer: Format modifier for Intel Gen-12 render compression Radhakrishna Sripada
2019-11-26 0:26 ` [Intel-gfx] " Radhakrishna Sripada
2019-12-12 15:49 ` Radhakrishna Sripada
2019-11-26 0:26 ` [PATCH v7 2/7] drm/i915: Use intel_tile_height() instead of re-implementing Radhakrishna Sripada
2019-11-26 0:26 ` [Intel-gfx] " Radhakrishna Sripada
2019-12-12 15:51 ` Radhakrishna Sripada [this message]
2019-11-26 0:26 ` [PATCH v7 3/7] drm/i915: Move CCS stride alignment W/A inside intel_fb_stride_alignment Radhakrishna Sripada
2019-11-26 0:26 ` [Intel-gfx] " Radhakrishna Sripada
2019-12-12 15:53 ` Radhakrishna Sripada
2019-11-26 0:26 ` [PATCH v7 4/7] drm/i915/tgl: Gen-12 render decompression Radhakrishna Sripada
2019-11-26 0:26 ` [Intel-gfx] " Radhakrishna Sripada
2019-12-12 15:59 ` Radhakrishna Sripada
2019-11-26 0:26 ` [PATCH v7 5/7] drm/i915: Extract framebufer CCS offset checks into a function Radhakrishna Sripada
2019-11-26 0:26 ` [Intel-gfx] " Radhakrishna Sripada
2019-12-12 16:00 ` Radhakrishna Sripada
2019-11-26 0:26 ` [PATCH v7 6/7] drm/framebuffer/tgl: Format modifier for Intel Gen 12 render compression with Clear Color Radhakrishna Sripada
2019-11-26 0:26 ` [Intel-gfx] " Radhakrishna Sripada
2019-11-26 0:26 ` [PATCH v7 7/7] drm/i915/tgl: Add Clear Color support for TGL Render Decompression Radhakrishna Sripada
2019-11-26 0:26 ` [Intel-gfx] " Radhakrishna Sripada
2019-11-26 20:48 ` Matt Roper
2019-11-26 20:48 ` [Intel-gfx] " Matt Roper
2019-11-26 21:52 ` Sripada, Radhakrishna
2019-11-26 21:52 ` [Intel-gfx] " Sripada, Radhakrishna
2019-11-26 22:00 ` Matt Roper
2019-11-26 22:00 ` [Intel-gfx] " Matt Roper
2019-11-26 22:29 ` Sripada, Radhakrishna
2019-11-26 22:29 ` [Intel-gfx] " Sripada, Radhakrishna
2019-11-27 6:49 ` Saarinen, Jani
2019-11-27 6:49 ` [Intel-gfx] " Saarinen, Jani
2019-11-27 0:26 ` [PATCH v8 " Radhakrishna Sripada
2019-11-27 0:26 ` [Intel-gfx] " Radhakrishna Sripada
2019-11-26 0:34 ` ✗ Fi.CI.CHECKPATCH: warning for Clear Color Support for TGL Render Decompression (rev10) Patchwork
2019-11-26 0:34 ` [Intel-gfx] " Patchwork
2019-11-26 0:57 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-26 0:57 ` [Intel-gfx] " Patchwork
2019-11-27 2:39 ` ✗ Fi.CI.CHECKPATCH: warning for Clear Color Support for TGL Render Decompression (rev11) Patchwork
2019-11-27 2:39 ` [Intel-gfx] " Patchwork
2019-11-27 3:03 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-27 3:03 ` [Intel-gfx] " Patchwork
2019-11-27 13:55 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-27 13:55 ` [Intel-gfx] " Patchwork
2019-12-03 21:35 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Clear Color Support for TGL Render Decompression (rev12) Patchwork
2019-12-03 21:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212155104.GB21507@InViCtUs \
--to=radhakrishna.sripada@intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nanley.g.chery@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox